New issue
Advanced search Search tips

Issue 747044 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Ash add/remove display dev shortcut (Ctrl-Shift-D) doesn't work

Project Member Reported by jamescook@chromium.org, Jul 20 2017

Issue description

chrome fc6bc93f0cb43c4d78b176a14297cfb51b2ed166 r488266

* Run chrome --ash-dev-shortcuts --ash-debug-shortcuts
* Hit Ctrl-Shift-D --> nothing happens

I need it to test system tray code that runs when external monitors are attached and detached. This used to work, even after the Ozone X11 transition. I suspect it broke recently.

P1 because this is a developer productivity issue.

Any ideas?

 

Comment 1 by sky@chromium.org, Jul 20 2017

I thought Kyle made this work recently, but perhaps only for mus/mash.

Comment 2 by osh...@chromium.org, Jul 20 2017

It works at 487607. Will test ToT soon.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f954439d730e7f041c18a77f0836ea2f6e19319f

commit f954439d730e7f041c18a77f0836ea2f6e19319f
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Jul 24 06:13:34 2017

(Re)enable shortcut to add/remove display

It was accidentally disabled in https://chromium-review.googlesource.com/c/576662.

BUG= 747044 
TEST= run with --ash-dev-shortcuts and ctrl-alt-d works.

Change-Id: I9ad84a923f178672176d05b8dbca1710ad0b976b
Reviewed-on: https://chromium-review.googlesource.com/582471
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488924}
[modify] https://crrev.com/f954439d730e7f041c18a77f0836ea2f6e19319f/ash/accelerators/accelerator_controller_delegate_classic.cc

Comment 4 by osh...@chromium.org, Jul 24 2017

Status: Fixed (was: Untriaged)

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment