Should not change wallpaper for small user pods at login screen |
||||||||
Issue descriptionCurrently at the login screen, the wallpaper always matches the focused user pod, even if the focused pod is the small one in the scroll list. We should only update wallpaper for large pod, i.e., do not update wallpaper when tabbing through the pods on the scroll list, until user hits 'Enter' to make a small pod jump to the left to become large. The change won't affect 1 user or 2 users cases.
,
Jul 25 2017
,
Aug 8 2017
,
Aug 8 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9 2017
Pls apply appropriate OSs. Thank you.
,
Aug 9 2017
,
Aug 9 2017
Approving merge to M61 Chrome OS.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a5e50aa5d098dbcc603556b4648bb826940e5fc commit 9a5e50aa5d098dbcc603556b4648bb826940e5fc Author: Wenzhao Zang <wzang@chromium.org> Date: Thu Aug 10 00:42:17 2017 Disable wallpaper updates for small pods at login screen Checked if the focused pod is in LARGE style before sending out 'loadWallpaper' message. Please note: the deleted line in |SigninScreenHandler| actually has the same effect with |SigninScreenHandler::HandleLoadWallpaper| but bypasses the delegate for some reason. Also fixed two small bugs: (1) Cleared the animation classes that might be added earlier, when the user pods are shown again after e.g. closing Gaia page. (2) Updated password field width to accommodate smart lock icons. TBR=wzang@chromium.org (cherry picked from commit 57776ae1d703a17552ec913c737213cf70eff469) Bug: 747039 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I73384c413be23a76947bd4bcfa673fd5fc795be3 Reviewed-on: https://chromium-review.googlesource.com/580376 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489241} Reviewed-on: https://chromium-review.googlesource.com/609275 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#421} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/9a5e50aa5d098dbcc603556b4648bb826940e5fc/chrome/browser/resources/chromeos/login/login_shared.js [modify] https://crrev.com/9a5e50aa5d098dbcc603556b4648bb826940e5fc/chrome/browser/resources/chromeos/login/md_login_shared.js [modify] https://crrev.com/9a5e50aa5d098dbcc603556b4648bb826940e5fc/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/9a5e50aa5d098dbcc603556b4648bb826940e5fc/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h [modify] https://crrev.com/9a5e50aa5d098dbcc603556b4648bb826940e5fc/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/9a5e50aa5d098dbcc603556b4648bb826940e5fc/ui/login/account_picker/md_user_pod_row.js [modify] https://crrev.com/9a5e50aa5d098dbcc603556b4648bb826940e5fc/ui/login/account_picker/user_pod_row.js
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 25 2017