New issue
Advanced search Search tips

Issue 747031 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 748218



Sign in to add a comment

36.7%-550.5% regression in thread_times.key_idle_power_cases at 485991:487676

Project Member Reported by benhenry@google.com, Jul 20 2017

Issue description

A power regression! I'm excited to see if we can bisect.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 20 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=747031

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1ee117655f896cccb83c647246ceb8699ae7d742ac1da6070ae775f905504e08


Bot(s) for this bug's original alert(s):

android-one
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 20 2017

Cc: ssid@chromium.org
Owner: ssid@chromium.org

=== Auto-CCing suspected CL author ssid@chromium.org ===

Hi ssid@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Siddhartha
  Commit : 79fb9f2dadacc419da6ca36c2760a1aaae8fc415
  Date   : Tue Jul 18 18:48:41 2017
  Subject: Add a delay to clear GL context when app is backgrounded

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : thread_times.key_idle_power_cases
  Metric       : tasks_per_second_total_all/css-animation.html
  Change       : 553.47% | 5.30923175331 -> 34.6944755772

Revision             Result                   N
chromium@486073      5.30923 +- 0.691735      6      good
chromium@486875      5.49263 +- 0.647344      6      good
chromium@487276      5.28427 +- 0.968922      6      good
chromium@487476      5.29268 +- 1.16999       5      good
chromium@487526      8.47994 +- 16.7119       6      good
chromium@487533      5.39342 +- 0.880091      6      good
chromium@487536      5.3016 +- 0.820752       6      good
chromium@487538      5.98442 +- 3.76191       6      good
chromium@487539      34.1427 +- 5.45388       6      bad       <--
chromium@487551      33.5861 +- 4.79252       5      bad
chromium@487576      33.2028 +- 5.71904       8      bad
chromium@487676      34.6945 +- 2.91823       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=css.animation.html thread_times.key_idle_power_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973531090972918176


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 21 2017

Labels: Hotlist-Google

Comment 5 by ssid@chromium.org, Jul 24 2017

Blockedon: 748218
Perf sheriff ping: this is still waiting on the blocked bug?

Comment 7 by npm@chromium.org, Dec 7 2017

Status: Assigned (was: Untriaged)
Perf sheriff ping again. ssid, are you still working on this?
Components: Internals>GPU>Metrics

Comment 10 by ssid@chromium.org, Jun 25 2018

Status: Fixed (was: Assigned)
Eric landed a fix for this case, and found some workaround later for this I believe.
https://chromium.googlesource.com/chromium/src/+/f9e460609c08e26f7107e4897e5f1ed85f2a42f3

Sign in to add a comment