reef-uni builder should have unibuild=true in metadata |
||
Issue descriptionAt present the reef-uni builder products output that suggests it is not a unibuild: https://uberchromegw.corp.google.com/i/chromeos/builders/reef-uni-release/builds/83 Select Artifacts: https://pantheon.corp.google.com/storage/browser/chromeos-image-archive/reef-uni-release/R61-9762.0.0 Open metadata.json sdk-version: "2017.07.19.020946", unibuild: false, status: { status: "pass", summary: "", current-time: "Thu, 20 Jul 2017 08:40:52 -0700 (PDT)" }, The unibuild value should be true.
,
Jul 20 2017
Hmm my test is not very good. I think it was picking up a file in the chroot: Couldn't open blob from '/usr/share/chromeos-config/config.dtb': No such file or directory This is probably related to crbug.com/704597 which I have had open for a while.
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9b4522a4bc6b9ba67b381694c11fe28534193b27 commit 9b4522a4bc6b9ba67b381694c11fe28534193b27 Author: Simon Glass <sjg@chromium.org> Date: Fri Jul 21 13:32:04 2017 commands: Correct the operation of the unified build check The current code reads the config file and the fdtget tool from the wrong places (they are swapped). Adjust this to behave correctly: - config.dtb should come from the board's root inside the chroot - fdtget should come from the chroot itself Tidy up the function comment a little also to make it clearer. BUG= chromium:747023 BUG= chromium:704597 TEST=PYTHONPATH=~/cosarm ./commands_unittest PYTHONPATH=~/cosarm ./build_stages_unittest Also manually print out a few things as the test is not very good Change-Id: If54a1e7165bca07f10d2d789992ccba95c78b8ff Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/579792 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/9b4522a4bc6b9ba67b381694c11fe28534193b27/cbuildbot/stages/build_stages_unittest.py [modify] https://crrev.com/9b4522a4bc6b9ba67b381694c11fe28534193b27/cbuildbot/commands.py [modify] https://crrev.com/9b4522a4bc6b9ba67b381694c11fe28534193b27/cbuildbot/commands_unittest.py
,
Jul 24 2017
OK that seemed to fix it. https://uberchromegw.corp.google.com/i/chromeos/builders/reef-uni-release/builds/96 |
||
►
Sign in to add a comment |
||
Comment 1 by sjg@chromium.org
, Jul 20 2017Status: Started (was: Untriaged)