New issue
Advanced search Search tips

Issue 747022 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add a devtools command to force subresource_filter activation

Project Member Reported by csharrison@chromium.org, Jul 20 2017

Issue description

This will be useful for devs that want to test their site under this experimental feature.
 
Screenshots of the new devtools commands.
devtools_show_ads.png
331 KB View Download
devtools_block.png
154 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad2cfd96126ac857c213eca91611cca528199efa

commit ad2cfd96126ac857c213eca91611cca528199efa
Author: Charles Harrison <csharrison@chromium.org>
Date: Sat Jul 29 06:10:07 2017

[subresource_filter] Force activation via devtools command

Bug:  747022 
Change-Id: I222594af09156a26921df0888c8ddf51afbce5d4
Reviewed-on: https://chromium-review.googlesource.com/577671
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490633}
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/chrome/browser/devtools/chrome_devtools_manager_delegate.h
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/chrome/browser/subresource_filter/chrome_subresource_filter_client.h
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/chrome/browser/subresource_filter/subresource_filter_unittest.cc
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/components/subresource_filter/content/browser/subresource_filter_client.h
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/third_party/WebKit/Source/devtools/front_end/main/module.json
[modify] https://crrev.com/ad2cfd96126ac857c213eca91611cca528199efa/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment