Repair broken login for rasterize_and_record_micro.top_25 Google stories |
||||||||||||
Issue descriptionrasterize_and_record_micro.top_25 failing on chromium.perf/Linux Perf Builders failed on: - Linux Perf: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf Ned, I am adding you here as there is no owner for this test.
,
Jul 20 2017
This is probably because Stephen enabled the test, which was failing before. https://chromium-review.googlesource.com/c/567560/
,
Jul 20 2017
=== BISECT JOB RESULTS === Test failure found but unable to narrow commit range Build failures prevented the bisect from narrowing the range further. Bisect Details Configuration: linux_perf_bisect Benchmark : rasterize_and_record_micro.top_25 Metric : benchmark_duration/benchmark_duration Suspected Commit Range 2 commits in range https://chromium.googlesource.com/chromium/src/+log/a8ab1a3bf830a96afb98a655f1b7e991dd2f88e5..b0c9bd0c21dd368849f1855e6888449591ceb76e Revision Exit Code N chromium@485712 1 +- N/A 5 good chromium@485714 1 +- N/A 5 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests rasterize_and_record_micro.top_25 More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8973532500086738880 For feedback, file a bug with component Speed>Bisection
,
Jul 20 2017
Zhen: can you just disable the test on Linux for now? We will overhaul how rasterize_and_record_micro work later (issue 717218)
,
Jul 21 2017
Disable CL uploaded at: https://chromium-review.googlesource.com/c/581868/
,
Jul 21 2017
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/461529643e6760b9de83af55a70ad7a4a1621434 commit 461529643e6760b9de83af55a70ad7a4a1621434 Author: Zhen Wang <zhenw@chromium.org> Date: Mon Jul 24 07:28:26 2017 Disable rasterize_and_record_micro.top_25 gmail story on Linux Perf bot Bug: 747021 Change-Id: I0015d2c35db968bf9706bc2dec59c4c31054438f Reviewed-on: https://chromium-review.googlesource.com/581868 Reviewed-by: rnephew <rnephew@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#488928} [modify] https://crrev.com/461529643e6760b9de83af55a70ad7a4a1621434/tools/perf/benchmarks/rasterize_and_record_micro.py
,
Jul 24 2017
,
Aug 7 2017
Broadening this to all platforms, as it's now failing everywhere.
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/652f60156da67336ab4a5ed86b4f0ac6878cca86 commit 652f60156da67336ab4a5ed86b4f0ac6878cca86 Author: Charlie Andrews <charliea@chromium.org> Date: Fri Aug 11 18:36:08 2017 Disable rasterize_and_record_micro's gmail story on all platforms NOTRY=true TBR=nednguyen@google.com Bug: 747021 Change-Id: Ieb8d3344932bae59eec3edbab5b7ef9885b8ef4c Reviewed-on: https://chromium-review.googlesource.com/604235 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#493822} [modify] https://crrev.com/652f60156da67336ab4a5ed86b4f0ac6878cca86/tools/perf/benchmarks/rasterize_and_record_micro.py
,
Aug 11 2017
[cc-ing test owners] This is Pri-2 as the offending page has been disabled.
,
Aug 16 2017
Picking up various likely related rasterize_and_record_micro benchmark failure issues for bulk investigation soon.
,
Aug 21 2017
Standardising priority and component for this batch of rasterize_and_record_micro bugs filed to track intended-to-be-temporary disabling.
,
Aug 21 2017
Duping redundant rasterize_and_record_micro failing issues to one meta tracking issue. Note one of these bugs was specifically re: re-enabling the Gmail story for rasterize_and_record_micro.top_25.
,
Sep 1 2017
On local Linux yesterday-ToT all of the Google web app stories (at least Gmail, Docs, Calendar, and Search so far) for rasterize_and_record_micro are failing with a login screen that hangs and then eventually logs an error, samples below. Only the Gmail story is currently explicitly disabled. The Linux Perf bots are all purple right now due to capacity issue (from checkpoint with nednguyen@) so I can't check whether they are/have all been failing there. The first obvious thing to look at is the new login helper module noted in the logs below. Purple bots link: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf Disabled stories link: https://cs.chromium.org/chromium/src/tools/perf/benchmarks/rasterize_and_record_micro.py?q=rasterize_and_record_micro&l=63 Log excerpts below. ===== SKIPPING TEST https://mail.google.com/mail/: crbug.com/747021 ===== [ OK ] https://mail.google.com/mail/ (4 ms) [ RUN ] https://www.google.com/calendar/ /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/browser/browser_credentials.py:64: UserWarning: Function LoginNeeded is deprecated. It will no longer be supported on May 05, 2017. Please remove it or switch to an alternative before that time. FormBasedCredentialsBackend is deprecated. Use the login helper modules in https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/page_sets/login_helpers/ instead. tab, runner, self._credentials[credentials_type]) (WARNING) 2017-09-01 10:23:56,989 form_based_credentials_backend.LoginNeeded:127 Timed out while loading: https://accounts.google.com/ServiceLogin?continue=https%3A%2F%2Faccounts.google.com%2FManageAccount /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/image_processing/image_util_numpy_impl.py:70: UserWarning: Using pure python png decoder, which could be very slow. To speed up, consider installing numpy & cv2 (OpenCV). 'Using pure python png decoder, which could be very slow. To speed up, ' Traceback (most recent call last): File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 105, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function return func(*args, **kwargs) File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 330, in RunStory self._PreparePage() File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function return func(*args, **kwargs) File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 311, in _PreparePage 'Login as ' + self._current_page.credentials + ' failed') Failure: Login as google failed Calendar and Google Search also show same issue: ===== SKIPPING TEST https://mail.google.com/mail/: crbug.com/747021 ===== [ OK ] https://mail.google.com/mail/ (4 ms) [ RUN ] https://www.google.com/calendar/ /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/browser/browser_credentials.py:64: UserWarning: Function LoginNeeded is deprecated. It will no longer be supported on May 05, 2017. Please remove it or switch to an alternative before that time. FormBasedCredentialsBackend is deprecated. Use the login helper modules in https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/page_sets/login_helpers/ instead. tab, runner, self._credentials[credentials_type]) (WARNING) 2017-09-01 10:23:56,989 form_based_credentials_backend.LoginNeeded:127 Timed out while loading: https://accounts.google.com/ServiceLogin?continue=https%3A%2F%2Faccounts.google.com%2FManageAccount /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/image_processing/image_util_numpy_impl.py:70: UserWarning: Using pure python png decoder, which could be very slow. To speed up, consider installing numpy & cv2 (OpenCV). 'Using pure python png decoder, which could be very slow. To speed up, ' Traceback (most recent call last): File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 105, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function return func(*args, **kwargs) File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 330, in RunStory self._PreparePage() File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function return func(*args, **kwargs) File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 311, in _PreparePage 'Login as ' + self._current_page.credentials + ' failed') Failure: Login as google failed [ FAILED ] https://www.google.com/calendar/ (78498 ms) [ RUN ] https://www.google.com/search?q=cats&tbm=isch (WARNING) 2017-09-01 10:25:18,986 form_based_credentials_backend.LoginNeeded:127 Timed out while loading: https://accounts.google.com/ServiceLogin?continue=https%3A%2F%2Faccounts.google.com%2FManageAccount Traceback (most recent call last): File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 105, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function return func(*args, **kwargs) File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 330, in RunStory self._PreparePage() File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function return func(*args, **kwargs) File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 311, in _PreparePage 'Login as ' + self._current_page.credentials + ' failed') Failure: Login as google failed [ FAILED ] https://www.google.com/search?q=cats&tbm=isch (81989 ms) [ RUN ] Docs (1 open document tab) (WARNING) 2017-09-01 10:26:42,505 form_based_credentials_backend.LoginNeeded:127 Timed out while loading: https://accounts.google.com/ServiceLogin?continue=https%3A%2F%2Faccounts.google.com%2FManageAccount Traceback (most recent call last): File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 105, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function return func(*args, **kwargs) File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 330, in RunStory self._PreparePage() File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function return func(*args, **kwargs) File "/usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 311, in _PreparePage 'Login as ' + self._current_page.credentials + ' failed') Failure: Login as google failed [ FAILED ] Docs (1 open document tab) (83528 ms)
,
Sep 1 2017
The exact failing Google stories once full run completed: [ FAILED ] https://www.google.com/calendar/ [ FAILED ] https://www.google.com/search?q=cats&tbm=isch [ FAILED ] Docs (1 open document tab) [ FAILED ] https://plus.google.com/110031535020051778989/posts [ FAILED ] http://www.youtube.com [ FAILED ] Blogger
,
Sep 1 2017
,
Sep 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e093016b4d1d7291575365277c3105ae165fe75e commit e093016b4d1d7291575365277c3105ae165fe75e Author: Walter Korman <wkorman@chromium.org> Date: Sat Sep 02 00:50:28 2017 Update Top Pages story login logic for Google and Facebook. Replace deprecated broken login logic for Google stories with the new supported login helpers, following: https://chromium-review.googlesource.com/c/chromium/src/+/546615 Switch Facebook story to remove login. We have three Facebook test accounts. The first two both hit a wall at login asking for birthdate confirmation. The last one is the "recommended, approved" Facebook test account, but it also is known to be unable to view actual page content for some not-planned-to-be-changed reason. Since the whole point of the existing FB story was to view Barack Obama's FB page content, my design decision is to cease logging in and retrieve that page content though now we are no longer testing the normal set of FB logged-in-user functionality. Between dreams and reality, can there be a middle ground? Only time will tell. Bug: 756117 , 747021 Change-Id: Ia75e3fe1d5d89dac28ceb17cf9d4b495fa8ba70c Reviewed-on: https://chromium-review.googlesource.com/648252 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#499357} [modify] https://crrev.com/e093016b4d1d7291575365277c3105ae165fe75e/tools/perf/page_sets/top_pages.py
,
Sep 2 2017
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82102d061fcc284e520803bad8670ed5ba939990 commit 82102d061fcc284e520803bad8670ed5ba939990 Author: Charlie Andrews <charliea@chromium.org> Date: Thu Sep 14 23:19:27 2017 Update top_25 WPR recordings I'm fairly sure that they should have been updated in http://crrev.com/c/648252, but it was overlooked. Bug: 756117 , 747021 , 765383 Change-Id: I4ebb7a5cbaf9fa52c99ba9f05d990ca639f3d3e7 Reviewed-on: https://chromium-review.googlesource.com/667250 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#502092} [modify] https://crrev.com/82102d061fcc284e520803bad8670ed5ba939990/tools/perf/page_sets/data/top_25.json [add] https://crrev.com/82102d061fcc284e520803bad8670ed5ba939990/tools/perf/page_sets/data/top_25_011.wprgo.sha1 |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 20 2017