New issue
Advanced search Search tips

Issue 747020 link

Starred by 1 user
Status: Fixed
Owner:
morlovich@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 689520



Sign in to add a comment

Convert disk_cache backend usage away from browser-level cache thread.

Project Member Reported by morlovich@chromium.org, Jul 20 2017 
Per request from task scheduler thread.

https://chromium-review.googlesource.com/c/565465 has the prototype; though not 100% done yet, and too complex to land in one piece anyway.

Key difficulty is the need for a replacement mechanism for synchronizing 
with disk I/O done by outside clients; also an opportunity since the use of passed-in runner doesn't really work right with Simple.

Comment 1 by morlovich@chromium.org, Jul 20 2017

Blocking: 689520
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05651bf90ececd54ef7a7c51bef4c88ddaa507cf

commit 05651bf90ececd54ef7a7c51bef4c88ddaa507cf
Author: Maks Orlovich <morlovich@chromium.org>
Date: Mon Jul 24 15:20:26 2017

Create a memory cache for OTR context in content_shell,
rather than two disk caches with the same path --- that doesn't really
work right, and some pending work may make it fail harder.

(Only BackgroundSyncBrowserTest.Incognito seemed to have accessed both
 contexts at once, though)

Bug:  747020 
Change-Id: Id794a13e4d0f81aaf2093e102daa4dbb24be241b
Reviewed-on: https://chromium-review.googlesource.com/582168
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488974}
[modify] https://crrev.com/05651bf90ececd54ef7a7c51bef4c88ddaa507cf/content/shell/browser/layout_test/layout_test_browser_context.cc
[modify] https://crrev.com/05651bf90ececd54ef7a7c51bef4c88ddaa507cf/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc
[modify] https://crrev.com/05651bf90ececd54ef7a7c51bef4c88ddaa507cf/content/shell/browser/layout_test/layout_test_url_request_context_getter.h
[modify] https://crrev.com/05651bf90ececd54ef7a7c51bef4c88ddaa507cf/content/shell/browser/shell_browser_context.cc
[modify] https://crrev.com/05651bf90ececd54ef7a7c51bef4c88ddaa507cf/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/05651bf90ececd54ef7a7c51bef4c88ddaa507cf/content/shell/browser/shell_url_request_context_getter.h
[modify] https://crrev.com/05651bf90ececd54ef7a7c51bef4c88ddaa507cf/extensions/shell/browser/shell_url_request_context_getter.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/463dc50e730013d2c12f913bebf8e417d9312789

commit 463dc50e730013d2c12f913bebf8e417d9312789
Author: Maks Orlovich <morlovich@chromium.org>
Date: Tue Jul 25 14:52:49 2017

Prep for no global cache thread: let backends make their own.

In particular, the backend constructors will now permit null as the
"thread" parameter, and create their own fallback:
A private TYPE_IO thread for blockfile (and only one globally),
a SequencedTaskRunner for simple.

Add a CreateCacheBackend variant that doesn't take the thread
argument, and start using it in some of our local tests.

(Next steps include converting HttpCache usage, external clients that don't
 have fancy sequencing requirements, adding an API for fancy sequencing
 requirements, converting clients that need it, and finally removing
 the injection).

Bug:  747020 
Change-Id: I8a8a5af4c16eac27ff6e639f1b6e9e5b7b043929
Reviewed-on: https://chromium-review.googlesource.com/579871
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489295}
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/disk_cache/backend_unittest.cc
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/disk_cache/blockfile/backend_impl.cc
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/disk_cache/blockfile/backend_impl.h
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/disk_cache/disk_cache.cc
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/disk_cache/disk_cache.h
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/disk_cache/disk_cache_test_base.cc
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/disk_cache/disk_cache_test_base.h
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/disk_cache/simple/simple_backend_impl.cc
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/disk_cache/simple/simple_backend_impl.h
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/disk_cache/simple/simple_index_file.cc
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/disk_cache/simple/simple_index_file.h
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/disk_cache/simple/simple_index_file_unittest.cc
[modify] https://crrev.com/463dc50e730013d2c12f913bebf8e417d9312789/net/tools/disk_cache_memory_test/disk_cache_memory_test.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19450cb1ddf189d11544d4b3d1281d09efaec0b0

commit 19450cb1ddf189d11544d4b3d1281d09efaec0b0
Author: Maks Orlovich <morlovich@chromium.org>
Date: Wed Jul 26 15:38:18 2017

Make HttpCache backend creation not take a thread.
Just rely on the backend default instead.
This also strips all the wiring of it through higher-level methods.

Bug:  747020 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I16082ebff0a0a786dbcb5964b228a3772938f1dc
Reviewed-on: https://chromium-review.googlesource.com/585152
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489654}
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/ios/web/shell/shell_browser_state.mm
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/ios/web/shell/shell_url_request_context_getter.h
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/ios/web/shell/shell_url_request_context_getter.mm
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/ios/web_view/internal/web_view_browser_state.mm
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/ios/web_view/internal/web_view_url_request_context_getter.h
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/ios/web_view/internal/web_view_url_request_context_getter.mm
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/net/http/http_cache.cc
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/net/http/http_cache.h
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/19450cb1ddf189d11544d4b3d1281d09efaec0b0/net/url_request/url_request_context_builder.h
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/036fd1f21f7a30219442b1c66669a1dc761ca0d7

commit 036fd1f21f7a30219442b1c66669a1dc761ca0d7
Author: Maks Orlovich <morlovich@chromium.org>
Date: Mon Aug 07 17:51:11 2017

disk_cache: Add an API for synchronizing with post-backend dtor I/O;
also automatically sequence new creation of backends for a path
after completion of destruction of previous backends for that path.

Bug:  747020 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I90dca69dabd2b8656f3bcfedaa3c964e95ed9133
Reviewed-on: https://chromium-review.googlesource.com/587128
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492354}
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/BUILD.gn
[add] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/backend_cleanup_tracker.cc
[add] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/backend_cleanup_tracker.h
[add] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/backend_cleanup_tracker_unittest.cc
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/backend_unittest.cc
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/blockfile/backend_impl.cc
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/blockfile/backend_impl.h
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/disk_cache.cc
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/disk_cache.h
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/disk_cache_perftest.cc
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/disk_cache_test_base.cc
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/memory/mem_backend_impl.cc
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/memory/mem_backend_impl.h
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/simple/simple_backend_impl.cc
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/simple/simple_backend_impl.h
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/simple/simple_entry_impl.cc
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/simple/simple_entry_impl.h
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/simple/simple_index.cc
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/simple/simple_index.h
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/simple/simple_index_file_unittest.cc
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/disk_cache/simple/simple_index_unittest.cc
[modify] https://crrev.com/036fd1f21f7a30219442b1c66669a1dc761ca0d7/net/tools/crash_cache/crash_cache.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1443e168a3071337d0ed9b9d00501cc366fc7cb

commit a1443e168a3071337d0ed9b9d00501cc366fc7cb
Author: Maks Orlovich <morlovich@chromium.org>
Date: Tue Aug 08 00:10:26 2017

Migrate shader cache away from going-away browser cache thread to
backend-internal one.

Bug:  747020 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5d6b795778c35bf9857f0cb7a1e61e0376747175
Reviewed-on: https://chromium-review.googlesource.com/586671
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492464}
[modify] https://crrev.com/a1443e168a3071337d0ed9b9d00501cc366fc7cb/content/browser/browser_main_loop.cc
[modify] https://crrev.com/a1443e168a3071337d0ed9b9d00501cc366fc7cb/content/browser/gpu/shader_cache_factory.cc
[modify] https://crrev.com/a1443e168a3071337d0ed9b9d00501cc366fc7cb/content/browser/gpu/shader_cache_factory.h
[modify] https://crrev.com/a1443e168a3071337d0ed9b9d00501cc366fc7cb/content/browser/storage_partition_impl_unittest.cc
[modify] https://crrev.com/a1443e168a3071337d0ed9b9d00501cc366fc7cb/gpu/ipc/host/shader_disk_cache.cc
[modify] https://crrev.com/a1443e168a3071337d0ed9b9d00501cc366fc7cb/gpu/ipc/host/shader_disk_cache.h
[modify] https://crrev.com/a1443e168a3071337d0ed9b9d00501cc366fc7cb/gpu/ipc/host/shader_disk_cache_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b12bd89c987680f2911ec0d277e63ef7a4a9e10

commit 5b12bd89c987680f2911ec0d277e63ef7a4a9e10
Author: Maks Orlovich <morlovich@chromium.org>
Date: Thu Aug 10 20:40:28 2017

CacheStorage: Migrate away from global cache thread.

This mostly relies on automatic ordering done by CreateCacheBackend, but
also provides a new ::CloseImpl implementation that uses
CreateCacheBackend's new callback to know when it's fully complete, for
clients that actually use it (which might just be tests).

Bug:  747020 
Change-Id: I1dd57a92a1963fb31aa88fd09ec33bb18d135e94
Reviewed-on: https://chromium-review.googlesource.com/609185
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493529}
[modify] https://crrev.com/5b12bd89c987680f2911ec0d277e63ef7a4a9e10/content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc
[modify] https://crrev.com/5b12bd89c987680f2911ec0d277e63ef7a4a9e10/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/5b12bd89c987680f2911ec0d277e63ef7a4a9e10/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/5b12bd89c987680f2911ec0d277e63ef7a4a9e10/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/5b12bd89c987680f2911ec0d277e63ef7a4a9e10/content/browser/cache_storage/cache_storage_manager_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49b1594550778be788e86953fe6d17401e96b5f8

commit 49b1594550778be788e86953fe6d17401e96b5f8
Author: Maks Orlovich <morlovich@chromium.org>
Date: Mon Aug 14 16:41:17 2017

AppCache, ServiceWorker: Do disk cleanup when disk_cache callback indicates

This replaces scheduling it on cache thread which is:
1) Going away
2) Didn't quite work right with simple cache backend anyway.

Bug:  747020 
Change-Id: If0934fe8d5cac87cfe42b32eda6af9cf16fe00d6
Reviewed-on: https://chromium-review.googlesource.com/603972
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494071}
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/appcache/appcache_disk_cache.cc
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/appcache/appcache_disk_cache.h
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/appcache/appcache_disk_cache_unittest.cc
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/appcache/appcache_service_impl.cc
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/appcache/appcache_service_impl.h
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/appcache/appcache_storage_impl.cc
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/appcache/appcache_storage_impl.h
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/appcache/chrome_appcache_service.cc
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/service_worker/service_worker_context_core.cc
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/service_worker/service_worker_context_core.h
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/service_worker/service_worker_context_wrapper.h
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/service_worker/service_worker_storage.cc
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/service_worker/service_worker_storage.h
[modify] https://crrev.com/49b1594550778be788e86953fe6d17401e96b5f8/content/browser/service_worker/service_worker_storage_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8342b9d1a124b1990b6b94cc41bf7d9d3afe0d34

commit 8342b9d1a124b1990b6b94cc41bf7d9d3afe0d34
Author: Maks Orlovich <morlovich@chromium.org>
Date: Mon Aug 14 19:59:56 2017

Migrate blob storage away from deprecated CreateCacheBackend variant

It is no longer necessary to pass in a thread (and it was not used for
anything when using net::MEMORY_CACHE anyway), and I plan to remove
the variant that permits one to.

Bug:  747020 
Change-Id: I6f6cc3e5907a2da625fa3b1d7fce565dadec71c7
Reviewed-on: https://chromium-review.googlesource.com/613960
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494149}
[modify] https://crrev.com/8342b9d1a124b1990b6b94cc41bf7d9d3afe0d34/content/browser/blob_storage/blob_url_unittest.cc
[modify] https://crrev.com/8342b9d1a124b1990b6b94cc41bf7d9d3afe0d34/storage/browser/blob/blob_reader_unittest.cc
[modify] https://crrev.com/8342b9d1a124b1990b6b94cc41bf7d9d3afe0d34/storage/browser/blob/blob_storage_context_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61419e7bdddeccd59ba9d8c9069e20307302ded4

commit 61419e7bdddeccd59ba9d8c9069e20307302ded4
Author: Maks Orlovich <morlovich@chromium.org>
Date: Tue Aug 15 14:42:05 2017

Migrate pnacl cache away from BrowserThread::CACHE to disk_cache backend's-internal choice.

Unfortunately the test fixture / TestBrowserThreadBundle doesn't
know about cache backend internal threads, so a separate flush call
is needed.

Bug:  747020 
Change-Id: Ib015690b7f812df86b9e4f20e3c9165cfa6ffa0a
Reviewed-on: https://chromium-review.googlesource.com/586948
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494378}
[modify] https://crrev.com/61419e7bdddeccd59ba9d8c9069e20307302ded4/components/nacl/browser/pnacl_host_unittest.cc
[modify] https://crrev.com/61419e7bdddeccd59ba9d8c9069e20307302ded4/components/nacl/browser/pnacl_translation_cache.cc

Comment 11 by morlovich@chromium.org, Aug 15 2017

Status: Fixed (was: Started)
Main objective achieved, just a few loose ends to cleanup.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cdee11d699afb9f8807aeb7faab2c619540b031

commit 8cdee11d699afb9f8807aeb7faab2c619540b031
Author: Maks Orlovich <morlovich@chromium.org>
Date: Mon Aug 28 18:40:54 2017

SimpleCache: Cleanup: make ctor take SequencedTaskRunner.

This is already what was being used internally, so requiring
a SingleThreadTaskRunner was historical.

Bug:  747020 
Change-Id: I1d21a07ed5258bbca67478ced9c4626b284f988f
Reviewed-on: https://chromium-review.googlesource.com/615143
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497815}
[modify] https://crrev.com/8cdee11d699afb9f8807aeb7faab2c619540b031/net/disk_cache/simple/simple_backend_impl.cc
[modify] https://crrev.com/8cdee11d699afb9f8807aeb7faab2c619540b031/net/disk_cache/simple/simple_backend_impl.h
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/461ab1f5d4c1823d7e2e496ed2cfdbf9b80fb935

commit 461ab1f5d4c1823d7e2e496ed2cfdbf9b80fb935
Author: Maks Orlovich <morlovich@chromium.org>
Date: Tue Sep 05 14:49:05 2017

disk_cache: Remove the deprecated/unused CreateCacheBackend overload.

There were still a few tests exercising it, and cachetool, but nothing outside
net/ remained.

Bug:  747020 
Change-Id: I0b3ab6cefc49375bc7e0d26555d86a2ab30fe398
Reviewed-on: https://chromium-review.googlesource.com/639093
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499628}
[modify] https://crrev.com/461ab1f5d4c1823d7e2e496ed2cfdbf9b80fb935/net/disk_cache/backend_unittest.cc
[modify] https://crrev.com/461ab1f5d4c1823d7e2e496ed2cfdbf9b80fb935/net/disk_cache/disk_cache.cc
[modify] https://crrev.com/461ab1f5d4c1823d7e2e496ed2cfdbf9b80fb935/net/disk_cache/disk_cache.h
[modify] https://crrev.com/461ab1f5d4c1823d7e2e496ed2cfdbf9b80fb935/net/tools/cachetool/cachetool.cc
►

Sign in to add a comment