nassh: Open as window doesn't work from bookmark bar |
||||||||
Issue descriptionChrome Version : 59.0.3071.115 OS Version: Linux URLs (if applicable) : chrome-extension://pnhechapfaindjhompbnflcldabbghjo/html/nassh.html Go to apps, right click on SecureShell and mark "Open as window": https://screenshot.googleplex.com/zz5d6xMXoEN Grab the app to the bookmark bar to be able to launch it without typing the url: https://screenshot.googleplex.com/ZZDFJVmHtwh Click the bookmarked icon, it doesn't open new window, but replaces current tab
,
Aug 3 2017
Mac doesn't have `Open as Window`. Not without Issue 565591 anyway.
,
Oct 24 2017
seems unlikely that this behavior will change in Chrome, so we'll probably want to figure out a workaround for Secure Shell itself
,
Jan 12
i'm going to add an openas=window option so people can pick the behavior themselves. some actually want a tab.
,
Jan 12
,
Jan 13
The following revision refers to this bug: https://chromium.googlesource.com/apps/libapps/+/e02436d0ffcc05a1fdda7f1e5b59fdaae20285f2 commit e02436d0ffcc05a1fdda7f1e5b59fdaae20285f2 Author: Mike Frysinger <vapier@chromium.org> Date: Sun Jan 13 20:55:03 2019 nassh: allow bookmarks to open as windows Since Chrome always opens bookmarks as a tab and offers no option to change this, we have to add code to handle it ourselves. Add support for a new 'openas=window' query string setting so Secure Shell will automatically reopen itself as a window. Since Chrome doesn't let tabs open windows with chrome=no, we have to leverage the background page (which is in a more trusted context) to make the window open call for us. We also tweak the context New Window setting to do the same. Before, it'd open a new window but with the location bar, and not be able to capture the Ctrl-N/etc... shortcuts. For now we assume that anyone who opens Secure Shell in a tab and then right clicks to open a new window wants it to be a real window and not a looks-like-but-isn't- really a standalone window. Bug: 747003 Change-Id: I321e41125b1f22a0de5399c1d19773ac6a16e412 Reviewed-on: https://chromium-review.googlesource.com/c/1408090 Reviewed-by: Vitaliy Shipitsyn <vsh@google.com> Tested-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/e02436d0ffcc05a1fdda7f1e5b59fdaae20285f2/nassh/js/nassh_main.js [modify] https://crrev.com/e02436d0ffcc05a1fdda7f1e5b59fdaae20285f2/nassh/doc/FAQ.md
,
Jan 13
the 0.11 release will have this setting
,
Jan 13
I think this is a case for launch events.
,
Jan 13
Launch events explainer: https://github.com/WICG/sw-launch/blob/master/explainer.md
,
Jan 14
correct me if i'm wrong, but my understanding is: - launch events only work with Service Workers - Service Workers aren't allowed to intercept chrome-extension:// URIs (even if it is the chrome-extension:// itself registering the sw) - therefore launch events wouldn't help here this would be useful if they were paired with a PWA. i'm hoping to get to that point with Secure Shell, so i'll keep it in mind if/when browsers support it.
,
Jan 14
Yeah, this would be a very long term possibility. Nothing to be done at the moment. +lazyboy re Service Workers + extensions got mentioned. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 Deleted