New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 747001 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

blink_perf.css failing on 3 Android Perf bots

Project Member Reported by zh...@chromium.org, Jul 20 2017

Issue description

Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jul 21 2017

Cc: nainar@chromium.org
Owner: nainar@chromium.org

=== Auto-CCing suspected CL author nainar@chromium.org ===

Hi nainar@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : Naina Raisinghani
  Commit : ad0ccd37620cfc7e6cd1030ae323a6df051c1e7c
  Date   : Wed Jul 19 07:02:54 2017
  Subject: Add testcases to PerformanceTests/CSS to test changing style using selectors

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : blink_perf.css
  Metric       : AttributeDescendantSelector/AttributeDescendantSelector.html

Revision             Exit Code      N
chromium@487773      0 +- N/A       5      good
chromium@487774      1 +- N/A       5      bad       <--
chromium@487775      1 +- N/A       5      bad
chromium@487777      1 +- N/A       5      bad
chromium@487780      1 +- N/A       5      bad
chromium@487786      1 +- N/A       5      bad
chromium@487798      1 +- N/A       5      bad
chromium@487823      1 +- N/A       5      bad
chromium@487872      1 +- N/A       5      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.css

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973534317143936944


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79c900fab5e69a3e818c3b76ae5ed5cc28629f6d

commit 79c900fab5e69a3e818c3b76ae5ed5cc28629f6d
Author: Naina Raisinghani <nainar@chromium.org>
Date: Fri Jul 21 06:43:42 2017

Fix Slow CSS Performance tests timing out.

This patch reduces the tree size for slower performance tests
ensuring they don't time out.

Bug:  747001 
Change-Id: I3e87f1b68b3effcd04c8da2e673bd3e05f2374ed
Reviewed-on: https://chromium-review.googlesource.com/580011
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488603}
[modify] https://crrev.com/79c900fab5e69a3e818c3b76ae5ed5cc28629f6d/third_party/WebKit/PerformanceTests/CSS/ChangeStyleNestedPseudoSelector.html
[modify] https://crrev.com/79c900fab5e69a3e818c3b76ae5ed5cc28629f6d/third_party/WebKit/PerformanceTests/CSS/ChangeStyleSinglePseudoSelector.html

Comment 4 by nainar@chromium.org, Jul 24 2017

Status: Fixed (was: Available)

Sign in to add a comment