thread_times.polymer failing on Android Perf bots |
|||||
Issue descriptionthread_times.polymer failing on 6 Android perf bots Builders failed on: - Android Nexus5 Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf - Android Nexus5X Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf - Android Nexus5X WebView Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20WebView%20Perf - Android Nexus6 Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf - Android Nexus7v2 Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf - Android One Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf
,
Jul 20 2017
=== Auto-CCing suspected CL author hayato@chromium.org === Hi hayato@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Test failure found with culprit Suspected Commit Author : Hayato Ito Commit : b160073dd51148f56b6586a9902b8a24674886c4 Date : Wed Jul 19 04:33:31 2017 Subject: Reland: Make /deep/ as no-op and remove ::shadow in dynamic profile Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : thread_times.polymer Metric : benchmark_duration/benchmark_duration Revision Exit Code N chromium@487678 0 +- N/A 5 good chromium@487728 0 +- N/A 5 good chromium@487741 0 +- N/A 5 good chromium@487744 0 +- N/A 5 good chromium@487745 1 +- N/A 5 bad <-- chromium@487746 1 +- N/A 5 bad chromium@487747 1 +- N/A 5 bad chromium@487753 1 +- N/A 5 bad chromium@487777 1 +- N/A 5 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.polymer More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8973534588980613392 For feedback, file a bug with component Speed>Bisection
,
Jul 21 2017
It looks the benchmark uses PolymerPageSet: https://cs.chromium.org/chromium/src/tools/perf/page_sets/polymer.py?q=PolymerPageSet&sq=package:chromium&l=222 I guess these pages are using /deep/ or ::shadow. ykikyip@, could you have a chance to look?
,
Jul 21 2017
ykyyip doesn't work on polymer anymore. Ned, Charlie, should we just remove this benchamrk?
,
Jul 21 2017
A benchmark is only as good as we have people to maintain it. I will remove this.
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/435188ccd7fc5a58e35f78928270954d0aede221 commit 435188ccd7fc5a58e35f78928270954d0aede221 Author: nednguyen <nednguyen@google.com> Date: Fri Jul 21 16:59:04 2017 Remove thread_times.polymer benchmark This benchmark is broken, and benchmark owner no longer works on the Chromium project. Bug: 747000 Change-Id: Ideddacfdf10b4628eb660eb37bee270d4f339020 Reviewed-on: https://chromium-review.googlesource.com/581417 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488684} [modify] https://crrev.com/435188ccd7fc5a58e35f78928270954d0aede221/testing/buildbot/chromium.perf.json [modify] https://crrev.com/435188ccd7fc5a58e35f78928270954d0aede221/tools/perf/benchmark.csv [modify] https://crrev.com/435188ccd7fc5a58e35f78928270954d0aede221/tools/perf/benchmarks/thread_times.py
,
Jul 21 2017
,
Jul 21 2017
,
Jul 22 2017
,
Jul 24 2017
Thanks for doing this Ned! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 20 2017