New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746987 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature



Sign in to add a comment

Chrome Cleaner UI: Add more UMA stats

Project Member Reported by alito@chromium.org, Jul 20 2017

Issue description

We need some more UMA histograms for the new Chrome Cleaner UI. These include:
- the time it takes users to accept/decline the prompt
- Scanning and cleaning times
- Possibly user actions (maybe for both the prompt dialog and the user's interaction with the webui card)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d1f330a1d46c31548b9d0319712daf5b0a16e1f

commit 4d1f330a1d46c31548b9d0319712daf5b0a16e1f
Author: Ali Tofigh <alito@chromium.org>
Date: Thu Jul 20 23:14:05 2017

Chrome Cleaner UI: Add some UMA histograms

This adds UMA histograms for keeping track of how long it takes for
the Chrome Cleaner to scan and clean user's machines as well as the
time it takes for users to interact with the Chrome Cleaner prompt
dialog.

Bug:  746987 
Change-Id: If4d70c196f68c462834cb0c1e8a82a8bfaa6ea05
Reviewed-on: https://chromium-review.googlesource.com/580087
Commit-Queue: Ali Tofigh <alito@chromium.org>
Reviewed-by: Robert Shield <robertshield@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488475}
[modify] https://crrev.com/4d1f330a1d46c31548b9d0319712daf5b0a16e1f/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.cc
[modify] https://crrev.com/4d1f330a1d46c31548b9d0319712daf5b0a16e1f/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h
[modify] https://crrev.com/4d1f330a1d46c31548b9d0319712daf5b0a16e1f/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.cc
[modify] https://crrev.com/4d1f330a1d46c31548b9d0319712daf5b0a16e1f/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h
[modify] https://crrev.com/4d1f330a1d46c31548b9d0319712daf5b0a16e1f/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/094349c40c99c45153b1c787b083cd3bde9ca96d

commit 094349c40c99c45153b1c787b083cd3bde9ca96d
Author: Ali Tofigh <alito@chromium.org>
Date: Wed Aug 02 01:55:36 2017

Chrome Cleaner UI: Add user actions for webui card.

Bug:  746987 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3397b1234aec605b93da8b8ffcddd03f121a9980
Reviewed-on: https://chromium-review.googlesource.com/588130
Commit-Queue: Ali Tofigh <alito@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491204}
[modify] https://crrev.com/094349c40c99c45153b1c787b083cd3bde9ca96d/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
[modify] https://crrev.com/094349c40c99c45153b1c787b083cd3bde9ca96d/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
[modify] https://crrev.com/094349c40c99c45153b1c787b083cd3bde9ca96d/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_proxy.js
[modify] https://crrev.com/094349c40c99c45153b1c787b083cd3bde9ca96d/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
[modify] https://crrev.com/094349c40c99c45153b1c787b083cd3bde9ca96d/chrome/browser/ui/webui/settings/chrome_cleanup_handler.h
[modify] https://crrev.com/094349c40c99c45153b1c787b083cd3bde9ca96d/chrome/test/data/webui/settings/chrome_cleanup_page_test.js
[modify] https://crrev.com/094349c40c99c45153b1c787b083cd3bde9ca96d/tools/metrics/actions/actions.xml

Comment 4 by alito@chromium.org, Aug 8 2017

Labels: Merge-Request-61
I would like to merge the last two CLs above to M61. They add UMA user actions and some UMA histograms. No other functional changes. The CLs are:

https://chromium-review.googlesource.com/585489
https://chromium-review.googlesource.com/588130


We would like to have these UMA metrics for the launch of the Chrome Cleaner UI feature which we are planning to launch in M61 (http://crbug.com/689165).
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 8 2017

Labels: -Merge-Request-61 Hotlist-Merge-Reject Merge-Reject-61
The bug is marked as P3 or Feature. It should not be merged as M61 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by gov...@chromium.org, Aug 10 2017

Cc: abdulsyed@chromium.org
Labels: -Merge-Reject-61 Merge-Approved-61
Approving merge to M61 for CL  https://chromium-review.googlesource.com/585489. Please merge ASAP per email thread with alito@ & abdulsyed@.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 11 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a71089e63a4796393cf9eb582b9f27415d4389b

commit 6a71089e63a4796393cf9eb582b9f27415d4389b
Author: Ali Tofigh <alito@chromium.org>
Date: Fri Aug 11 01:43:52 2017

[Merge to M61] Chrome Cleaner UI: Add more metrics and user actions.

TBR=alito@chromium.org

(cherry picked from commit f791370f6d69b066f1fa17bc6ebd9d79c9d6c0dc)

Bug:  746987 
Change-Id: I9733b2bb13e6999adc228118dc0a39a72f6bd6eb
Reviewed-on: https://chromium-review.googlesource.com/585489
Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Ali Tofigh <alito@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489651}
Reviewed-on: https://chromium-review.googlesource.com/611569
Reviewed-by: Ali Tofigh <alito@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#482}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/6a71089e63a4796393cf9eb582b9f27415d4389b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.cc
[modify] https://crrev.com/6a71089e63a4796393cf9eb582b9f27415d4389b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc
[modify] https://crrev.com/6a71089e63a4796393cf9eb582b9f27415d4389b/tools/metrics/actions/actions.xml

Comment 8 by alito@chromium.org, Aug 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment