New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746981 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

authpolicy: Revisit policy grouping

Project Member Reported by ljusten@chromium.org, Jul 20 2017

Issue description

Write a script that suffles policy templates around and updates grouping according to this doc:

https://docs.google.com/a/google.com/document/d/1avMSzox18LgDBt7Ordhe02jIeAy8B8xYTGSU6_O2_xM/edit?usp=sharing
 
Owner: rsorokin@chromium.org
Templates are here: https://cs.chromium.org/chromium/src/components/policy/resources/policy_templates.json
Status: Started (was: Assigned)
Cc: dskaram@chromium.org
David, could we create a list of new groups with "name, caption, desc" defined?
Labels: Pri-3
Labels: M-64 Pri-1
Labels: -M-62
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57b79efc499f90d8a930452415bf663eff9134cf

commit 57b79efc499f90d8a930452415bf663eff9134cf
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Tue Oct 24 10:53:14 2017

Change group format for 'policy_definitions' in policy_templates.json

PTAL at https://docs.google.com/a/google.com/document/d/134Pk1C1foTHtBSos_JsqWf3L6oMgsndE3_hIQNl7Yw8/edit?usp=sharing

* Policy definitions in 'policies' tag inside group definitions are replaced with policy names.
* Policy definitions are moved out of groups.
* Indentation for multiple string literals in policy_temaplates.json is not chagnes.
Changing it would change grit hashes for those strings and grit would not be able to find
translations for the strings.


Bug: 746981
Change-Id: I29e9ccae054c43603770d72483b57249529bfbf3
Reviewed-on: https://chromium-review.googlesource.com/657402
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511082}
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/components/policy/resources/PRESUBMIT.py
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/components/policy/resources/policy_templates.json
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/components/policy/tools/generate_policy_source.py
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/components/policy/tools/syntax_check_policy_template_json.py
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/components/policy/tools/template_writers/policy_template_generator.py
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/components/policy/tools/template_writers/policy_template_generator_unittest.py
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/components/policy/tools/template_writers/writers/adm_writer_unittest.py
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/components/policy/tools/template_writers/writers/json_writer_unittest.py
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/components/policy/tools/template_writers/writers/plist_strings_writer_unittest.py
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/components/policy/tools/template_writers/writers/plist_writer_unittest.py
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/components/policy/tools/template_writers/writers/reg_writer_unittest.py
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/tools/grit/grit/gather/policy_json.py
[modify] https://crrev.com/57b79efc499f90d8a930452415bf663eff9134cf/tools/grit/grit/gather/policy_json_unittest.py

Labels: -M-64 M-65
Labels: -M-65 M-67
Labels: -Pri-1 -M-67 M-69 Pri-2
Cc: olsen@chromium.org
Labels: -M-69
Status: Assigned (was: Started)

Sign in to add a comment