Right now there is no tracing data for ui elements that don't work in VR. Chrome must track suppression of UI elements in VR using UMA.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/056aefbfce2c0509fc4dce7f7ff68e9a2dfc15bd commit 056aefbfce2c0509fc4dce7f7ff68e9a2dfc15bd Author: Amirhossein Simjour <asimjour@chromium.org> Date: Fri Jul 21 21:40:26 2017 Track suppression of UI elements in VR using UMA Add tracking of suppression of the popup ui elements in tab_web_contents_delegate_android. The logging should be removed once we have proper implementation of UI elements in VR. BUG= 746979 Change-Id: I75997b9aa644b75e4b673f5ca34335138003f3bd Reviewed-on: https://chromium-review.googlesource.com/579947 Reviewed-by: Ian Vollick <vollick@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#488761} [modify] https://crrev.com/056aefbfce2c0509fc4dce7f7ff68e9a2dfc15bd/chrome/browser/BUILD.gn [modify] https://crrev.com/056aefbfce2c0509fc4dce7f7ff68e9a2dfc15bd/chrome/browser/android/tab_web_contents_delegate_android.cc [modify] https://crrev.com/056aefbfce2c0509fc4dce7f7ff68e9a2dfc15bd/chrome/browser/android/vr_shell/vr_metrics_util.cc [modify] https://crrev.com/056aefbfce2c0509fc4dce7f7ff68e9a2dfc15bd/chrome/browser/android/vr_shell/vr_metrics_util.h [add] https://crrev.com/056aefbfce2c0509fc4dce7f7ff68e9a2dfc15bd/chrome/browser/vr/ui_suppressed_element.h [modify] https://crrev.com/056aefbfce2c0509fc4dce7f7ff68e9a2dfc15bd/chrome/browser/vr/vr_tab_helper.cc [modify] https://crrev.com/056aefbfce2c0509fc4dce7f7ff68e9a2dfc15bd/chrome/browser/vr/vr_tab_helper.h [modify] https://crrev.com/056aefbfce2c0509fc4dce7f7ff68e9a2dfc15bd/tools/metrics/histograms/enums.xml [modify] https://crrev.com/056aefbfce2c0509fc4dce7f7ff68e9a2dfc15bd/tools/metrics/histograms/histograms.xml
Amir, out of curiosity, how much work will it be to track all of the suppressions? Are we still planning to track them all?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b2fba7109d614fee842433f517572621dc6617b commit 0b2fba7109d614fee842433f517572621dc6617b Author: Amirhossein Simjour <asimjour@chromium.org> Date: Thu Aug 17 13:39:13 2017 Track suppression of permission UI in VR using UMA The logs should be removed once we have proper implementation of UI elements in VR. BUG= 746979 Change-Id: I5deb08fd30db899186f33aeb445faca2a96261d4 Reviewed-on: https://chromium-review.googlesource.com/594367 Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#495160} [modify] https://crrev.com/0b2fba7109d614fee842433f517572621dc6617b/chrome/browser/permissions/permission_manager.cc [modify] https://crrev.com/0b2fba7109d614fee842433f517572621dc6617b/chrome/browser/vr/ui_suppressed_element.h [modify] https://crrev.com/0b2fba7109d614fee842433f517572621dc6617b/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/381eaf61d5c0007186ebedc40440916d2d620b60 commit 381eaf61d5c0007186ebedc40440916d2d620b60 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Thu Aug 17 19:09:44 2017 Track suppression of qouta permission UI in VR This should be removed once we have proper implementation of UI elements in VR. BUG= 746979 Change-Id: Idaa917253c083e52c290c7aa11edba56c902c621 Reviewed-on: https://chromium-review.googlesource.com/619287 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#495268} [modify] https://crrev.com/381eaf61d5c0007186ebedc40440916d2d620b60/chrome/browser/chrome_quota_permission_context.cc [modify] https://crrev.com/381eaf61d5c0007186ebedc40440916d2d620b60/chrome/browser/vr/ui_suppressed_element.h [modify] https://crrev.com/381eaf61d5c0007186ebedc40440916d2d620b60/tools/metrics/histograms/enums.xml
We are going to track all of the ui elements that are using IsInVr flag for suppression. A few more patches will be coming soon
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd5e3862a46f6b9c761302a7e275c1af6173ad9e commit bd5e3862a46f6b9c761302a7e275c1af6173ad9e Author: Amirhossein Simjour <asimjour@chromium.org> Date: Mon Aug 21 15:32:12 2017 Track suppression of http authentication UI in VR This should be removed once we have proper implementation of UI elements in VR. BUG= 746979 Change-Id: I2b4b50ef740bb02c57001e23e029b4f02ac91984 Reviewed-on: https://chromium-review.googlesource.com/621187 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#495941} [modify] https://crrev.com/bd5e3862a46f6b9c761302a7e275c1af6173ad9e/chrome/browser/ui/android/login_handler_android.cc [modify] https://crrev.com/bd5e3862a46f6b9c761302a7e275c1af6173ad9e/chrome/browser/vr/ui_suppressed_element.h [modify] https://crrev.com/bd5e3862a46f6b9c761302a7e275c1af6173ad9e/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39cda4e6c1451a4cb22c614e6405147c8e1abed6 commit 39cda4e6c1451a4cb22c614e6405147c8e1abed6 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Wed Aug 23 18:49:10 2017 Track suppression of download UI in VR This should be removed once we have proper implementation of UI elements in VR. BUG= 746979 Change-Id: Ic3418855e1169f4ff2e7deb48f79db6aea73044d Reviewed-on: https://chromium-review.googlesource.com/626476 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#496744} [modify] https://crrev.com/39cda4e6c1451a4cb22c614e6405147c8e1abed6/chrome/browser/android/download/download_controller.cc [modify] https://crrev.com/39cda4e6c1451a4cb22c614e6405147c8e1abed6/chrome/browser/download/download_request_limiter.cc [modify] https://crrev.com/39cda4e6c1451a4cb22c614e6405147c8e1abed6/chrome/browser/vr/ui_suppressed_element.h [modify] https://crrev.com/39cda4e6c1451a4cb22c614e6405147c8e1abed6/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71ccdfc530ef2f93c88fb580f4f8b9e1840279ce commit 71ccdfc530ef2f93c88fb580f4f8b9e1840279ce Author: Amirhossein Simjour <asimjour@chromium.org> Date: Tue Aug 29 19:21:22 2017 Track suppression of password manager client in VR Password manager should be enabled in VR again once VR has the proper implementation for UI elements. BUG= 746979 Change-Id: Ied69f3c9ae2142b0b858802b2fff7e5576d02347 Reviewed-on: https://chromium-review.googlesource.com/639470 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#498193} [modify] https://crrev.com/71ccdfc530ef2f93c88fb580f4f8b9e1840279ce/chrome/browser/password_manager/chrome_password_manager_client.cc [modify] https://crrev.com/71ccdfc530ef2f93c88fb580f4f8b9e1840279ce/chrome/browser/vr/ui_suppressed_element.h [modify] https://crrev.com/71ccdfc530ef2f93c88fb580f4f8b9e1840279ce/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e867d2123e0f46c5263cdb6a708b9af538ef575 commit 2e867d2123e0f46c5263cdb6a708b9af538ef575 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Wed Aug 30 14:39:10 2017 Track suppression of autofill in VR Autofill should be enabled in VR again once VR has the proper implementation for UI elements. BUG= 746979 Change-Id: I7602b097d349742b165a738a4f36c3a369dae68a Reviewed-on: https://chromium-review.googlesource.com/641936 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#498457} [modify] https://crrev.com/2e867d2123e0f46c5263cdb6a708b9af538ef575/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/2e867d2123e0f46c5263cdb6a708b9af538ef575/chrome/browser/vr/ui_suppressed_element.h [modify] https://crrev.com/2e867d2123e0f46c5263cdb6a708b9af538ef575/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2f64f7cd51b1e4f27e4ddd94ae55a4521049ed0 commit a2f64f7cd51b1e4f27e4ddd94ae55a4521049ed0 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Wed Sep 06 20:08:53 2017 Track suppression of USB chooser and SSL certificate dialog in VR This should be removed once we have proper implementation of USB chooser dialog and SSL client certificate selector in VR. BUG= 746979 Change-Id: I3208f2e5e9a3cfaf0f4d00fce48546d627aa2990 Reviewed-on: https://chromium-review.googlesource.com/646081 Reviewed-by: Jun Cai <juncai@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#500057} [modify] https://crrev.com/a2f64f7cd51b1e4f27e4ddd94ae55a4521049ed0/chrome/browser/ui/android/ssl_client_certificate_request.cc [modify] https://crrev.com/a2f64f7cd51b1e4f27e4ddd94ae55a4521049ed0/chrome/browser/ui/android/usb_chooser_dialog_android.cc [modify] https://crrev.com/a2f64f7cd51b1e4f27e4ddd94ae55a4521049ed0/chrome/browser/vr/ui_suppressed_element.h [modify] https://crrev.com/a2f64f7cd51b1e4f27e4ddd94ae55a4521049ed0/tools/metrics/histograms/enums.xml
Comment 1 by bugdroid1@chromium.org
, Jul 21 2017