New issue
Advanced search Search tips

Issue 746958 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue v8:6811

Blocking:
issue 746956
issue 752428



Sign in to add a comment

Try to use jumbo in v8

Project Member Reported by brat...@opera.com, Jul 20 2017

Issue description

v8 needs roughly 60 CPU minutes to compile and is therefore a good candidate for jumbo compiling which usually reduces the compilation time by 80-95%.

There are a few complications with it living in a different repo than the jumbo scripts and I haven't even tried it so I don't know how much work it is, nor what effect it will have.
 

Comment 1 by most...@opera.com, Jul 20 2017

Status: Started (was: Assigned)

Comment 2 by most...@opera.com, Jul 20 2017

Starting with the non-controversial parts:
https://chromium-review.googlesource.com/c/579090/

Comment 3 by most...@opera.com, Aug 4 2017

Blocking: 752428
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2ddca9c26083d117199f96a3654af20a096bdffd

commit 2ddca9c26083d117199f96a3654af20a096bdffd
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Wed Aug 09 09:05:29 2017

add gn jumbo build support

To speed up compilation times, jumbo allows files to be compiled
together. This is a well known method ("unity builds") to both
compile faster and create a poor man's "full program optimization".
We are only interested in compile times.

Background:
https://chromium.googlesource.com/chromium/src/+/master/docs/jumbo.md

Note that jumbo builds are not enabled by default.  To try this out,
add use_jumbo_build=true to your GN args.

BUG= chromium:746958 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ieb9fdccb6c135e9806dbed91c09a29aa8b8bee11
Reviewed-on: https://chromium-review.googlesource.com/579090
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47239}
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/BUILD.gn
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/gni/v8.gni
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/api-arguments-inl.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/asmjs/asm-parser.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/base/platform/platform-posix-time.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/builtins/builtins-arguments-gen.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/builtins/builtins-forin-gen.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/builtins/builtins-iterator-gen.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/common-operator.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/control-equivalence.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/escape-analysis.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/js-inlining.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/js-native-context-specialization.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/js-operator.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/jump-threading.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/live-range-separator.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/load-elimination.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/loop-analysis.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/loop-variable-optimizer.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/machine-operator.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/new-escape-analysis-reducer.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/new-escape-analysis.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/new-escape-analysis.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/osr.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/property-access-builder.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/property-access-builder.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/register-allocator.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/scheduler.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/simd-scalar-lowering.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/simplified-lowering.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/simplified-operator.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/compiler/type-cache.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/heap/array-buffer-tracker-inl.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/heap/code-stats.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/heap/local-allocator.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/heap/spaces.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/heap/store-buffer.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/inspector/v8-debugger-agent-impl.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/inspector/v8-debugger.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/inspector/wasm-translation.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/interpreter/interpreter-intrinsics-generator.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/lookup-cache-inl.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/parsing/expression-scope-reparenter.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/setup-isolate.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/function-body-decoder.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/local-decl-encoder.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/module-compiler.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/module-decoder.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/streaming-decoder.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/wasm-code-specialization.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/wasm-code-specialization.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/wasm-debug.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/wasm-interpreter.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/wasm-module.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/wasm-module.h
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/wasm-objects.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/src/wasm/wasm-text.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/test/fuzzer/wasm-async.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/test/fuzzer/wasm-call.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/test/fuzzer/wasm-code.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/test/fuzzer/wasm-compile.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/test/fuzzer/wasm-data-section.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/test/fuzzer/wasm-function-sigs-section.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/test/fuzzer/wasm-fuzzer-common.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/test/fuzzer/wasm-globals-section.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/test/fuzzer/wasm-imports-section.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/test/fuzzer/wasm-memory-section.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/test/fuzzer/wasm-names-section.cc
[modify] https://crrev.com/2ddca9c26083d117199f96a3654af20a096bdffd/test/fuzzer/wasm-types-section.cc

Comment 5 by most...@opera.com, Aug 9 2017

Status: Fixed (was: Started)
This has landed and should hopefully be usable now.  I will try to spot breakage and submit fixes as required.

Followup for the jumbo-excluded files in https://crbug.com/752428

Comment 6 by most...@opera.com, Aug 9 2017

Status: Started (was: Fixed)

Comment 7 by most...@opera.com, Aug 10 2017

Started work on test targets: https://chromium-review.googlesource.com/c/610962
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/cddbe282c60a6522bf18b0c71709c7bca5eb8be4

commit cddbe282c60a6522bf18b0c71709c7bca5eb8be4
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Mon Aug 14 20:58:10 2017

Start preparing test/cctest for jumbo compilation

* Avoid "using namespace" statements, which trigger clang's -Wheader-hygiene
  warnings in jumbo builds.
* Undefine created macros at the end of source files.

BUG= chromium:746958 

Change-Id: I5d25432c314437f607b0e1be22765a6764267ba6
Reviewed-on: https://chromium-review.googlesource.com/610962
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#47347}
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/compiler/test-node.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/compiler/test-operator.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/compiler/test-run-load-store.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/compiler/test-run-machops.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/compiler/test-run-wasm-machops.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/heap/test-alloc.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/heap/test-mark-compact.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/parsing/test-parse-decision.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/parsing/test-scanner.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-api.h
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-assembler-x64.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-ast.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-bignum-dtoa.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-bignum.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-bit-vector.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-code-layout.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-compiler.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-constantpool.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-conversions.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-date.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-decls.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-dictionary.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-disasm-x64.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-diy-fp.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-double.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-dtoa.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-elements-kind.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-fast-dtoa.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-feedback-vector.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-field-type-tracking.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-fixed-dtoa.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-flags.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-global-handles.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-list.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-liveedit.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-log-stack-tracer.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-managed.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-mementos.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-object.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-orderedhashtable.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-platform-linux.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-random-number-generator.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-regexp.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-representation.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-run-wasm-relocation-x64.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-strings.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-strtod.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-symbols.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-trace-event.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-transitions.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-typedarrays.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-types.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-utils.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-version.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-weakmaps.cc
[modify] https://crrev.com/cddbe282c60a6522bf18b0c71709c7bca5eb8be4/test/cctest/test-weaksets.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c58460b25f69acb2250d1d34af022de8b6c76bd6

commit c58460b25f69acb2250d1d34af022de8b6c76bd6
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Wed Aug 30 08:23:28 2017

jumbo: build some slow-to-compile sources separately

Daniel Bratell reports:
> v8 had a couple of files that were very slow to compile before jumbo
> and if those now end up in the same translation unit, then I can see
> how that translation unit can take an extreme time to get through
> the compiler.
>
> From one of my test builds (times in seconds):
> 49.7 v8_base/objects.o
> 44.0 v8_base/code-stub-assembler.o
> 32.9 v8_base/api.o
> 30.5 v8_base/elements.o
> 25.9 v8_builtins_generators/builtins-regexp-gen.o
> 22.8 v8_base/parser.o
> 21.2 v8_base/heap.o
>
> All of these are in the slowest 0.1% ninja jobs so they are extreme
> in some way. I think I would just exclude them all (or at least the
> 30s+ ones) completely from jumbo.

BUG= chromium:746958 

Change-Id: I01741109def4f9ac7c946319374076eb7b9d03b6
Reviewed-on: https://chromium-review.googlesource.com/637971
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47703}
[modify] https://crrev.com/c58460b25f69acb2250d1d34af022de8b6c76bd6/BUILD.gn

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/510421d8767fda57c7cf7477a19f93b35441ad29

commit 510421d8767fda57c7cf7477a19f93b35441ad29
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Aug 31 13:05:58 2017

[wasm] Remove all 'using namespace' declarations

They violate the style guide, and cause problems for jumbo builds.
This CL removes all occurrences in src/wasm except for the file
wasm-objects.cc, which is a bit more involved and will be fixed in a
separate CL.

R=titzer@chromium.org
CC=mostynb@opera.com

Bug:  chromium:746958 
Change-Id: If5d9c03e0d6fa364e1d21feda49773468a48fba6
Reviewed-on: https://chromium-review.googlesource.com/645707
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Ben Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47743}
[modify] https://crrev.com/510421d8767fda57c7cf7477a19f93b35441ad29/src/base/logging.h
[modify] https://crrev.com/510421d8767fda57c7cf7477a19f93b35441ad29/src/wasm/local-decl-encoder.cc
[modify] https://crrev.com/510421d8767fda57c7cf7477a19f93b35441ad29/src/wasm/streaming-decoder.cc
[modify] https://crrev.com/510421d8767fda57c7cf7477a19f93b35441ad29/src/wasm/wasm-code-specialization.cc
[modify] https://crrev.com/510421d8767fda57c7cf7477a19f93b35441ad29/src/wasm/wasm-debug.cc
[modify] https://crrev.com/510421d8767fda57c7cf7477a19f93b35441ad29/src/wasm/wasm-module.cc
[modify] https://crrev.com/510421d8767fda57c7cf7477a19f93b35441ad29/src/wasm/wasm-text.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4c19fa447f53b856f2f4cfd7e75937df95e08493

commit 4c19fa447f53b856f2f4cfd7e75937df95e08493
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Aug 31 13:18:24 2017

[wasm] Remove 'using namespace' from wasm-objects.cc

This violated the style guide, and caused problems for jumbo builds.

R=titzer@chromium.org
CC=mostynb@opera.com

Bug:  chromium:746958 
Change-Id: Iaa75d444f5b5f595c54058de14b394119390921c
Reviewed-on: https://chromium-review.googlesource.com/645529
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Ben Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47744}
[modify] https://crrev.com/4c19fa447f53b856f2f4cfd7e75937df95e08493/src/wasm/wasm-objects.cc
[modify] https://crrev.com/4c19fa447f53b856f2f4cfd7e75937df95e08493/src/wasm/wasm-objects.h

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/57375079cddff61a4ad742707526d881f3719bbd

commit 57375079cddff61a4ad742707526d881f3719bbd
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Fri Sep 01 13:49:24 2017

[wasm] Remove 'using namespace' from cctest/wasm

This required splitting wasm-run-utils.h in header and implementation,
since the anonymous namespace in wasm-run-utils.h is now gone.
This is a reasonable refactoring in itself.

R=titzer@chromium.org
CC=mstarzinger@chromium.org, mostynb@opera.com

Bug:  chromium:746958 
Change-Id: I0f3b30fef1865cd88eca37b69d0c3a9eb19e77ea
Reviewed-on: https://chromium-review.googlesource.com/647587
Reviewed-by: Ben Titzer <titzer@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47773}
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/BUILD.gn
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/cctest.gyp
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/compiler/value-helper.h
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/test-run-wasm-relocation-arm.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/test-run-wasm-relocation-arm64.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/test-run-wasm-relocation-ia32.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-run-wasm-64.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-run-wasm-asmjs.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-run-wasm-atomics.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-run-wasm-interpreter.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-run-wasm-js.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-run-wasm-module.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-run-wasm-relocation.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-run-wasm-simd.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-run-wasm.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-wasm-breakpoints.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-wasm-interpreter-entry.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-wasm-stack.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/test-wasm-trap-position.cc
[add] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/wasm-run-utils.cc
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/cctest/wasm/wasm-run-utils.h
[modify] https://crrev.com/57375079cddff61a4ad742707526d881f3719bbd/test/unittests/wasm/function-body-decoder-unittest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 1 2017

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7e5f5057c50f78dcd7c6b1062ceda7de0becd69d

commit 7e5f5057c50f78dcd7c6b1062ceda7de0becd69d
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Mon Sep 04 08:28:28 2017

jumbo: utils-arm64.cc: undef __

Bug:  chromium:746958 
Change-Id: I5df144055d1918bf26acba648e07646150249d94
Reviewed-on: https://chromium-review.googlesource.com/647549
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#47782}
[modify] https://crrev.com/7e5f5057c50f78dcd7c6b1062ceda7de0becd69d/src/arm64/utils-arm64.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1c1457fa70d6201293f6c1d4eeea3bc7c37042ee

commit 1c1457fa70d6201293f6c1d4eeea3bc7c37042ee
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Mon Sep 04 15:20:39 2017

[jumbo] Add missing undefs

R=mstarzinger@chromium.org

Bug:  chromium:746958 
Change-Id: Id0afb27e88944a64bf301533fa164668294f8446
Reviewed-on: https://chromium-review.googlesource.com/648978
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47802}
[modify] https://crrev.com/1c1457fa70d6201293f6c1d4eeea3bc7c37042ee/src/compiler/store-store-elimination.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/07660a1cf8bea000cd3012b6f5d6e7600ea0a08e

commit 07660a1cf8bea000cd3012b6f5d6e7600ea0a08e
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Tue Sep 05 16:12:59 2017

jumbo: avoid arm64 macro redefinition errors

Bug:  chromium:746958 
Change-Id: I4e23608995952efd0f0bd73d9bf4f9a3fc84d478
Reviewed-on: https://chromium-review.googlesource.com/650256
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#47825}
[modify] https://crrev.com/07660a1cf8bea000cd3012b6f5d6e7600ea0a08e/src/arm64/assembler-arm64.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b91b8def423f65c99a0a6318f0f1de4213cc9460

commit b91b8def423f65c99a0a6318f0f1de4213cc9460
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Wed Sep 06 19:23:58 2017

[jumbo] #undef TRACE at the end of source files

This macro is defined all over the place, and often causes macro
redefinition errors in jumbo builds.  Let's make sure all such
instances created in source files are #undef'ed.

Candidate files found with:
  grep -wL '#undef TRACE' $(git grep -wl '#define TRACE' -- '*.cc')

While we're at it, let's undef all macros defined in these files.

Bug:  chromium:746958 
Change-Id: I639ca2b141f908457d1b2601cd6d5827dee0ead0
Reviewed-on: https://chromium-review.googlesource.com/652476
Reviewed-by: Mircea Trofin <mtrofin@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#47859}
[modify] https://crrev.com/b91b8def423f65c99a0a6318f0f1de4213cc9460/src/compiler/js-inlining-heuristic.cc
[modify] https://crrev.com/b91b8def423f65c99a0a6318f0f1de4213cc9460/src/compiler/mips/instruction-selector-mips.cc
[modify] https://crrev.com/b91b8def423f65c99a0a6318f0f1de4213cc9460/src/compiler/mips64/instruction-selector-mips64.cc
[modify] https://crrev.com/b91b8def423f65c99a0a6318f0f1de4213cc9460/src/wasm/wasm-module.cc
[modify] https://crrev.com/b91b8def423f65c99a0a6318f0f1de4213cc9460/src/wasm/wasm-objects.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7d890c1135c0f036950cddccd3483ec17cb8aeb4

commit 7d890c1135c0f036950cddccd3483ec17cb8aeb4
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Thu Sep 07 07:35:19 2017

[jumbo] undef FORWARD_DECLARE after creating it in source files

Followup after https://chromium-review.googlesource.com/c/v8/v8/+/652427
which triggered FORWARD_DECLARE macro redefinition warnings/errors.  Let's
make sure to undef this macro at the end of source files that create it.

Bug:  chromium:746958 
Change-Id: Ie70743c836db45eb51f412a0d6359f0f667319d3
Reviewed-on: https://chromium-review.googlesource.com/654657
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47866}
[modify] https://crrev.com/7d890c1135c0f036950cddccd3483ec17cb8aeb4/src/builtins/builtins.cc
[modify] https://crrev.com/7d890c1135c0f036950cddccd3483ec17cb8aeb4/src/builtins/setup-builtins-internal.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e98edd16fd722acdeac451832de8b6fed39e62df

commit e98edd16fd722acdeac451832de8b6fed39e62df
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Thu Sep 07 16:31:11 2017

[jumbo] avoid fixed-dtoa.cc conflicts with base/macros.h's RoundUp

Bug:  chromium:746958 
Change-Id: I18593669e8a8bb622b575258441d4933ad98ec3e
Reviewed-on: https://chromium-review.googlesource.com/654871
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#47894}
[modify] https://crrev.com/e98edd16fd722acdeac451832de8b6fed39e62df/src/fixed-dtoa.cc

Blockedon: v8:6811
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5af9ec2cca04ac284a98b4d1d0b229148672b6b3

commit 5af9ec2cca04ac284a98b4d1d0b229148672b6b3
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Tue Sep 12 13:09:07 2017

[jumbo] avoid MAP_TYPE system header symbol clashes

Linux builds have an include chain from src/perf-jit.cc:
sys/mman.h -> bits/mman.h -> bits/mman-linux.h, which defines
a MAP_TYPE macro that conflicts with InstanceType::MAP_TYPE
in jumbo builds, for some jumbo_file_merge_limit values.

Since MAP_TYPE isn't used in perf-jit.cc, it should be safe
to #undef the macro immediately after the sys/mman.h #include
statement.

Bug:  chromium:746958 
Change-Id: I1339a4f56cf6783bf6121cd44c93e776af9458ba
Reviewed-on: https://chromium-review.googlesource.com/654042
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#47971}
[modify] https://crrev.com/5af9ec2cca04ac284a98b4d1d0b229148672b6b3/src/perf-jit.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/da3ccc49e78c4f71859755c102c5f0f367f8e697

commit da3ccc49e78c4f71859755c102c5f0f367f8e697
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Wed Sep 13 06:56:29 2017

[jumbo] last few changes for enabling more jumbo_file_merge_limit values

* Inline src/runtime/runtime-typedarray.cc's TypedArrayCopyElements to
  avoid clash with src/builtins/builtins-typedarray.cc
* #undef V after its last use in src/asmjs/asm-scanner.cc
* Convince clang that it's ok that frame_content_ is never used in
  src/deoptimizer.h

Bug:  chromium:746958 
Change-Id: Ibef589b66384d982a8463c3f05b9db9c4fd92ce0
Reviewed-on: https://chromium-review.googlesource.com/663858
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#47986}
[modify] https://crrev.com/da3ccc49e78c4f71859755c102c5f0f367f8e697/src/asmjs/asm-scanner.cc
[modify] https://crrev.com/da3ccc49e78c4f71859755c102c5f0f367f8e697/src/deoptimizer.h
[modify] https://crrev.com/da3ccc49e78c4f71859755c102c5f0f367f8e697/src/runtime/runtime-typedarray.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/46000a12449f09042be60e87dfc76044aec3ad92

commit 46000a12449f09042be60e87dfc76044aec3ad92
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Wed Sep 13 22:12:16 2017

[jumbo] fix arm64 builds

Previously instructions-arm64.h was alternatively defining or declaring
some constants based on whether or not ARM64_DEFINE_FP_STATICS was defined,
and it was assumed that exactly one file would include this header with
the macro defined.

In jumbo builds, the header guards in instructions-arm64.h meant that the
resulting state of the header file would be whichever of the two cases
that appeared first in the compilation unit.  This would cause multiple
definitions in some cases and no definitions in some other cases (or if
you were really lucky, it would work out ok).

Let's move these constants to a separate source file temporarily, to be
excluded from jumbo compilation units.  This code should eventually be
replaced with a cleaner solution.

Bug:  chromium:746958 
Change-Id: I7edb1821ef408afd50c6b236d63d3c07f955b58f
Reviewed-on: https://chromium-review.googlesource.com/663898
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48003}
[modify] https://crrev.com/46000a12449f09042be60e87dfc76044aec3ad92/BUILD.gn
[add] https://crrev.com/46000a12449f09042be60e87dfc76044aec3ad92/src/arm64/instructions-arm64-constants.cc
[modify] https://crrev.com/46000a12449f09042be60e87dfc76044aec3ad92/src/arm64/instructions-arm64.cc
[modify] https://crrev.com/46000a12449f09042be60e87dfc76044aec3ad92/src/arm64/instructions-arm64.h
[modify] https://crrev.com/46000a12449f09042be60e87dfc76044aec3ad92/src/v8.gyp

Project Member

Comment 24 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55

commit 01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Thu Sep 21 08:46:16 2017

[jumbo] add test namespaces for cctest

By adding a per test source file namespace, we can avoid a lot of
symbol collisions in jumbo builds.

While we're at it, let's remove some "using" statements that also
cause trouble.

Bug:  chromium:746958 
Change-Id: I6f8a723e1ba5905888638e0687b23193f3f012ca
Reviewed-on: https://chromium-review.googlesource.com/676803
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#48102}
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/compiler/test-run-native-calls.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/heap/test-spaces.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-bignum-dtoa.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-bignum.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-code-stubs-x64.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-dtoa.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-elements-kind.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-fast-dtoa.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-field-type-tracking.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-inobject-slack-tracking.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-lockers.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-macro-assembler-x64.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-orderedhashtable.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-parsing.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-profile-generator.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-regexp.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-strings.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-strtod.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-unboxed-doubles.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-usecounters.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-weakmaps.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/test-weaksets.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/wasm/test-run-wasm-64.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/wasm/test-run-wasm-interpreter.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/wasm/test-run-wasm-relocation.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/wasm/test-run-wasm-simd.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/wasm/test-run-wasm.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/wasm/test-wasm-stack.cc
[modify] https://crrev.com/01946db5e0f5f3bf28a73e9731ad7bf3b40d8a55/test/cctest/wasm/test-wasm-trap-position.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2857dab5cbc35cd50e84fe09c4251e18fa19d6d2

commit 2857dab5cbc35cd50e84fe09c4251e18fa19d6d2
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Thu Sep 21 12:19:10 2017

[jumbo] add some missing cctest header guards

Bug:  chromium:746958 
Change-Id: I0c1dfe1019b5324d322f5c7a6a2e6095c18f0b40
Reviewed-on: https://chromium-review.googlesource.com/676583
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#48106}
[modify] https://crrev.com/2857dab5cbc35cd50e84fe09c4251e18fa19d6d2/test/cctest/compiler/code-assembler-tester.h
[modify] https://crrev.com/2857dab5cbc35cd50e84fe09c4251e18fa19d6d2/test/cctest/interpreter/interpreter-tester.h

Project Member

Comment 26 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b4ff29d8702f05e3416304c897972b8fb108a69c

commit b4ff29d8702f05e3416304c897972b8fb108a69c
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Fri Sep 22 11:15:08 2017

[jumbo] drop duplicate BUILD macro from test-run-wasm-js.cc

BUILD is already defined in test/cctest/wasm/wasm-run-utils.h.

Bug:  chromium:746958 
Change-Id: Icf577ce91424d9851d2db39658fd52c68c864995
Reviewed-on: https://chromium-review.googlesource.com/676843
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#48122}
[modify] https://crrev.com/b4ff29d8702f05e3416304c897972b8fb108a69c/test/cctest/wasm/test-run-wasm-js.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4187a62734f35a5c00b574a9dab75d1801ea9299

commit 4187a62734f35a5c00b574a9dab75d1801ea9299
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Mon Sep 25 16:37:54 2017

[jumbo] undef some more macros defined in .cc files

Bug:  chromium:746958 
Change-Id: I81ad56e3bfbdc458c3e318927191f6c5e137c448
Reviewed-on: https://chromium-review.googlesource.com/680554
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#48143}
[modify] https://crrev.com/4187a62734f35a5c00b574a9dab75d1801ea9299/test/cctest/compiler/test-run-bytecode-graph-builder.cc
[modify] https://crrev.com/4187a62734f35a5c00b574a9dab75d1801ea9299/test/cctest/interpreter/test-bytecode-generator.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/54f1f4dfc1a8ecea97f58a7aa18cab4737c7f018

commit 54f1f4dfc1a8ecea97f58a7aa18cab4737c7f018
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Mon Sep 25 16:51:38 2017

[jumbo] add test source file namespace in test-hashmap.cc

Bug:  chromium:746958 
Change-Id: Ia251d99ffe142fadb99fc83082683aa87676c47d
Reviewed-on: https://chromium-review.googlesource.com/680574
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#48145}
[modify] https://crrev.com/54f1f4dfc1a8ecea97f58a7aa18cab4737c7f018/test/cctest/test-hashmap.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/dbe9457fcb3a4875e5a29f5790444f352436db83

commit dbe9457fcb3a4875e5a29f5790444f352436db83
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Mon Sep 25 16:56:09 2017

[jumbo]: allow cctest jumbo mode builds

There is no jumbo_executable target atm, so split the cctest v8_executable
target into cctest and cctest_sources.

Bug:  chromium:746958 
Change-Id: Iec0956234d026039c4d29921170dd2f0955222ca
Reviewed-on: https://chromium-review.googlesource.com/680575
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#48147}
[modify] https://crrev.com/dbe9457fcb3a4875e5a29f5790444f352436db83/test/cctest/BUILD.gn

Project Member

Comment 30 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a32c948344167049705326c2abbcdc7cb26f2408

commit a32c948344167049705326c2abbcdc7cb26f2408
Author: Mostyn Bramley-Moore <mostynb@opera.com>
Date: Mon Sep 25 21:00:26 2017

[jumbo] also exclude test-bytecode-generator.cc from cctest jumbo builds

This caused trouble for my downstream CI tests, even though it builds
successfully in the canonical v8 tree.  To be investigated properly
later.

Bug:  chromium:746958 
Change-Id: I180a5ecc51051e4eb6617180ccba787ff80bcf45
Reviewed-on: https://chromium-review.googlesource.com/682695
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com>
Cr-Commit-Position: refs/heads/master@{#48151}
[modify] https://crrev.com/a32c948344167049705326c2abbcdc7cb26f2408/test/cctest/BUILD.gn

Comment 31 by most...@vewd.com, Sep 28 2017

Owner: most...@vewd.com
Project Member

Comment 32 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d6ead37d265d7215cf9c5f768f279e21bd170212

commit d6ead37d265d7215cf9c5f768f279e21bd170212
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Thu Sep 28 22:19:40 2017

[jumbo] add unittests jumbo support

TBR=jkummerow@chromium.org

Bug:  chromium:746958 
Change-Id: I7500b6206c4ceb087672de5b61b7e7ad234bb425
Reviewed-on: https://chromium-review.googlesource.com/690397
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48213}
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/BUILD.gn
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/api/remote-object-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/base/logging-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/base/template-utils-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/compiler/common-operator-reducer-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/compiler/common-operator-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/compiler/dead-code-elimination-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/compiler/graph-reducer-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/compiler/instruction-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/compiler/js-operator-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/compiler/node-cache-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/compiler/node-properties-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/compiler/node-test-utils.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/compiler/simplified-operator-reducer-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/compiler/typed-optimization-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/libplatform/default-platform-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/libplatform/task-queue-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/libplatform/worker-thread-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/wasm/function-body-decoder-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/wasm/module-decoder-unittest.cc
[modify] https://crrev.com/d6ead37d265d7215cf9c5f768f279e21bd170212/test/unittests/wasm/wasm-heap-unittest.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Sep 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/37305e918ffda3b492cab6e57d78887ae4f7bba0

commit 37305e918ffda3b492cab6e57d78887ae4f7bba0
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Sat Sep 30 17:17:23 2017

[jumbo] arm64 cctest fixes

Remove more "using" statements.

Bug:  chromium:746958 
Change-Id: I2f9c45b1ff1d51fc58b7a702fee046ba3c6a7c17
Reviewed-on: https://chromium-review.googlesource.com/693862
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#48248}
[modify] https://crrev.com/37305e918ffda3b492cab6e57d78887ae4f7bba0/test/cctest/test-cpu-profiler.cc
[modify] https://crrev.com/37305e918ffda3b492cab6e57d78887ae4f7bba0/test/cctest/test-javascript-arm64.cc
[modify] https://crrev.com/37305e918ffda3b492cab6e57d78887ae4f7bba0/test/cctest/test-js-arm64-variables.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/de65d40211478c65a3e912097b73d633d798405a

commit de65d40211478c65a3e912097b73d633d798405a
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Thu Nov 09 08:51:35 2017

[jumbo] undef more instances of __ after use

Bug:  chromium:746958 
Change-Id: I38e19678e57e5769f4eb19b588ab1de1f4c3bb11
Reviewed-on: https://chromium-review.googlesource.com/758777
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#49252}
[modify] https://crrev.com/de65d40211478c65a3e912097b73d633d798405a/src/debug/arm64/debug-arm64.cc
[modify] https://crrev.com/de65d40211478c65a3e912097b73d633d798405a/src/regexp/arm64/regexp-macro-assembler-arm64.cc
[modify] https://crrev.com/de65d40211478c65a3e912097b73d633d798405a/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/de65d40211478c65a3e912097b73d633d798405a/test/cctest/test-utils-arm64.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b9c99322020b5da77609886f04b1799a7421b8cb

commit b9c99322020b5da77609886f04b1799a7421b8cb
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Thu Nov 09 09:33:45 2017

[jumbo] fix B macro/symbol clashes in arm64 builds

assembler-arm64.h and assembler-arm64-inl.h have a B() function
which conflicts with the B macro in bytecode-utils.h.

Headers that leak macros can be annoying to deal with, in this case
we can't simply undef B at the end of source files that include
bytecode-utils.h because the second source file that includes
bytecode-utils.h won't see the B macro.  Let's just move this macro
into the two unittest files that include this header.

Bug:  chromium:746958 
Change-Id: I588b73fe81615f882a0e010c92ba187d3bc2bf25
Reviewed-on: https://chromium-review.googlesource.com/758779
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49258}
[modify] https://crrev.com/b9c99322020b5da77609886f04b1799a7421b8cb/test/unittests/interpreter/bytecode-array-writer-unittest.cc
[modify] https://crrev.com/b9c99322020b5da77609886f04b1799a7421b8cb/test/unittests/interpreter/bytecode-decoder-unittest.cc
[modify] https://crrev.com/b9c99322020b5da77609886f04b1799a7421b8cb/test/unittests/interpreter/bytecode-utils.h

Comment 36 by most...@vewd.com, Jan 16 2018

Status: Fixed (was: Started)
Project Member

Comment 37 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75f56fea24f7c049e76f44751d58f1a33be3e6f2

commit 75f56fea24f7c049e76f44751d58f1a33be3e6f2
Author: Daniel Bratell <bratell@opera.com>
Date: Mon Jan 22 17:11:34 2018

Gave two kUrlKey variables unique names

In jumbo builds, two kUrlKey constants (with the same string value)
ended up in the same translation unit and this renames them to
avoid colliding. A better fix would be to find a good common
location.

Bug:  746958 
Change-Id: I7c0f0e19455c5ab070a8e0e16714f84ee205133d
Reviewed-on: https://chromium-review.googlesource.com/874071
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530897}
[modify] https://crrev.com/75f56fea24f7c049e76f44751d58f1a33be3e6f2/chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc

Sign in to add a comment