New issue
Advanced search Search tips

Issue 746956 link

Starred by 9 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

[META] Compile Chromium with jumbo

Project Member Reported by brat...@opera.com, Jul 20 2017

Issue description

Jumbo, the unity build system in Chromium, makes compilations much faster. This is a meta task for efforts to jumbify various parts of the source.

Documentation: https://chromium.googlesource.com/chromium/src/+/master/docs/jumbo.md

Much more documentation:
https://docs.google.com/document/d/19jGsZxh7DX8jkAKbL1nYBa5rcByUL2EeidnYsoXfsYQ/edit

 

Comment 1 by brat...@opera.com, Jul 20 2017

Blockedon: 713137 746953

Comment 2 by brat...@opera.com, Jul 20 2017

Blockedon: 746957

Comment 3 by brat...@opera.com, Jul 20 2017

Blockedon: 746958

Comment 4 by most...@opera.com, Jul 20 2017

Cc: most...@opera.com

Comment 5 by brat...@opera.com, Jul 21 2017

Blockedon: 745862

Comment 6 by most...@opera.com, Jul 26 2017

Blockedon: 749302

Comment 7 by brat...@opera.com, Sep 18 2017

Blockedon: 766294

Comment 8 by brat...@opera.com, Oct 3 2017

Blockedon: 771153

Comment 9 by brat...@opera.com, Oct 5 2017

Blockedon: 772146

Comment 10 by brat...@opera.com, Oct 10 2017

Blockedon: 773275
Blockedon: 775547
Blockedon: 775611
Blockedon: 776946

Comment 14 by brat...@opera.com, Oct 27 2017

Blockedon: 779013
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9423f2def6d064ecafbd4bb612f71ba316164807

commit 9423f2def6d064ecafbd4bb612f71ba316164807
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 31 21:51:25 2017

Make it possible to exclude multiple targets from jumbo mode.

Bug: 746956
Change-Id: I3ac090022b0c4b94e519994d29928cea28b1813b
Reviewed-on: https://chromium-review.googlesource.com/747045
Reviewed-by: Daniel Bratell <bratell@opera.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512963}
[modify] https://crrev.com/9423f2def6d064ecafbd4bb612f71ba316164807/build/config/jumbo.gni

Comment 16 by brat...@opera.com, Nov 20 2017

Blockedon: 786926
Blocking: 495670
Blocking: 787983
Blocking: -495670
Components: Build

Comment 21 by brat...@opera.com, Jan 18 2018

Blockedon: 803406

Comment 22 by most...@vewd.com, Jan 22 2018

Cc: -most...@opera.com most...@vewd.com

Comment 23 by brat...@opera.com, Jun 7 2018

Blockedon: 850484
Project Member

Comment 24 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62222ed997bd8f7b53b4ec681093aab18ef2f22f

commit 62222ed997bd8f7b53b4ec681093aab18ef2f22f
Author: Jose Dapena Paz <jose.dapena@lge.com>
Date: Tue Jun 19 17:12:30 2018

[jumbo] Fix chrome extensions namespace aliases

Several chrome extensions namespace aliases are declared both in
namespace extensions:: and extensions::(anonymous). This is not failing
in non-jumbo build as on each unit it is declared one time. But on jumbo
build same compilation unit includes both aliases, breaking compilation.

Bug: 746956
Change-Id: Ic2255b204a832e7079bda24afb7e8769658dc2e4
Reviewed-on: https://chromium-review.googlesource.com/1105052
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#568503}
[modify] https://crrev.com/62222ed997bd8f7b53b4ec681093aab18ef2f22f/chrome/browser/extensions/api/sessions/sessions_api.cc
[modify] https://crrev.com/62222ed997bd8f7b53b4ec681093aab18ef2f22f/chrome/browser/extensions/api/tabs/tabs_event_router.cc

Blockedon: 864986
Project Member

Comment 26 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/869df987a9a9a012756b7d582984bb4ec98ec793

commit 869df987a9a9a012756b7d582984bb4ec98ec793
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Fri Aug 31 02:38:39 2018

[jumbo] Rename function name to fix a jumbo build fail

call to ConnectToWorkerInterfaceProvider is ambiguous.
because there are same function name.
- workers/dedicated_worker.cc
- workers/experimental/thread_pool.cc
thread_pool.cc was added latest.
so rename to ConnectToWorkerInterfaceProviderForThreadPool.

TBR=japhet@chromium.org

Bug: 746956
Change-Id: I3ad3d51351428c8fc3cbc4b617c41a40b8f7a1b4
Reviewed-on: https://chromium-review.googlesource.com/1198664
Reviewed-by: Hwanseung Lee <hs1217.lee@samsung.com>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#587924}
[modify] https://crrev.com/869df987a9a9a012756b7d582984bb4ec98ec793/third_party/blink/renderer/core/workers/experimental/thread_pool.cc

Blockedon: 867350
Blockedon: 881782
Blockedon: 801580
Blockedon: 887254
Blockedon: 870617
Blockedon: 890323
Blockedon: 869381
Blockedon: 898475

Sign in to add a comment