New issue
Advanced search Search tips

Issue 746948 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 715051



Sign in to add a comment

Media Engagement: have different threshold value to allow autoplay and disallow it

Project Member Reported by mlamouri@chromium.org, Jul 20 2017

Issue description

When a website is allowed to autoplay because of media engagement, we should not prevent autoplay when the media engagement index goes below the threshold to avoid websites oscillating around it.

We can start with 0.2 below the threshold to lose the privilege.

Let see if we can make it in M61. Because we only want metrics from these release, it wouldn't be a big deal if we miss.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/585d547c6e638f09881a4ae464e8f10cc153bbba

commit 585d547c6e638f09881a4ae464e8f10cc153bbba
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Aug 23 11:41:19 2017

Media Engagement: have different threshold value for autoplay

When a website is allowed to autoplay because of media engagement, we
should not prevent autoplay when the media engagement index goes below
the threshold to avoid websites oscillating around it.

BUG= 746948 

Change-Id: Ibe3e51e30641dd5b676c2d35262a74aa52cc695f
Reviewed-on: https://chromium-review.googlesource.com/603309
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496655}
[modify] https://crrev.com/585d547c6e638f09881a4ae464e8f10cc153bbba/chrome/browser/media/media_engagement_autoplay_browsertest.cc
[modify] https://crrev.com/585d547c6e638f09881a4ae464e8f10cc153bbba/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/585d547c6e638f09881a4ae464e8f10cc153bbba/chrome/browser/media/media_engagement_score.cc
[modify] https://crrev.com/585d547c6e638f09881a4ae464e8f10cc153bbba/chrome/browser/media/media_engagement_score.h
[modify] https://crrev.com/585d547c6e638f09881a4ae464e8f10cc153bbba/chrome/browser/media/media_engagement_score_unittest.cc
[modify] https://crrev.com/585d547c6e638f09881a4ae464e8f10cc153bbba/chrome/browser/media/media_engagement_service.cc
[modify] https://crrev.com/585d547c6e638f09881a4ae464e8f10cc153bbba/chrome/browser/media/media_engagement_service.h
[modify] https://crrev.com/585d547c6e638f09881a4ae464e8f10cc153bbba/chrome/browser/media/media_engagement_service_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae419bbed497aacbd2b2d93842118eb0d49f9ebe

commit ae419bbed497aacbd2b2d93842118eb0d49f9ebe
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Aug 25 10:56:43 2017

Media Engagement: Add "Is High" column to Media Engagement WebUI

As part of the threshold work we need to be able to see which
origins are considered high or not. This adds a "is high" column
to chrome://media-engagement.

BUG= 746948 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib3be4e27fb34d9d4cd0f7b648af124c453267422
Reviewed-on: https://chromium-review.googlesource.com/605208
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497373}
[modify] https://crrev.com/ae419bbed497aacbd2b2d93842118eb0d49f9ebe/chrome/browser/media/media_engagement_score.cc
[modify] https://crrev.com/ae419bbed497aacbd2b2d93842118eb0d49f9ebe/chrome/browser/media/media_engagement_score_details.mojom
[modify] https://crrev.com/ae419bbed497aacbd2b2d93842118eb0d49f9ebe/chrome/browser/resources/media/media_engagement.html
[modify] https://crrev.com/ae419bbed497aacbd2b2d93842118eb0d49f9ebe/chrome/browser/resources/media/media_engagement.js

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15a57a6bc51143ccbb44711bfdf2338701b4b4bd

commit 15a57a6bc51143ccbb44711bfdf2338701b4b4bd
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Aug 25 20:11:18 2017

Media Engagement: Add Engagement.IsHigh to UKM.

With the addition of bucketing, it would be useful
to know which scores are considered high by the
MEI service. Adding a field to UKM to do this.

BUG= 746948 

Change-Id: I12801566e18ee001b04a557e7ba93d4a82ea12a4
Reviewed-on: https://chromium-review.googlesource.com/635263
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497512}
[modify] https://crrev.com/15a57a6bc51143ccbb44711bfdf2338701b4b4bd/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/15a57a6bc51143ccbb44711bfdf2338701b4b4bd/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/15a57a6bc51143ccbb44711bfdf2338701b4b4bd/tools/metrics/ukm/ukm.xml

Status: Fixed (was: Started)
Blocking: 715051

Sign in to add a comment