New issue
Advanced search Search tips

Issue 746941 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

CustomTabsConnectionTest#testOnlyOneHiddenTab failing on chromium.linux/Android Tests

Project Member Reported by jdoerrie@chromium.org, Jul 20 2017

Issue description

chrome_public_test_apk failing on chromium.linux/Android Tests

Builders failed on: 
- Android Tests: 
  https://build.chromium.org/p/chromium.linux/builders/Android%20Tests


CustomTabsConnectionTest#testOnlyOneHiddenTab fails consistently on Android Tests Builder, suspecting http://crrev.com/c/578067 as culprit and assigning to author.
 
Labels: -Sheriff-Chromium
Reverted in http://crrev.com/c/579390.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/452d6f27ba176cec8b584b3c742d1f4d82fa954f

commit 452d6f27ba176cec8b584b3c742d1f4d82fa954f
Author: Benoit Lize <lizeb@chromium.org>
Date: Thu Jul 20 15:01:09 2017

Reland "customtabs: Don't allow multiple background tabs concurrently."

This reverts commit c4a9cd12b52e3fda276393ef8cce91cf6fca660d.

Reason for reland: Fixed myPid() / myUid() typo that made the test flaky.

> Original change's description:
> > customtabs: Don't allow multiple background tabs concurrently.
> >
> > BUG=742450
> >
> > Change-Id: Ia767797d89022b862e38b7ae72949bed08d94c09
> > Reviewed-on: https://chromium-review.googlesource.com/578067
> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> > Commit-Queue: Benoit L <lizeb@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#488171}

TBR=yusufo@chromium.org,jdoerrie@chromium.org

Change-Id: I6f512a971a561c04ba870b93e158eb325f3ed4da
Bug: 742450, 746941 
Reviewed-on: https://chromium-review.googlesource.com/579381
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488247}
[modify] https://crrev.com/452d6f27ba176cec8b584b3c742d1f4d82fa954f/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/452d6f27ba176cec8b584b3c742d1f4d82fa954f/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java

Comment 3 by lizeb@chromium.org, Aug 7 2017

Status: Fixed (was: Assigned)

Sign in to add a comment