New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746932 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: pytests: a test to confirm SKU information.

Project Member Reported by hungte@chromium.org, Jul 20 2017

Issue description

For projects sharing same firmware and disk image, we now request a hardware based identifier for "root of trust".

However, there should be an easy way for operators to manually verify if the "root of trust" matches what they think they are building - otherwise they may keep building a device with wrong hw identifier.

We want a pytest that displays a screen like

 Device Model: $(mosys platform model)
 Device SKU Number: $(mosys platform sku)
 Device Chassis: $(mosys platform chassis)
 Device Brand: $(mosys platform brand)

And then OP can press some button to confirm if these values are correct and continue.
 
Temporarily assign to Ting - please let me know if your place is full, and see if yhong/peter can help in that case.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/3cd69112fe04c5bfe99276feffc1cfd0f3662112

commit 3cd69112fe04c5bfe99276feffc1cfd0f3662112
Author: Ting Shen <phoenixshen@google.com>
Date: Fri Jul 28 14:47:02 2017

Add a test to check 'mosys platform' output

A new test to verify following `mosys platform` results manually:
- mosys platform model
- mosys platform sku
- mosys platform chassis
- mosys platform brand

BUG= chromium:746932 
TEST=Run OperatorTest(pytest_name='mosys_platform')

Change-Id: I3941997fa69f5785eb4146ff8285065299bbef3a
Reviewed-on: https://chromium-review.googlesource.com/586214
Commit-Ready: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/3cd69112fe04c5bfe99276feffc1cfd0f3662112/po/zh-CN.po
[add] https://crrev.com/3cd69112fe04c5bfe99276feffc1cfd0f3662112/py/test/pytests/mosys_platform.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/cc3d0877b2cab7d12eaedd1cfc700af5a8978ac9

commit cc3d0877b2cab7d12eaedd1cfc700af5a8978ac9
Author: Hung-Te Lin <hungte@chromium.org>
Date: Mon Aug 28 13:47:21 2017

pytests: Change 'mosys_platform' to a new 'model_sku' test.

For projects that need to setup different test arguments for different
SKU (for example number of cameras) we want everything set in device
data. The source may come from shopfloor#GetDeviceInfo, or SKU (via
hardware straps).

The new `model_sku` test will now confirm SKU information and set device
data according to model and SKU.

BUG= chromium:746932 
TEST=make test; manually run model_sku test.

Change-Id: Ibd3634c1e734f24643e161cc23b829098e08702c
Reviewed-on: https://chromium-review.googlesource.com/637286
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/cc3d0877b2cab7d12eaedd1cfc700af5a8978ac9/py/test/test_lists/generic_common.test_list.json
[modify] https://crrev.com/cc3d0877b2cab7d12eaedd1cfc700af5a8978ac9/po/zh-CN.po
[add] https://crrev.com/cc3d0877b2cab7d12eaedd1cfc700af5a8978ac9/py/test/pytests/model_sku.schema.json
[add] https://crrev.com/cc3d0877b2cab7d12eaedd1cfc700af5a8978ac9/py/test/pytests/model_sku.json
[delete] https://crrev.com/309c4f27cc19751c55b031692b89c619cc84f109/py/test/pytests/mosys_platform.py
[add] https://crrev.com/cc3d0877b2cab7d12eaedd1cfc700af5a8978ac9/py/test/pytests/model_sku.py

Comment 3 by hungte@chromium.org, Sep 26 2017

Status: Fixed (was: Untriaged)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment