New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 746908 link

Starred by 1 user
Status: Archived
Owner:
calamity@chromium.org
Closed: Sep 19
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ tsergeant@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Bookmark manager context menu doesn't update when items change

Reported by vku...@etouch.net, Jul 20 2017 
Chrome Version:61.0.3162.0(Official Build) 46d636d25e054da0b0d8270d525c84f39146ce30-refs/heads/master@{#488073} 32/64 bit
OS: Windows (7,8,10), Mac(10.11.6, 10.12.3), Linux(14.04 LTS)

What steps will reproduce the problem?
(1)Launch chrome open 3-4 webpages and click on star icon to bookmark it
(2)Navigate to chrome://bookmarks/ ,click on iron > delete any 2 bookmarked entry and right click on 'bookmarks bar' folder from left to open context menu (with count)
(3)Now again bookmark the unbookmark pages by clicking on star icon,switch back to bookmarks tab and observe the count.

Actual: Count for bookmark entry in context menu doesn't changes even if webpages are bookmarked.

Expected: Count for bookmark entry in context menu should change once any webpage is bookmarked.

This is a regression issue broken in 'M61' and below is the manual regression range
Good Build: 61.0.3137.0
Bad Build:  61.0.3138.0
Actual_count.mp4
1.1 MB View Download

Comment 1 by brajkumar@chromium.org, Jul 20 2017

Labels: hasbisect-per-revision
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
Providing per-revision bisect information below

Bisect Information:
---------------------
You are probably looking for a change made after 481157 (known good), but no later than 481163 (first known bad).

Change Log URL: 
------------------
https://chromium.googlesource.com/chromium/src/+log/b8894a5a53943461944899421f1264c33a5a933e..d16b69bc237e5f5d2cc75681aec6d2c130a05f14

From the above CL suspecting the below change
https://chromium.googlesource.com/chromium/src/+/64e2012a9e0278ff735674d16db1c44caefc91ae

calamity@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 2 by calamity@chromium.org, Jul 21 2017

Cc: tsergeant@chromium.org
Labels: -Pri-1 Proj-MaterialDesign-WebUI Pri-3
Summary: Bookmark manager context menu doesn't update when items change (was: Regression:Count for bookmark entry in context menu doesn't changes even if webpages are bookmarked.)
@tsergeant: This isn't the worst thing at the moment, but a similar thing can happen that results in an invalid open/delete if you have a stale context menu on a deleted item. It might be worth listening for menu ids that change, or just closing the action menu on blur.

Comment 3 by markchang@chromium.org, Sep 19

Status: Archived (was: Assigned)
►

Sign in to add a comment