New issue
Advanced search Search tips

Issue 746904 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 636993



Sign in to add a comment

ShapeResult::glyph_bounding_box_ is incorrect in a few cases

Project Member Reported by kojii@chromium.org, Jul 20 2017

Issue description

While investigating using glyph_boudning_box_ for LayoutNG[1], I found there are a few cases where we compute it incorrectly. They're less visible in the current layout thanks to word cache, but is more visible to LayoutNG where we shape longer text.

1. When runs are split, glyph bounds of each run starts at (0, 0) and
   united, resulting much smaller width.[2]
2. The usage of offset looks incorrect.
3. In vertical flow, physical and logical coordinates are mixed and
   united.

#1 affects when a word (in current layout engine, a block of text in LayoutNG) contains more than one font, script, orientation, or such properties that causes runs to split. We compute bounds of each run at (0,0) and unite, so the bounds is much smaller.

#2 affects when glyph offset is non-zero. This happens in some complex scripts, and in vertical flow.

#3 affects vertical flow, and needs rather larger fix than #1/#2.

[1] r487410, https://chromium-review.googlesource.com/c/574508/
 

Comment 1 by kojii@chromium.org, Jul 20 2017

Blocking: 636993
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/546e3610048802c046a2a4812d8de8f08a500b43

commit 546e3610048802c046a2a4812d8de8f08a500b43
Author: Koji Ishii <kojii@chromium.org>
Date: Fri Jul 21 09:34:33 2017

Fix ShapeResult::Bounds() when runs are split

HarfBuzzShaper calls ShapeResult::InsertRun() for each run RunSegmenter
segmented.

This patch fixes ShapeResult::InsertRun() to compute
ShapeResult::glyph_bounding_box_ when there are more than one run.

Before this fix, it computes glyph bounding box of each run from (0,0)
then unite all bounding boxes. So if input text is "englishARABIC",
RunSegmenter creates 2 runs and each InsertRun computes:
Run 1: "english", width 70, bounding box (0,0,70,10) (x,y,w,h)
Run 2: "ARABIC", width 80, bounding box (0,0,80,10)
then the united result would be (0,0,80,0) while the total width is 150.

This patch fixes InsertRun() to compute bounding box from the current
point, so that:
Run 1: "english", width 70, bounding box (0,0,70,10)
Run 2: "ARABIC", width 80, bounding box (70,0,80,10)
and the united result would be (0,0,150,0).

This patch also removes incorrect fix made to ShapeResult::CopyRange().
This was done to pass tests in a previous CL[1], but turned out that
the original glyph bounds is incorrect and the fix was wrong.

[1] r487410, https://chromium-review.googlesource.com/c/574508/

BUG= 746904 , 636993

Change-Id: Iec147e5e9b9853a60489e23355ede730ce918c36
Reviewed-on: https://chromium-review.googlesource.com/577970
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488626}
[modify] https://crrev.com/546e3610048802c046a2a4812d8de8f08a500b43/third_party/WebKit/LayoutTests/platform/linux/svg/text/combining-character-queries-expected.txt
[modify] https://crrev.com/546e3610048802c046a2a4812d8de8f08a500b43/third_party/WebKit/LayoutTests/platform/win/svg/text/combining-character-queries-expected.txt
[modify] https://crrev.com/546e3610048802c046a2a4812d8de8f08a500b43/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
[modify] https://crrev.com/546e3610048802c046a2a4812d8de8f08a500b43/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58b4aa6edd31e6553e7d5588bc528fda1558e071

commit 58b4aa6edd31e6553e7d5588bc528fda1558e071
Author: Koji Ishii <kojii@chromium.org>
Date: Sun Jul 23 08:04:53 2017

Fix usage of offsets in ShapeResult::Bounds()

This patch fixes ShapeResult::Bounds() when glyphs have offsets.

HarfBuzz returns hb_glyph_position_t for each glyph. As the document[1]
explains, all hb_position_t in this struct are relative to the current
point.

This patch fixes computing glyph bounding box from hb_glyph_position_t:
1. Glyph bounds of each glyph should be set at the current point +
   {x,y}_offset. Before this fix, it was at the current point.
2. The current point should advance by {x,y}_advance. Before this fix,
   it was by advance + offset.

Note that glyph_bounding_box_ is still incorrect in a couple of more
cases, such as multiple runs or vertical flow. They're being worked on
in separate patches. See  crbug.com/746904  for other problems.

[1] https://behdad.github.io/harfbuzz/harfbuzz-Buffers.html#hb-glyph-position-t-struct

BUG= 746904 , 636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Change-Id: Ie6aba1da20b67a9c98204627f0c625b389b8a2e0
Reviewed-on: https://chromium-review.googlesource.com/577973
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488880}
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/inline-style-change-in-scrolled-view-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/japanese-rl-selection-clear-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/japanese-rl-selection-repaint-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/positioned-great-grandparent-change-location-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-I18N/text-anchor-no-markup-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/masking-path-04-b-expected.png
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-align-05-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-align-06-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/batik/filters/feTile-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/batik/paints/gradientLimit-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textEffect-expected.png
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textEffect-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textEffect2-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textStyles-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/verticalText-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/verticalTextOnPath-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/carto.net/textbox-expected.txt
[delete] https://crrev.com/f3dd555910d1e01f09f27c44cab8223fe8c27334/third_party/WebKit/LayoutTests/platform/linux/svg/custom/clip-mask-negative-scale-expected.txt
[delete] https://crrev.com/f3dd555910d1e01f09f27c44cab8223fe8c27334/third_party/WebKit/LayoutTests/platform/linux/svg/custom/feComponentTransfer-Discrete-expected.txt
[delete] https://crrev.com/f3dd555910d1e01f09f27c44cab8223fe8c27334/third_party/WebKit/LayoutTests/platform/linux/svg/custom/feComponentTransfer-Gamma-expected.txt
[delete] https://crrev.com/f3dd555910d1e01f09f27c44cab8223fe8c27334/third_party/WebKit/LayoutTests/platform/linux/svg/custom/feComponentTransfer-Linear-expected.txt
[delete] https://crrev.com/f3dd555910d1e01f09f27c44cab8223fe8c27334/third_party/WebKit/LayoutTests/platform/linux/svg/custom/feComponentTransfer-Table-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/custom/stroked-pattern-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-text-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/filters/filter-on-tspan-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/text/combining-character-queries-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/text/ligature-queries-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/text/surrogate-pair-queries-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-align-05-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-align-06-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-intro-05-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/text/combining-character-queries-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/japanese-rl-selection-repaint-expected.txt
[add] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt
[add] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/batik/text/verticalText-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/text/combining-character-queries-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/japanese-rl-selection-clear-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/japanese-rl-selection-repaint-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/verticalText-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/verticalTextOnPath-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/text/combining-character-queries-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/text/text-selection-align-05-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/text/text-selection-align-06-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/mac/svg/text/text-selection-intro-05-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-in-relative-inline-expected.png
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/japanese-rl-selection-clear-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/japanese-rl-selection-repaint-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-align-05-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/verticalText-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/verticalTextOnPath-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/text/combining-character-queries-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/text/surrogate-pair-queries-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/text/text-selection-align-05-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/text/text-selection-align-06-b-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win/svg/text/text-selection-intro-05-t-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/japanese-rl-selection-clear-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/japanese-rl-selection-repaint-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt
[modify] https://crrev.com/58b4aa6edd31e6553e7d5588bc528fda1558e071/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt
[modi
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be87f9d72a446ff1816cba3f7be16d771e68d5bc

commit be87f9d72a446ff1816cba3f7be16d771e68d5bc
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Wed Nov 01 15:25:46 2017

Clean up flaky expectations with update-flaky-expectations

Bug:  457273 , 605525 ,626703, 667560 ,708499, 731509 , 731535 , 732103 , 736548 , 746904 , 747163 , 752845 , 771729 
Change-Id: Ibf4be93e26a364e91d44375379aa8b5a7b59b94f
Reviewed-on: https://chromium-review.googlesource.com/736047
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513134}
[modify] https://crrev.com/be87f9d72a446ff1816cba3f7be16d771e68d5bc/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e286250b9e5c11b0a9e14d6b243dc206999c4a50

commit e286250b9e5c11b0a9e14d6b243dc206999c4a50
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Jan 05 00:42:57 2018

Update TestExpectations with update-flaky-expectations

This CL was initially based on changes made by the third_party/WebKit/Tools/Scripts/update-flaky-expectations, but includes manual changes as well, including formatting changes and making expectations more specific based on visually checking the flakiness dashboard results.

Flakiness dashboard link:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=http/tests/devtools/coverage/coverage-view.js,inspector-protocol/layout-fonts/cjk-ideograph-fallback-by-lang.js,http/tests/websocket/close-code-and-reason.html,external/wpt/css/css-writing-modes/writing-mode-vertical-rl-001.xht,external/wpt/css/css-writing-modes/writing-mode-vertical-rl-002.xht,external/wpt/css/css-fonts/font-display/font-display.html,fast/workers/chromium/worker-document-leak.html,fast/dom/Window/window-resize-contents.html,fast/text/ellipsis-in-relative-inline.html,fast/spatial-navigation/snav-1st-stop.html,fast/spatial-navigation/snav-display-contents-crash.html,fast/spatial-navigation/snav-div-in-anchor-and-img-crash.html,fast/spatial-navigation/snav-div-in-anchor.html,fast/spatial-navigation/snav-hidden-focusable-element.html,fast/spatial-navigation/snav-iframe-nested.html,fast/spatial-navigation/snav-iframe-no-focusable-content.html,fast/spatial-navigation/snav-iframe-no-scrollable-content.html,fast/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html,fast/spatial-navigation/snav-media-elements.html,fast/spatial-navigation/snav-multiple-select-focusring.html,fast/spatial-navigation/snav-offscreen-content.html,fast/spatial-navigation/snav-only-clipped-overflow-content.html,fast/spatial-navigation/snav-simple-content-overflow.html,fast/spatial-navigation/snav-single-select-list.html,fast/spatial-navigation/snav-zero-margin-content.html,external/wpt/clear-site-data/storage.https.html,http/tests/devtools/network/network-xhr-same-url-as-main-resource.js,virtual/mouseevent_fractional/fast/events/touch/gesture/gesture-tap-hover-state-iframe.html

Bug:  518989 ,  520737 , 520739,  564109 ,  729836 ,  731535 ,  746904 , 757165, 767040,  767269 ,  773353 ,  785980 ,  795250 
Change-Id: I03ac7e658ee42ccf3798e7f3994d30fc74880565
Reviewed-on: https://chromium-review.googlesource.com/847835
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527171}
[modify] https://crrev.com/e286250b9e5c11b0a9e14d6b243dc206999c4a50/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment