[iOS] No more hack to send a request with a body |
||
Issue descriptionFor iOS 10 or below, WKWebView was not able to load a POST request with a body. To work around this issue, the request was send using javascript. This has been fixed in iOS 11.0: https://bugs.webkit.org/show_bug.cgi?id=167131 (tracked in chromium code with https://bugs.webkit.org/show_bug.cgi?id=145410 Issue related with crbug.com/740987
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17fb0d73513a07eb5eb9fa9fcd82a7282de19727 commit 17fb0d73513a07eb5eb9fa9fcd82a7282de19727 Author: Jérôme Lebel <jlebel@chromium.org> Date: Mon Jul 24 11:43:37 2017 No more javascript hack to load a request with body WKWebView was not supporting to load a POST request with a body. The work around was to load it with javascript. This has been fixed with iOS 11: https://bugs.webkit.org/show_bug.cgi?id=167131 Bug: 746882 Change-Id: Ia5c2bf49f2d7e8da0993bc33c95c4c8447a83eac Reviewed-on: https://chromium-review.googlesource.com/579189 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Mihai Sardarescu (OOO) <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#488948} [modify] https://crrev.com/17fb0d73513a07eb5eb9fa9fcd82a7282de19727/ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95934a8a6c05e3702fdfa08bd81243516817f0ac commit 95934a8a6c05e3702fdfa08bd81243516817f0ac Author: Justin Cohen <justincohen@chromium.org> Date: Wed Jul 26 00:33:25 2017 Revert "No more javascript hack to load a request with body" This reverts commit 17fb0d73513a07eb5eb9fa9fcd82a7282de19727. Reason for revert: Causing GaiaAuthFetcherIOSTest, StartOAuthLoginCancelled to fail downstream. Original change's description: > No more javascript hack to load a request with body > > WKWebView was not supporting to load a POST request with a body. The > work around was to load it with javascript. This has been fixed with iOS > 11: https://bugs.webkit.org/show_bug.cgi?id=167131 > > Bug: 746882 > Change-Id: Ia5c2bf49f2d7e8da0993bc33c95c4c8447a83eac > Reviewed-on: https://chromium-review.googlesource.com/579189 > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Mihai Sardarescu (OOO) <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488948} TBR=msarda@chromium.org,jlebel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 746882 Change-Id: Id7ab4488534d193a401b7eed268ae0a791ae73fe Reviewed-on: https://chromium-review.googlesource.com/585787 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#489498} [modify] https://crrev.com/95934a8a6c05e3702fdfa08bd81243516817f0ac/ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2e0df316f4a8d409192ec34a53c0efc3405bb16 commit b2e0df316f4a8d409192ec34a53c0efc3405bb16 Author: Jérôme Lebel <jlebel@chromium.org> Date: Wed Jul 26 12:35:41 2017 No more javascript hack to load a request with body WKWebView was not supporting to load a POST request with a body. The work around was to load it with javascript. This has been fixed with iOS 11: https://bugs.webkit.org/show_bug.cgi?id=167131 Sending again crrev.com/c/579189 (patch set 1), and fixing unit test (GaiaAuthFetcherIOSTest.StartOAuthLoginCancelled). Bug: 746882 Change-Id: Id99280f4c61c5024dbbe648a247d1bf8f93efaca Reviewed-on: https://chromium-review.googlesource.com/586587 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#489616} [modify] https://crrev.com/b2e0df316f4a8d409192ec34a53c0efc3405bb16/ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm [modify] https://crrev.com/b2e0df316f4a8d409192ec34a53c0efc3405bb16/ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm
,
Jul 26 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by jlebel@chromium.org
, Jul 20 2017