Unable to search language in add language overlay after changing browser language to 'Marathi'.
Reported by
pranjali...@etouch.net,
Jul 20 2017
|
|||||||||
Issue descriptionChrome Version:61.0.3162.0 (Official Build)(cohort: Stable)46d636d25e054da0b0d8270d525c84f39146ce30-refs/heads/master@{#488073}(32/64 bit) OS: Windows(7,8,10). Steps to reproduce: 1. Launch Chrome, go to chrome://settings/languages, change browser language to 'Marathi'. 2. Relaunch Chrome,now search another language from 'Add language' overlay and observe . Actual Result: Unable to search language in add language overlay after changing browser language to 'Marathi'. . Expected Result: Should be able to search language in add language overlay after changing browser language to 'Marathi'. This is Non regression issue Seen from 'M 59' from # 59.0.3051.3 Note: This issue is not reproducible on Linux and MAC
,
Jul 20 2017
,
Jul 20 2017
,
Jul 20 2017
I am able to reproduce this on Linux too. The problem is that when searching only the text in the current language is searched. In other words, the text after the dash "-" is not being searched.
,
Jul 20 2017
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48eec179683e3aebade5ad691ccbe1cfcb99df38 commit 48eec179683e3aebade5ad691ccbe1cfcb99df38 Author: dpapad <dpapad@chromium.org> Date: Fri Jul 21 23:36:14 2017 MD Settings: Fix add language dialog search. Previously it would not search any of the native language names, resulting in missing results. Bug: 746880 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6fb39d532eb87bf138c22018ca81638b1083a969 Reviewed-on: https://chromium-review.googlesource.com/580250 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#488792} [modify] https://crrev.com/48eec179683e3aebade5ad691ccbe1cfcb99df38/chrome/browser/resources/settings/languages_page/add_languages_dialog.js [modify] https://crrev.com/48eec179683e3aebade5ad691ccbe1cfcb99df38/chrome/test/data/webui/settings/fake_language_settings_private.js [modify] https://crrev.com/48eec179683e3aebade5ad691ccbe1cfcb99df38/chrome/test/data/webui/settings/languages_page_tests.js
,
Jul 21 2017
The fix missed the M61 cutoff. I'll wait until the fix is verified on Canary, and potentially ask for a merge later.
,
Jul 25 2017
,
Jul 26 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26 2017
Pls merge you change to M61 branch 3163 by 5:00 PM today, Wednesday if possible so we can take it in for next week M61 last dev release. Thank you.
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8dbc6c88ba957273d1eaee32a26f5b444db355aa commit 8dbc6c88ba957273d1eaee32a26f5b444db355aa Author: dpapad <dpapad@chromium.org> Date: Thu Jul 27 18:03:30 2017 M61 merge: MD Settings: Fix add language dialog search. Previously it would not search any of the native language names, resulting in missing results. Bug: 746880 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6fb39d532eb87bf138c22018ca81638b1083a969 Reviewed-on: https://chromium-review.googlesource.com/580250 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488792} Reviewed-on: https://chromium-review.googlesource.com/590287 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#86} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/8dbc6c88ba957273d1eaee32a26f5b444db355aa/chrome/browser/resources/settings/languages_page/add_languages_dialog.js [modify] https://crrev.com/8dbc6c88ba957273d1eaee32a26f5b444db355aa/chrome/test/data/webui/settings/fake_language_settings_private.js [modify] https://crrev.com/8dbc6c88ba957273d1eaee32a26f5b444db355aa/chrome/test/data/webui/settings/languages_page_tests.js |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rbasuvula@chromium.org
, Jul 20 2017