We need to deprecate and remove MediaControlPainter in Blink. Icons for media controls should be added to the CSS by Grit using background images with the correct size for different platforms.
We need to deprecate and remove MediaControlPainter in Blink. Icons for media controls should be added to the CSS by Grit using background images with the correct size for different DPIs. Design: https://docs.google.com/document/d/1QjWB4eUspYDnsr42Jxasv_FVZTe8anDL_XIqE57Rs4k/edit?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a3b36ef9e6c6747876175f48f8cb24e6573dc30 commit 8a3b36ef9e6c6747876175f48f8cb24e6573dc30 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Sep 07 16:05:06 2017 Media Controls: Replace painter with CSS. Replace MediaControlPainter with CSS. Add some classes to some elements to allow styling by state. BUG= 746872 Change-Id: I1c226a85ff133b9bf440925b238abf7810c9482a Reviewed-on: https://chromium-review.googlesource.com/584771 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#500312} [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/content/child/blink_platform_impl.cc [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/media/controls/closed-captions-single-track.html [add] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-cast.html [add] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-fullscreen.html [add] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-mute.html [add] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-overlay-cast.html [add] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-pause.html [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/media/media-controls.js [copy] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt [rename] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png [add] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-iframe-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-zoom-controls-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac-retina/media/video-zoom-controls-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-dark-rendering-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-light-rendering-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt [delete] https://crrev.com/90aea30bfe9f409ea13803fe4417f869e5fe356d/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-unmute-repaint-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-dark-rendering-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-light-rendering-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/win/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/win/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt [delete] https://crrev.com/90aea30bfe9f409ea13803fe4417f869e5fe356d/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-mute-repaint-expected.txt [delete] https://crrev.com/90aea30bfe9f409ea13803fe4417f869e5fe356d/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-unmute-repaint-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt [add] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/LayoutTests/platform/win7/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/BUILD.gn [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.cpp [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.cpp [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.cpp [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.cpp [add] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp [add] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.h [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.cpp [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/resources/mediaControls.css [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/third_party/WebKit/Source/modules/media_controls/resources/media_controls_resources.grd [modify] https://crrev.com/8a3b36ef9e6c6747876175f48f8cb24e6573dc30/tools/gritsettings/resource_ids
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c63fc3b97b48735ace0a846e2ef9414a50be2b05 commit c63fc3b97b48735ace0a846e2ef9414a50be2b05 Author: Roger McFarlane <rogerm@chromium.org> Date: Thu Sep 07 20:06:39 2017 Revert "Media Controls: Replace painter with CSS." This reverts commit 8a3b36ef9e6c6747876175f48f8cb24e6573dc30. Reason for revert: Seeing a lot of new WebKit media failures. Please validate and fix/reland as appropriate. Original change's description: > Media Controls: Replace painter with CSS. > > Replace MediaControlPainter with CSS. Add some classes to some > elements to allow styling by state. > > BUG= 746872 > > Change-Id: I1c226a85ff133b9bf440925b238abf7810c9482a > Reviewed-on: https://chromium-review.googlesource.com/584771 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500312} TBR=thakis@chromium.org,mlamouri@chromium.org,pfeldman@chromium.org,beccahughes@chromium.org Change-Id: I681803781e9e60f1030589a7bd6a5cb0d91e061e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 746872 Reviewed-on: https://chromium-review.googlesource.com/655739 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#500363} [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/content/child/blink_platform_impl.cc [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/media/controls/closed-captions-single-track.html [delete] https://crrev.com/9cc23fc96d98add479f10016e9948a5763577651/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-cast.html [delete] https://crrev.com/9cc23fc96d98add479f10016e9948a5763577651/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-fullscreen.html [delete] https://crrev.com/9cc23fc96d98add479f10016e9948a5763577651/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-mute.html [delete] https://crrev.com/9cc23fc96d98add479f10016e9948a5763577651/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-overlay-cast.html [delete] https://crrev.com/9cc23fc96d98add479f10016e9948a5763577651/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-pause.html [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/media/media-controls.js [delete] https://crrev.com/9cc23fc96d98add479f10016e9948a5763577651/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png [delete] https://crrev.com/9cc23fc96d98add479f10016e9948a5763577651/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-iframe-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-zoom-controls-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac-retina/media/video-zoom-controls-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-dark-rendering-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-light-rendering-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt [rename] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-mute-repaint-expected.txt [copy] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-unmute-repaint-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-dark-rendering-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-light-rendering-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/win/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/win/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt [copy] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-mute-repaint-expected.txt [copy] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-unmute-repaint-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt [delete] https://crrev.com/9cc23fc96d98add479f10016e9948a5763577651/third_party/WebKit/LayoutTests/platform/win7/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/BUILD.gn [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.cpp [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.cpp [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.cpp [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.cpp [delete] https://crrev.com/9cc23fc96d98add479f10016e9948a5763577651/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp [delete] https://crrev.com/9cc23fc96d98add479f10016e9948a5763577651/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.h [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.cpp [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/resources/mediaControls.css [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/third_party/WebKit/Source/modules/media_controls/resources/media_controls_resources.grd [modify] https://crrev.com/c63fc3b97b48735ace0a846e2ef9414a50be2b05/tools/gritsettings/resource_ids
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3faf6057ca1237a94d2e9fa7805acc9520017b2 commit b3faf6057ca1237a94d2e9fa7805acc9520017b2 Author: Robert Flack <flackr@chromium.org> Date: Thu Sep 07 21:43:45 2017 Re-add test expectations from original touch action patch. The test expectations from I4d160d64e895e270403f3bd826ac41b8231e4709 had to be reverted when I1c226a85ff133b9bf440925b238abf7810c9482a landed but since it has been reverted we need to re-add these expectations from the original CL. BUG= 746872 , 762995 NOTRY=true TBR=xidachen@chromium.org,dtapuska@chromium.org Change-Id: I2992c8e8ae4fce5a9b4d3b3bd0211e3de3681830 Reviewed-on: https://chromium-review.googlesource.com/656199 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#500399} [modify] https://crrev.com/b3faf6057ca1237a94d2e9fa7805acc9520017b2/third_party/WebKit/LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt [add] https://crrev.com/b3faf6057ca1237a94d2e9fa7805acc9520017b2/third_party/WebKit/LayoutTests/platform/mac/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d94db169aaa0575c69748741718b80b2526b4097 commit d94db169aaa0575c69748741718b80b2526b4097 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Sep 25 17:45:18 2017 Media Controls: Replace painter with CSS. Replace MediaControlPainter with CSS. Add some classes to some elements to allow styling by state. This is a resubmit of the button code only from crrev.com/c/584771. BUG= 746872 TBR=pfeldman@chromium.org Change-Id: If79ce339a10f6671ddd02a223468bb3d7bbcd1df Reviewed-on: https://chromium-review.googlesource.com/657024 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#504095} [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/content/child/blink_platform_impl.cc [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/media/controls/closed-captions-single-track.html [add] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-cast.html [add] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-fullscreen.html [add] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-mute.html [add] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-overlay-cast.html [add] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-pause.html [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-zoom-controls-expected.png [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/mac-retina/media/video-zoom-controls-expected.png [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-dark-rendering-expected.png [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-light-rendering-expected.png [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-mute-repaint-expected.txt [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-dark-rendering-expected.png [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-light-rendering-expected.png [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-mute-repaint-expected.txt [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.cpp [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.cpp [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.cpp [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.cpp [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/Source/modules/media_controls/resources/mediaControls.css [modify] https://crrev.com/d94db169aaa0575c69748741718b80b2526b4097/third_party/WebKit/Source/modules/media_controls/resources/media_controls_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cee291fdd49189d8250e83e1711c702b0b2a00f4 commit cee291fdd49189d8250e83e1711c702b0b2a00f4 Author: Hector Carmona <hcarmona@chromium.org> Date: Tue Sep 26 00:44:31 2017 Revert "Media Controls: Replace painter with CSS." This reverts commit d94db169aaa0575c69748741718b80b2526b4097. Reason for revert: Seeing lots of layout failures. Suspecting this CL. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak Original change's description: > Media Controls: Replace painter with CSS. > > Replace MediaControlPainter with CSS. Add some classes to some > elements to allow styling by state. This is a resubmit of the > button code only from crrev.com/c/584771. > > BUG= 746872 > > TBR=pfeldman@chromium.org > > Change-Id: If79ce339a10f6671ddd02a223468bb3d7bbcd1df > Reviewed-on: https://chromium-review.googlesource.com/657024 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504095} TBR=mlamouri@chromium.org,pfeldman@chromium.org,beccahughes@chromium.org Change-Id: I698bec05d24045896e664e287415cba5f19d9f60 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 746872 Reviewed-on: https://chromium-review.googlesource.com/683434 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#504238} [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/content/child/blink_platform_impl.cc [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/media/controls/closed-captions-single-track.html [delete] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-cast.html [delete] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-fullscreen.html [delete] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-mute.html [delete] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-overlay-cast.html [delete] https://crrev.com/bfcf3bb0e4ce938feac3fb2951488b8355c37e0f/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-pause.html [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-zoom-controls-expected.png [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/mac-retina/media/video-zoom-controls-expected.png [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-dark-rendering-expected.png [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-light-rendering-expected.png [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-mute-repaint-expected.txt [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-dark-rendering-expected.png [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-light-rendering-expected.png [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-mute-repaint-expected.txt [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.cpp [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.cpp [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.cpp [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.cpp [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/Source/modules/media_controls/resources/mediaControls.css [modify] https://crrev.com/cee291fdd49189d8250e83e1711c702b0b2a00f4/third_party/WebKit/Source/modules/media_controls/resources/media_controls_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7 commit b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Sep 28 07:56:59 2017 Reland "Media Controls: Replace painter with CSS." This is a reland of d94db169aaa0575c69748741718b80b2526b4097 Original change's description: > Media Controls: Replace painter with CSS. > > Replace MediaControlPainter with CSS. Add some classes to some > elements to allow styling by state. This is a resubmit of the > button code only from crrev.com/c/584771. > > BUG= 746872 > > TBR=pfeldman@chromium.org > > Change-Id: If79ce339a10f6671ddd02a223468bb3d7bbcd1df > Reviewed-on: https://chromium-review.googlesource.com/657024 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504095} TBR=mlamouri@chromium.org,pfeldman@chromium.org Bug: 746872 Change-Id: Iad1df7ec72b0e581acdc39774a2460bac51557d5 Reviewed-on: https://chromium-review.googlesource.com/684074 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#504936} [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/content/child/blink_platform_impl.cc [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/media/controls/closed-captions-single-track.html [add] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-cast.html [add] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-fullscreen.html [add] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-mute.html [add] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-overlay-cast.html [add] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/media/controls/toggle-class-with-state-pause.html [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-zoom-controls-expected.png [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/mac-retina/media/video-zoom-controls-expected.png [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-dark-rendering-expected.png [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-overlay-cast-light-rendering-expected.png [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-mute-repaint-expected.txt [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-dark-rendering-expected.png [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-overlay-cast-light-rendering-expected.png [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-mute-repaint-expected.txt [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.cpp [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.cpp [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.cpp [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.cpp [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/Source/modules/media_controls/resources/mediaControls.css [modify] https://crrev.com/b1df7b5e17fdf77e3da208ba8ccdb16d04efebf7/third_party/WebKit/Source/modules/media_controls/resources/media_controls_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46fb5c855a8622fe73a5c8000b7370407b9122af commit 46fb5c855a8622fe73a5c8000b7370407b9122af Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Sep 28 11:09:34 2017 Media Controls: Replace painter with CSS (timeline). Replace MediaControlPainter with CSS. Add some classes to some elements to allow styling by state. This is a resubmit of the timeline code from crrev.com/c/584771 but updated. BUG= 746872 Change-Id: Ie5bd5a997a0f45e5042eab4be687af3564322b2d Reviewed-on: https://chromium-review.googlesource.com/657820 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#504966} [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt [add] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/media/controls/repaint-on-resize-expected.html [add] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/media/controls/repaint-on-resize.html [rename] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt [rename] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png [delete] https://crrev.com/41ed4a4682284e379929281189ede6a9e13a1fb4/third_party/WebKit/LayoutTests/platform/linux/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.png [delete] https://crrev.com/41ed4a4682284e379929281189ede6a9e13a1fb4/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png [delete] https://crrev.com/41ed4a4682284e379929281189ede6a9e13a1fb4/third_party/WebKit/LayoutTests/platform/mac/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt [delete] https://crrev.com/41ed4a4682284e379929281189ede6a9e13a1fb4/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/video-unmute-repaint-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/media/controls/video-controls-with-cast-rendering-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt [delete] https://crrev.com/41ed4a4682284e379929281189ede6a9e13a1fb4/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/video-mute-repaint-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt [add] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/LayoutTests/platform/win7/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.png [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/Source/modules/media_controls/BUILD.gn [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/Source/modules/media_controls/MediaControlsMediaEventListener.cpp [add] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp [add] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.h [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.cpp [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h [modify] https://crrev.com/46fb5c855a8622fe73a5c8000b7370407b9122af/third_party/WebKit/Source/modules/media_controls/resources/mediaControls.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b999cd773e8246b2f9fda4d145051fb508a2a198 commit b999cd773e8246b2f9fda4d145051fb508a2a198 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Oct 02 12:36:26 2017 Media Controls: Deprecate and remove MediaControlPainter Deprecate and remove MediaControlPainter since it is no longer needed. BUG= 746872 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I693e575576a84eb80a7cfcd8bb3ecbc4ed0eade8 Reviewed-on: https://chromium-review.googlesource.com/612068 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#505590} [modify] https://crrev.com/b999cd773e8246b2f9fda4d145051fb508a2a198/third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp [modify] https://crrev.com/b999cd773e8246b2f9fda4d145051fb508a2a198/third_party/WebKit/Source/core/layout/LayoutThemeMac.h [modify] https://crrev.com/b999cd773e8246b2f9fda4d145051fb508a2a198/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm [modify] https://crrev.com/b999cd773e8246b2f9fda4d145051fb508a2a198/third_party/WebKit/Source/core/paint/BUILD.gn [delete] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp [delete] https://crrev.com/ea1396c5a014fec9738aa6cbd4c0852e1961a799/third_party/WebKit/Source/core/paint/MediaControlsPainter.h [modify] https://crrev.com/b999cd773e8246b2f9fda4d145051fb508a2a198/third_party/WebKit/Source/core/paint/ThemePainter.cpp [modify] https://crrev.com/b999cd773e8246b2f9fda4d145051fb508a2a198/third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp [modify] https://crrev.com/b999cd773e8246b2f9fda4d145051fb508a2a198/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css
Comment 1 by beccahughes@chromium.org
, Jul 21 2017