New issue
Advanced search Search tips

Issue 746864 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Milo: show stats about Console def imports

Project Member Reported by hinoka@chromium.org, Jul 20 2017

Issue description

These are things that are useful for seeing what the state of console definitions are for the /admin/configs page:

* Last import attempt
* Last import attempt error messages
* Last import attempt config text
* Consoles marked with date/time of last import attempt, and if the most recent import attempt resulted in an error.
 

Comment 1 by no...@chromium.org, Jul 20 2017

Validation should be really implemented at the luci-config level, not Milo.

include_last_import_attempt parameter in get_config_sets API would be useful. It can show a list of errors. luci-config UI will show that list of errors too (given validation is implemented properly)

https://apis-explorer.appspot.com/apis-explorer/?base=https://luci-config.appspot.com/_ah/api#p/config/v1/config.get_config_sets?config_set=projects%252Fchromium&include_last_import_attempt=true&_h=2&

Comment 2 by no...@chromium.org, Jul 20 2017

i mean, this should use luci-config-level validation, which is not implemented in luci-go yet

Comment 3 by efoo@chromium.org, Nov 21 2017

Labels: LUCI-KnownIssues-UI
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 21

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -OS-Mac
Status: Available (was: Untriaged)
What the next step here? Do we want to link to luci-config and the version being used? And on the luci config UI people can see there was a validation error?
i think the problems described in the bug description are not milo-specific and should be solved at the luci-config. I believe go/luci-config-contract solves them most generically and nicely.

The milo can just provide a link to luci-config.appspot.com page that displays validation errors, config import time, etc, etc.

Sign in to add a comment