New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 746861 link

Starred by 2 users
Status: Fixed
Owner:
l...@chromium.org
Closed: Jan 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools] Unnecessary horizontal scroll bar appears on colorpicker window.

Reported by dchau...@etouch.net, Jul 20 2017 
Chrome Version: 61.0.3162.0 (Official Build)46d636d25e054da0b0d8270d525c84f39146ce30-refs/heads/master@{#488073} 32/64-bit.
OS: Windows (7,8,8.1,10).

What steps will reproduce the problem?
1. Launch chrome, open DevTools and dock it to bottom.
2. Click to open ColorPicker window under Styles section and observe.

Unnecessary horizontal scroll bar appears on colorpicker window.
Horizontal scroll bar should not appear on colorpicker window.

This is a regression issue, broken in M-61 series, below is manual regression range.

Good build: 61.0.3161.0
Bad build: 61.0.3162.0

Note: This issue is not sen on Mac & Linux OS.

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
539 KB View Download
Expected behavior.mp4
533 KB View Download

Comment 1 by rbasuvula@chromium.org, Jul 20 2017

Labels: hasbisect-per-revision
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3161.0(Revision:487694).
Bad build:61.0.3162.0(Revision:488073).

You are probably looking for a change made after 487773 (known good), but no later than 487777 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+/3fb3c93697045d0406c201713eeb6da8be594860

From the CL above, assigning the issue to the concern owner

@luoe: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:  https://codereview.chromium.org/2980063002
Note :Windows specific issue and Able to reproduce in latest Canary #61.0.3162.0

Comment 2 by l...@chromium.org, Jul 20 2017

Labels: -Pri-1 Pri-2
Thanks for the report.  I will get access to a Windows machine and take a look.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b138420ed798a6f9d61e01b51bc604f93a89b897

commit b138420ed798a6f9d61e01b51bc604f93a89b897
Author: Erik Luo <luoe@chromium.org>
Date: Sat Jan 20 00:34:19 2018

DevTools: use measured scrollbar widths for GlassPane calculations

The GlassPane relies on an accurate scrollbar width to determine
correct popover dimensions. It used to hard code a number, but due
to overlay scrollbars, platform differences, and OS scrollbar size
settings, it could fail.

Screenshot: https://imgur.com/a/slnDX

Bug:  746861 
Change-Id: I8d37ff1842ba201bf26cdf6de6596716c4eab092
Reviewed-on: https://chromium-review.googlesource.com/876656
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530691}
[modify] https://crrev.com/b138420ed798a6f9d61e01b51bc604f93a89b897/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js
[modify] https://crrev.com/b138420ed798a6f9d61e01b51bc604f93a89b897/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Comment 4 by l...@chromium.org, Jan 20 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment