New issue
Advanced search Search tips

Issue 746822 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

jpeg_decode_accelerator_unittest should use GpuJpegDecodeAcceleratorFactoryProvider::GetAcceleratorFactories()

Project Member Reported by acourbot@chromium.org, Jul 20 2017

Issue description

As explained in https://chromium-review.googlesource.com/c/569529/16/media%252Fgpu%252Fjpeg_decode_accelerator_unittest.cc#137

jpeg_decode_accelerator_unittest should rely on GpuJpegDecodeAcceleratorFactoryProvider::GetAcceleratorFactories() to obtain its decoder instance.
 

Comment 1 by hiroh@chromium.org, Aug 18 2017

Owner: hiroh@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3244bc11b60f7478fc2adf93d85b21263470f395

commit 3244bc11b60f7478fc2adf93d85b21263470f395
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Thu Aug 24 07:51:22 2017

Create a jpeg decoder instance by GpuJDAFactoryProvider in JDA unittest

JDA unittest has created a jpeg decoder instance by a different method from
GpuJpegDecodeAcceleratorFactoryProvider.
It should rely on GpuJDAFactoryProvider::GetAcceleratorFactories().

BUG= chromium:746822 
BUG= chromium:754442 
TEST=JDA unittest on elm and an intel device.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id72291b2220e324cadb4241a2a6f8288ba579295
Reviewed-on: https://chromium-review.googlesource.com/620470
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496975}
[modify] https://crrev.com/3244bc11b60f7478fc2adf93d85b21263470f395/media/gpu/BUILD.gn
[modify] https://crrev.com/3244bc11b60f7478fc2adf93d85b21263470f395/media/gpu/jpeg_decode_accelerator_unittest.cc

Comment 3 by hiroh@chromium.org, Aug 24 2017

Status: Fixed (was: Started)

Sign in to add a comment