New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746817 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Longpress on Omnibox to copy/paste

Project Member Reported by pschaffner@chromium.org, Jul 20 2017

Issue description

We should show an edit menu that allows for copying/pasting things to/from the Omnibox when longpressed.

For now, the behavior should exactly mimic Safari, in that 3 possible states are possible:

1) Menu has 1 item (nothing in pasteboard): "Copy"
2) Menu has 2 items (non-URL string in pasteboard): "Copy | Paste and Search"
3) Menu has 2 items (URL string in pasteboard): "Copy | Paste and Go"
 
copy.png
97.8 KB View Download
copy-paste-and-search.png
101 KB View Download
copy-paste-and-go.png
100 KB View Download
Description: Show this description
Cc: jif@chromium.org justincohen@chromium.org rohitrao@chromium.org
Components: UI>Browser>Omnibox
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)
Is this still relevant? 
We have Paste and Search now. When it's a URL, it performs as Paste and Go but the string still says Paste and Search. 

Stepan: Is that WAI?
I asked the same question here:
 https://chromium-review.googlesource.com/c/chromium/src/+/1143279#message-1c3ee89219fd7038f03e27167ff8f69077d729ee

The answer from lod@ was:
"I implemented this as detailed in the bug. Checked with Pete irl and he confirmed that they discussed whether to go with Paste & Search vs Paste & Go, and consciously made the decision not to do so since the added value for users is very low."

I think there's value to doing "Paste and Search".
I agree with you, Justin.
That is why I asked whether it is WAI.

How easy/difficult is this adjustment?
I don't understand comment #4, as this is not the behavior in any of the channels. Regardless of what is in the clipboard – URL, non-URL string, or image (currently only in canary) – we say **Paste and Go**.

From what I recall about the IRL discussion with lod@ mentioned in comment #5, I said it would be OK with me to go with a generic string that covered both actions/scenarios if the complexity in implementing a "URL check" (in order to distinguish a "Paste and Go" vs a "Paste and Search") would make us miss our mark for shipping this feature.

At this point, I believe this particular issue is implemented and can be closed out, and that we can open a new bug to refine the feature by distinguishing between what is in the clipboard and updating our action strings accordingly.
Sounds good. Could you open a bug please about that? Thank you. 

Stepan/Justin: would one of you want to own this?
Status: Fixed (was: Assigned)
Filed  crbug.com/889905 

Sign in to add a comment