New issue
Advanced search Search tips

Issue 746804 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Jul 2017
Cc:
dominickn@chromium.org
w...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Task
Team-Security-UX



Sign in to add a comment

Test updating scores on chrome://site-engagement

Project Member Reported by dominickn@chromium.org, Jul 20 2017 
Score updating remains uncovered by tests. We should address this asap to prevent regressions like  crbug.com/730434  from happening again.

Assigning to calamity for now since this will be a JS WebUI test.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e2e39f368c8c5548b784b86243598e59746226d

commit 7e2e39f368c8c5548b784b86243598e59746226d
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Jul 24 04:55:30 2017

[Site Engagement WebUI] Add test for setting the base score.

Bug:  746804 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idbabd0d801e163d345842ea2c86c35fc0c733bf2
Reviewed-on: https://chromium-review.googlesource.com/578916
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488913}
[modify] https://crrev.com/7e2e39f368c8c5548b784b86243598e59746226d/chrome/browser/resources/engagement/site_engagement.js
[modify] https://crrev.com/7e2e39f368c8c5548b784b86243598e59746226d/chrome/test/data/webui/engagement/site_engagement_browsertest.js

Comment 2 by calamity@chromium.org, Jul 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment