New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746789 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Print preview does not load for any PDF file.

Reported by avsha...@etouch.net, Jul 20 2017

Issue description

Chrome version : 61.0.3162.0  (Official Build) 46d636d25e054da0b0d8270d525c84f39146ce30-refs/heads/master@{#488073} 32/64 bit
OS : Windows (7,8,10)

Test URL : http://orimi.com/pdf-test.pdf

What steps will reproduce the problem?
1. Launch chrome and navigate to above test URL.
2. Click on 'Print' button and observe the print preview.

Actual Result : Print preview does not load for PDF file and only 'loading preview' message is seen forever.

Expected Result : Print preview should load for all PDF files.

This is a regression issue broken in ‘M-61’, below is the Manual Regression range and will soon update other info.
Good build : 61.0.3160.0
Bad build : 61.0.3161.0

Note : Will soon update other info.
 

Comment 1 by avsha...@etouch.net, Jul 20 2017

Correction in manual regression range :
Good build : 61.0.3161.0
Bad build : 61.0.3162.0

Note : Above issue is seen for all PDF pages.

Actual_Result.mp4
1.5 MB View Download
Expected_Result.mp4
1.5 MB View Download

Comment 2 by avsha...@etouch.net, Jul 20 2017

Labels: OS-Linux
Update : 
Above issue is also seen in Linux(14.04 LTS) OS on latest #61.0.3162.0 build.

Comment 3 by avsha...@etouch.net, Jul 20 2017

Labels: OS-Mac
Update :
Above issue is also reproducible on Mac(10.11.6, 10.12.3, 10.12) OS with latest canary build #61.0.3162.0.
Cc: gov...@chromium.org ligim...@chromium.org
Labels: -Pri-1 hasbisect-per-revision ReleaseBlock-Dev Pri-0
Owner: thestig@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3161.0(Revision:487694).
Bad build:61.0.3162.0(Revision:488073).

You are probably looking for a change made after 487766 (known good), but no later than 487767 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/226c7626837b372dfa796fab3abfd6899f015f54..63b59677fad8c40d4b1dadb6259d9f99c564a204

From the CL above, assigning the issue to the concern owner

@thestig: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Reviewed-on: https://chromium-review.googlesource.com/571170
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.5.Able to reproduce the issue in below sites also https://pdfobject.com, www.pdf995.com &  http://orimi.com/pdf-test.pdf
Adding Release Block-Dev for this issue.Please remove if not the case.
Status: Started (was: Assigned)
Components: Internals>Plugins>PDF
Labels: -Pri-0 OS-Chrome Pri-1
And not a P0.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c30954c57b331427516ec6ca136b1310b094cd30

commit c30954c57b331427516ec6ca136b1310b094cd30
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Jul 20 22:41:17 2017

Fix print preview for PDF files.

The PDF plugin can receive a request to display a print preview with a 0
page count. It is a special meaning reserved for when the source of the
print preview is a PDF. In which case, just load the preview PDF in one
shot, instead of loading it incrementally.

BUG= 746789 

Change-Id: I3f9d99ebddffe9cedcc977dca03ccc2638f45011
Reviewed-on: https://chromium-review.googlesource.com/580495
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488455}
[modify] https://crrev.com/c30954c57b331427516ec6ca136b1310b094cd30/pdf/out_of_process_instance.cc

Status: Fixed (was: Started)
Labels: TE-Verified-61.0.3163.0 TE-Verified-M61
Thanks for the immediate fix! Tested the issue on Windows-10 & 7, Ubuntu 14.04 and Mac OS 10.12.5 using chrome latest Canary M61-61.0.3163.0 by following steps mentioned in the original comment. Observed that PDF print preview is displaying as expected. Hence adding TE-Verified label.

Please find the screen cast for reference.

Thank you!

746789.mp4
2.6 MB View Download
Status: Verified (was: Fixed)
Chrome OS 9765.5.0, 61.0.3163.11
Labels: TE-Verified-61.0.3163.13
Tested above issue on Windows(7,8,10) & Mac(10.11.6, 10.12.5) OS with Chrome Dev#61.0.3163.13 and issue is fixed now. PDF print preview is displaying for all PDF files and fix is working as intended.

Thank you!!
Retested this issue on Linux(14.04 LTS) OS using latest Dev#61.0.3163.13 build and PDF print preview is working as intended on Linux OS as well.

Sign in to add a comment