Exposing event_trigger in the FeatureEngagementTracker |
||
Issue descriptionevent_trigger is a required event for the configuration of the FeatureEngagementTracker. It is used to figure out how often the feature in-product help has been triggered, and also for tracking purposes of the success metrics (increasing feature usage). It would be useful to expose this event_trigger event in the public API of FeatureEngagementTracker. For each feature, you would then be able to check whether the feature enlightenment has been displayed for a certain period of time.
,
Jul 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c48668dae28f413a0ba8b5597b0543c25711483 commit 5c48668dae28f413a0ba8b5597b0543c25711483 Author: Tommy Nyquist <nyquist@chromium.org> Date: Sat Jul 29 05:09:38 2017 Expose TriggerState through feature_engagement::Tracker Some features require additional state tracking to figure out whether in-product help should be triggered, and some of this state tracking is both costly and possibly unnecessary. A typical unnecessary state would be if the in-product help has already triggered, and it's OK to wait until next time the browser restarts to see if it should be triggered again. This CL adds support for exposing the triggering state for in-product help. After the Tracker has been initialized, it is now possible to inspect whether a particular feature has already had its in-product help triggered. This still respects the particular |event_trigger| FeatureConfig of the in-product help. Plumbing for Android, in addition to related tests and mocks have also been updated, and lastly the OnceConditionValidator is updated to now set the |result.trigger_ok| flag correctly. The documentation is also updated to describe this new API. BUG= 746779 Change-Id: I81becdfadaee99ec6ee39cf5252d746ed7050e69 Reviewed-on: https://chromium-review.googlesource.com/590501 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#490629} [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/chrome/browser/feature_engagement/new_tab/new_tab_tracker_unittest.cc [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/components/feature_engagement/README.md [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/components/feature_engagement/internal/android/java/src/org/chromium/components/feature_engagement/internal/TrackerImpl.java [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/components/feature_engagement/internal/android/tracker_impl_android.cc [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/components/feature_engagement/internal/android/tracker_impl_android.h [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/components/feature_engagement/internal/once_condition_validator.cc [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/components/feature_engagement/internal/once_condition_validator_unittest.cc [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/components/feature_engagement/internal/tracker_impl.cc [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/components/feature_engagement/internal/tracker_impl.h [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/components/feature_engagement/internal/tracker_impl_unittest.cc [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/components/feature_engagement/public/BUILD.gn [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/Tracker.java [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/components/feature_engagement/public/tracker.h [modify] https://crrev.com/5c48668dae28f413a0ba8b5597b0543c25711483/ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm
,
Aug 10 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by sheriffbot@chromium.org
, Jul 20 2017