New issue
Advanced search Search tips

Issue 746774 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

refactor graphics_PowerConsumption test

Project Member Reported by ihf@chromium.org, Jul 20 2017

Issue description

[low priority]
Right now the server test graphics_PowerConsumption consists only of a single control file kicking off the client test graphics_WebGLAquarium. This is wrong, as it technically never runs. So we need to create a small server test class for it and kick off the power measurement from there[1]. In particular failures for AC like "Running on AC power. Please remove AC power cable." should be attributed to graphics_PowerConsumption and not as now to graphics_WebGLAquarium.
https://wmatrix.googleplex.com/testrun/unfiltered?test_ids=517401532

This should clean up all the noise in
https://wmatrix.googleplex.com/unfiltered?hide_missing=True&releases=tot&tests=graphics_WebGLAquarium&days_back=20

Once we have that we can consider adding graphics_WebGLAquarium to suite:bvt-inline.

[1] Check if we can kick off the test via the control.power file (might not be possible) 
client_at.run_test("graphics_WebGLAquarium.power", power_test=True)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0b48207f4b1e33084b15072c6e9e6e828099c0c5

commit 0b48207f4b1e33084b15072c6e9e6e828099c0c5
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Thu Jul 20 03:35:34 2017

graphics_WebGLAquarium: add to suite:bvt-perbuild.

BUG= chromium:746774 
TEST=None.

Change-Id: Ic82dea4e1fdae0ffb3bd683ee2e082e814d040d3
Reviewed-on: https://chromium-review.googlesource.com/578583
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/0b48207f4b1e33084b15072c6e9e6e828099c0c5/client/site_tests/graphics_WebGLAquarium/control

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2db52acd6a479fff5681c610b65a99c5d90ccd29

commit 2db52acd6a479fff5681c610b65a99c5d90ccd29
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Fri Jul 28 03:34:10 2017

graphics_PowerConsumption: Fix report error

Refactor graphics_PowerConsumption test so that the test can report to
graphics_PowerConsumption but to graphics_WebGLAquarium.

BUG= chromium:746774 
TEST=test_that lab_dut

Before:
07/24 19:56:47 tko parser ... graphics_WebGLAquarium graphics_WebGLAquarium

After:
07/24 19:35:29 tko parser ... test graphics_PowerConsumption graphics_PowerConsumption

Change-Id: I9eed99585290ebc067807b25622d4740a4ae3a15
Reviewed-on: https://chromium-review.googlesource.com/584095
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[add] https://crrev.com/2db52acd6a479fff5681c610b65a99c5d90ccd29/server/site_tests/graphics_PowerConsumption/graphics_PowerConsumption.py
[delete] https://crrev.com/f4fed38f8c0f0fdec690b2354c1a1722c673c915/server/site_tests/graphics_PowerConsumption/control.WebGLAquarium
[add] https://crrev.com/2db52acd6a479fff5681c610b65a99c5d90ccd29/server/site_tests/graphics_PowerConsumption/control

Comment 3 by pwang@chromium.org, Aug 2 2017

Status: Verified (was: Untriaged)
After R62-9786.0.0,
https://wmatrix.googleplex.com//unfiltered?&tests=graphics_WebGLAquarium&days_back=10&releases=tot&hide_missing=True
has no report suggesting 'Running on AC power. Please remove AC power cable.'

Sign in to add a comment