New issue
Advanced search Search tips

Issue 746763 link

Starred by 1 user
Status: Fixed
Owner:
jbudorick@chromium.org
Closed: Aug 2017
Cc:
dpranke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Generalize git index refresh to all platforms

Project Member Reported by jbudorick@chromium.org, Jul 20 2017 
Our build uses hardlinks to implement copies in many locations. Our bots use git reset when syncing repositories, which can interfere with hardlinks in ways that cause ninja to believe copied files are dirty when that isn't the case. This is discussed in more detail in issue 330461, issue 642711, and issue 740301.

sdefresne added https://codereview.chromium.org/2444403003/ last year to deal with this on the downstream iOS bots. I recently landed https://chromium-review.googlesource.com/c/577909/ to deal with it on upstream bots. We should generalize it, likely to the bot_update recipe module, to deal with it on all platforms.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/06e1aa0769771434750fc4ea80f87db84ca8acc6

commit 06e1aa0769771434750fc4ea80f87db84ca8acc6
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Jul 21 01:57:43 2017

Generalize git index refresh to bot_update.

Bug:  746763 
Change-Id: Id0cc8fd672421fe4049334077c6d1e63800524ee
Reviewed-on: https://chromium-review.googlesource.com/580327
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/06e1aa0769771434750fc4ea80f87db84ca8acc6/recipes/recipe_modules/bot_update/resources/bot_update.py
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/a3a515a470c026c2cb5da511bf62d0defd117b5a

commit a3a515a470c026c2cb5da511bf62d0defd117b5a
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Jul 21 02:08:35 2017

Revert "Generalize git index refresh to bot_update."

This reverts commit 06e1aa0769771434750fc4ea80f87db84ca8acc6.

Reason for revert: blocking Skia roll, at least.

Original change's description:
> Generalize git index refresh to bot_update.
> 
> Bug:  746763 
> Change-Id: Id0cc8fd672421fe4049334077c6d1e63800524ee
> Reviewed-on: https://chromium-review.googlesource.com/580327
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

TBR=iannucci@chromium.org,dpranke@chromium.org,jbudorick@chromium.org

Change-Id: I834e2acd17417c95d42e18fa26bba822c6f67007
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  746763 
Reviewed-on: https://chromium-review.googlesource.com/580767
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/a3a515a470c026c2cb5da511bf62d0defd117b5a/recipes/recipe_modules/bot_update/resources/bot_update.py
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/cba3ea7973e55c072a01a05f736aeca230346080

commit cba3ea7973e55c072a01a05f736aeca230346080
Author: John Budorick <jbudorick@chromium.org>
Date: Thu Aug 10 15:43:04 2017

Generalize git index refresh to bot_update. (RELAND)

Reland of https://chromium-review.googlesource.com/c/580327/

TBR=iannucci@chromium.org
Bug:  746763 
Change-Id: Icc3be87faa6c614a09b7406ce6e748abb2ad82da
Reviewed-on: https://chromium-review.googlesource.com/581268
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/cba3ea7973e55c072a01a05f736aeca230346080/recipes/recipe_modules/bot_update/resources/bot_update.py

Comment 4 by jbudorick@chromium.org, Aug 10 2017

Status: Started (was: Assigned)
The refresh is now integrated into bot_update. I'll close this out once I remove the iOS-specific refresh.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/844cd86c328c69e2b34be05944dabec216c932f5

commit 844cd86c328c69e2b34be05944dabec216c932f5
Author: John Budorick <jbudorick@chromium.org>
Date: Thu Aug 10 21:47:14 2017

Remove iOS-specific git index refresh.

Moved into bot_update in https://chromium-review.googlesource.com/c/581268

Bug:  746763 
Change-Id: I6334e541c7b6a6afa19501fbabee30192cf40d8c
Reviewed-on: https://chromium-review.googlesource.com/610510
Reviewed-by: smut <smut@google.com>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/explain.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/try.expected/without_patch_success.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/unified_builder_tester.expected/goma_compilation_failure.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/timed_out.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/errors.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/clobber_build.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/try.expected/icu_patch.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/target_cpu_missing.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/is_debug_missing.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/try.expected/patch_failure.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/api.py
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/basic.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/infra_failure.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/try.expected/basic.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/try.expected/goma_compilation_failure.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/try.expected/parent.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/unified_builder_tester.expected/goma_canary.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/webrtc/chromium_ios.expected/basic_goma_build.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/fyi.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/unified_builder_tester.expected/goma.json
[delete] https://crrev.com/58beb46f9cbcd9b90e4a2bc10c626c600b7f20f5/scripts/slave/recipe_modules/ios/examples/full.expected/refresh_git_index_failure.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.expected/clobber_checkout.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/try.expected/additional_compile_targets.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/try.expected/without_patch_failure.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/README.recipes.md
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/try.expected/no_tests.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipes/ios/try.expected/no_compilation.json
[modify] https://crrev.com/844cd86c328c69e2b34be05944dabec216c932f5/scripts/slave/recipe_modules/ios/examples/full.py

Comment 6 by jbudorick@chromium.org, Aug 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment