New issue
Advanced search Search tips

Issue 746758 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Nov 1
Cc:
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Allowing Default MediaSession Seeking Behavior

Reported by agd...@amazon.com, Jul 20 2017 
Note: This is a content API addition suggestion, not a bug. Discussed briefly with mlamouri over email.

The Content MediaSession API currently has default behavior for play/pause that can be used when the webpage hasn't added action handlers for the "play"/"pause" actions, but there's no easy way to implement default seek behavior when the webpage hasn't added action handlers for the "seekForward" and "seekBackward" actions.

Adding this would allow browsers to implement default seeking behavior and have FF/RW media keys have some effect on video playback if the website hasn't implemented action handlers for seeking.

Comment 2 by pbomm...@chromium.org, Jul 20 2017

Cc: mlamouri@chromium.org
Status: Available (was: Unconfirmed)
marking the bug as Available given the Cl is already submitted for review.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/316cce40074bf5e1ca9fa1a07aa423589a56b226

commit 316cce40074bf5e1ca9fa1a07aa423589a56b226
Author: Alec Douglas <agdoug@amazon.com>
Date: Tue Oct 31 13:28:08 2017

Add to MediaSession API to allow default seeking behavior

This change adds seekForward/seekBackward methods to MediaSession
interfaces that allow browsers to provide default behavior for the
seek action via the Content API.

For the most part, the routing simply mirrors the play/pause code
that serves a similar purpose.

There is not currently any Chromium code that uses this API - it
is being added for the benefit of other products built on top of
content/.

Bug:746758

TEST=updated existing tests

Change-Id: Ia522ca7762d78bfe6ed1b0a29ce87f6391a0e05f
Reviewed-on: https://chromium-review.googlesource.com/578737
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512810}
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/chromecast/browser/cast_media_blocker_unittest.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/audio_focus_manager_unittest.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/media_session_android.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/media_session_android.h
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/media_session_controller.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/media_session_controller.h
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/media_session_controller_unittest.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/media_session_impl.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/media_session_impl.h
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/media_session_impl_browsertest.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/media_session_impl_service_routing_unittest.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/media_session_impl_uma_unittest.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/media_session_player_observer.h
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/media_session_service_impl_browsertest.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/mock_media_session_player_observer.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/mock_media_session_player_observer.h
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/pepper_player_delegate.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/browser/media/session/pepper_player_delegate.h
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/common/media/media_player_delegate_messages.h
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/public/android/java/src/org/chromium/content/browser/MediaSessionImpl.java
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/public/android/java/src/org/chromium/content_public/browser/MediaSession.java
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/public/browser/media_session.h
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/renderer/media/renderer_webmediaplayer_delegate.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/renderer/media/renderer_webmediaplayer_delegate.h
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/renderer/media/webmediaplayer_ms.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/content/renderer/media/webmediaplayer_ms.h
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/media/blink/webmediaplayer_delegate.h
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/316cce40074bf5e1ca9fa1a07aa423589a56b226/tools/metrics/actions/actions.xml
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 31

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by agd...@amazon.com, Oct 31 

This has been resolved for a while, just needs to be marked as such.

Comment 6 by mlamouri@chromium.org, Nov 1

Status: Fixed (was: Untriaged)
►

Sign in to add a comment