New issue
Advanced search Search tips

Issue 746754 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 807241



Sign in to add a comment

Harmony: Page Info bubble anchors weird when it goes offscreen with --secondary-ui-md

Project Member Reported by tapted@chromium.org, Jul 20 2017

Issue description

Chrome Version       : 61.0.3161.0

(also related:  Issue 738289 )

What steps will reproduce the problem?
(1) chrome://flags/#secondary-ui-md Enabled
(2) Move browser to the right- or bottom- edge of the screen
(3) Open Page Info on, e.g., google.com


What is the expected result?

Sensible anchoring


What happens instead?

Weird anchoring - see attached.

bottom: Harmony anchoring applies a vertical offset which is in the wrong direction when flipping "above" the anchor view.

right: Harmony uses the entire location bar as its anchor view. This defeats the bubble flipping logic since any time the anchor view is wider than the bubble, attempting to flip will actually move the bubble _further_ offscreen.

Only happens on Windows -- Mac and Linux don't (currently) try to adjust the anchor when a bubble goes offscreen.
 
actual_bottom_edge.png
165 KB View Download
actual_right_edge.png
163 KB View Download
expected_bottom_edge.png
155 KB View Download
expected_right_edge.png
249 KB View Download
Labels: -Pri-2 Pri-3
Still repros.  There are two parts to this:

(1) Things that anchor to the whole location bar need to instead anchor to a portion of the width, e.g. just the security chip, or just the star, or whatever.  This will fix the left/right flipping issue.
(2) When the bottom of the dialog is used as the anchor edge (as is the case when flipping vertically), we probably need to eliminate the shadow below and the space for it.  Or else we're still accounting for arrow height and shouldn't be.

This does not block shipping Harmony phase 1.

Comment 2 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Blocking: 807241

Comment 4 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt
Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment