New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746729 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 747000
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

smoothness.gpu_rasterization.polymer failing on many Android Perf bots

Project Member Reported by mikec...@chromium.org, Jul 20 2017

Issue description

Going to attempt to bisect. Benchmark failing on many of the Android bots including Android Nexus 7v2 bot...

https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus7v2%20Perf/builds/267


 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jul 20 2017


=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : smoothness.gpu_rasterization.polymer
  Metric       : avg_surface_fps/avg_surface_fps

Revision             Exit Code      N
chromium@487676      1 +- N/A       20      good
chromium@487765      1 +- N/A       20      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests smoothness.gpu_rasterization.polymer

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973594822607654480


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jul 22 2017

Mergedinto: 747000
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : Hayato Ito
  Commit : b160073dd51148f56b6586a9902b8a24674886c4
  Date   : Wed Jul 19 04:33:31 2017
  Subject: Reland: Make /deep/ as no-op and remove ::shadow in dynamic profile

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : smoothness.gpu_rasterization.polymer
  Metric       : avg_surface_fps/avg_surface_fps

Revision             Exit Code      N
chromium@486073      0 +- N/A       20      good
chromium@486919      0 +- N/A       20      good
chromium@487342      0 +- N/A       20      good
chromium@487554      0 +- N/A       20      good
chromium@487660      0 +- N/A       20      good
chromium@487713      0 +- N/A       20      good
chromium@487739      0 +- N/A       20      good
chromium@487743      0 +- N/A       20      good
chromium@487744      0 +- N/A       20      good
chromium@487745      1 +- N/A       20      bad       <--
chromium@487746      1 +- N/A       20      bad
chromium@487753      1 +- N/A       20      bad
chromium@487765      1 +- N/A       20      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests smoothness.gpu_rasterization.polymer

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973528092994339760


For feedback, file a bug with component Speed>Bisection
Cc: nedngu...@google.com
Owner: vmi...@chromium.org
Status: Assigned (was: Duplicate)
Victor, you're listed as the owner of this benchmark. If you look at  bug 747000  where this CL broke another polymer-related test, the test was removed because the content is very outdated, still using /deep/ or ::shadow. Do we still need this benchmark?
Labels: -Pri-3 Pri-1
Upping priority, It is still failing. PTAL.

Comment 7 by vmi...@chromium.org, Jul 31 2017

Cc: sunn...@chromium.org briander...@chromium.org
Components: Internals>GPU>Testing
We need to update all tests to Polymer 2.0.  I'm going to disable the tests for now.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f97c81010a9b92178b0337c19c99cbfffc13c57

commit 6f97c81010a9b92178b0337c19c99cbfffc13c57
Author: Victor Miura <vmiura@chromium.org>
Date: Thu Aug 03 00:40:33 2017

[ChromiumPerf] Disable failing Polymer benchmarks

The Polymer page set is using deprecated feature (/deep/ selector)
and needs to be updated before re-enabling.

BUG= 746729 ,750876

Change-Id: Iac5eb3651d6c22f59e18c8271c9eb5270b44c3d6
Reviewed-on: https://chromium-review.googlesource.com/594908
Commit-Queue: Victor Miura <vmiura@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#491571}
[modify] https://crrev.com/6f97c81010a9b92178b0337c19c99cbfffc13c57/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/6f97c81010a9b92178b0337c19c99cbfffc13c57/tools/perf/benchmarks/smoothness.py
[modify] https://crrev.com/6f97c81010a9b92178b0337c19c99cbfffc13c57/tools/perf/benchmarks/thread_times.py

Status: Fixed (was: Assigned)
Closing.  Created 750876 to track updating the tests to Polymer 2.0.

Sign in to add a comment