New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746726 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 745160



Sign in to add a comment

On each host scan, keep Tether networks which are still available

Project Member Reported by hansberry@chromium.org, Jul 20 2017

Issue description

(Instead of jankily removing all Tether networks and then repopulating the list)
 
Blocking: 745160
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7830751b710ff32cee5d36c5524e217fd5e2a5e9

commit 7830751b710ff32cee5d36c5524e217fd5e2a5e9
Author: Kyle Horimoto <khorimoto@google.com>
Date: Sat Jul 22 00:05:21 2017

[CrOS Tether] Fix scan behavior of HostScanner.

Previously, when a scan began, we would clear all existing scan results
from the cache, then add results back to the cache as the scan
progressed. This was janky because it would result in the UI removing
Tether networks and then adding them back shortly afterwards when scan
results came in.

This CL changes this functionality so that results are only removed
after a scan ends and the associated device is not found.

Bug: 672263,  746726 
Change-Id: I6df2516b1bc0e604c3a496838804bc6ee5c8292c
Reviewed-on: https://chromium-review.googlesource.com/581633
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488817}
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/fake_host_scan_cache.cc
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/fake_host_scan_cache.h
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/host_scan_cache.h
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/host_scanner.cc
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/host_scanner.h
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/host_scanner_unittest.cc
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/master_host_scan_cache.cc
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/master_host_scan_cache.h
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/master_host_scan_cache_unittest.cc
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/network_host_scan_cache.cc
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/network_host_scan_cache.h
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/network_host_scan_cache_unittest.cc
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/persistent_host_scan_cache_impl.cc
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/persistent_host_scan_cache_impl.h
[modify] https://crrev.com/7830751b710ff32cee5d36c5524e217fd5e2a5e9/chromeos/components/tether/persistent_host_scan_cache_impl_unittest.cc

Labels: Merge-Request-61
Status: Fixed (was: Started)
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 23 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 25 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e71611e1bceddfe8fa4a757bcc33345f42677c3

commit 6e71611e1bceddfe8fa4a757bcc33345f42677c3
Author: Kyle Horimoto <khorimoto@google.com>
Date: Tue Jul 25 22:01:41 2017

[CrOS Tether] Fix scan behavior of HostScanner.

Previously, when a scan began, we would clear all existing scan results
from the cache, then add results back to the cache as the scan
progressed. This was janky because it would result in the UI removing
Tether networks and then adding them back shortly afterwards when scan
results came in.

This CL changes this functionality so that results are only removed
after a scan ends and the associated device is not found.

TBR=khorimoto@google.com

(cherry picked from commit 7830751b710ff32cee5d36c5524e217fd5e2a5e9)

Bug: 672263,  746726 
Change-Id: I6df2516b1bc0e604c3a496838804bc6ee5c8292c
Reviewed-on: https://chromium-review.googlesource.com/581633
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488817}
Reviewed-on: https://chromium-review.googlesource.com/584862
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#39}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/fake_host_scan_cache.cc
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/fake_host_scan_cache.h
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/host_scan_cache.h
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/host_scanner.cc
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/host_scanner.h
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/host_scanner_unittest.cc
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/master_host_scan_cache.cc
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/master_host_scan_cache.h
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/master_host_scan_cache_unittest.cc
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/network_host_scan_cache.cc
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/network_host_scan_cache.h
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/network_host_scan_cache_unittest.cc
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/persistent_host_scan_cache_impl.cc
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/persistent_host_scan_cache_impl.h
[modify] https://crrev.com/6e71611e1bceddfe8fa4a757bcc33345f42677c3/chromeos/components/tether/persistent_host_scan_cache_impl_unittest.cc

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment