New issue
Advanced search Search tips

Issue 746713 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

aura::Window::set_ignore_events() needs to update mus

Project Member Reported by sky@chromium.org, Jul 20 2017

Issue description

set_ignore_events is used to suppress events, this needs to be wired through to mus.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca58856ddbdfbb75d80c657838e5c9f9d327b174

commit ca58856ddbdfbb75d80c657838e5c9f9d327b174
Author: Scott Violet <sky@chromium.org>
Date: Sun Jul 23 20:38:10 2017

chromeos: converts Window::set_ignore_events() to EventTargetingPolicy

And plumbs through to mus.

BUG= 746713 
TEST=covered by tests

Change-Id: Ic4dc891dd2983f79f13e1c5edc74bbe1c1469acc
Reviewed-on: https://chromium-review.googlesource.com/580501
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488894}
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ash/display/cursor_window_controller.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ash/root_window_controller.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/components/exo/BUILD.gn
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/components/exo/DEPS
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/components/exo/shell_surface.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/local/window_port_local.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/local/window_port_local.h
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/window.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/window.h
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/window_event_dispatcher.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/window_event_dispatcher_unittest.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/window_port.h
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/window_port_for_shutdown.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/window_port_for_shutdown.h
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/window_targeter.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/aura/window_unittest.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/touch_selection/BUILD.gn
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/touch_selection/DEPS
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/touch_selection/touch_handle_drawable_aura.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/ca58856ddbdfbb75d80c657838e5c9f9d327b174/ui/views/widget/native_widget_aura.cc

Comment 2 by sky@chromium.org, Jul 24 2017

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment