BottomSheet can't scroll up on landscape & on the right side of split screen |
||||
Issue descriptionChrome Version: 61.0.3162.0 OS: Android 7.1.1 Device: Nexus phone What steps will reproduce the problem? (1) Open split screen in landscape (2) Put Chrome home on the right side (3) Raise the bottom sheet What is the expected result? Bottom sheet should come up What happens instead? Nothing
,
Jul 21 2017
Oh weird - I can't actually reproduce this issue, but I agree that it should be a P2.
,
Aug 10 2017
,
Aug 25 2017
I can reproduce. It only happens when Chrome is docked to the right side of the screen. In step #3, "raise the bottom sheet" means dragging it. The sheet opens if the expand button is present and tapped. In my simple log-based testing, it looks like BottomSheet#isTouchInSwipableXRange() is incorrectly returning false.
,
Aug 26 2017
I forgot to apply the window position to the start/end coords. Fix in progress.
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c7c74088e06c202ad1f8f68d35fa7f748d6fab1 commit 8c7c74088e06c202ad1f8f68d35fa7f748d6fab1 Author: Matthew Jones <mdjones@chromium.org> Date: Sat Aug 26 01:16:50 2017 [Home] Fix sheet swipe on multi-window Apply the window position x coordinate to the swipe logic to account for horizontal multi-window mode. BUG= 746706 Change-Id: I4f292f6b5a2bcf5dd12252c0b19d7ad628ded614 Reviewed-on: https://chromium-review.googlesource.com/636085 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#497626} [modify] https://crrev.com/8c7c74088e06c202ad1f8f68d35fa7f748d6fab1/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
,
Aug 28 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by twelling...@chromium.org
, Jul 20 2017Components: UI>Browser>Mobile>NavPanel
Labels: -Pri-3 M-62 Hotlist-Chrome-Home OS-Android Pri-2