Only display messages when no mobile networks are in the network list if Cellular technology is available |
||||||
Issue descriptionIf only Instant Tethering is enabled on the Chromebook, never display the Cellular-specific messages "No mobile network available" and "Searching for mobile networks...". If only Cellular is enabled, maintain existing behavior of using these messages as appropriate. If both Cellular and Instant Tethering are enabled, then only show the messages if the Mobile network list is empty (the Mobile network list comprising both the Cellular and Tether network lists). Thus, even if the Cellular network list is empty but the Tether network list is non-empty, do *not* show any messages.
,
Jul 19 2017
It's related; that's why I set this bug as a blocker on it. However that bug is broad and is getting noisy. I wanted to clearly state the task at hand in a new bug.
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54980622389248b75b598ce0890bcd0fa1de77cf commit 54980622389248b75b598ce0890bcd0fa1de77cf Author: Ryan Hansberry <hansberry@chromium.org> Date: Mon Jul 24 20:32:30 2017 Restrict when Cellular messages are displayed if Tether is enabled. This changes when Cellular message rows are displayed: - If Cellular is not available on the device, never show messages. - If the list of Mobile (i.e., Cellular and Tether) networks is non-empty, do not show messages. Bug: 746677 Change-Id: I8e93f3170db5d1effe566e2fb344d524b513dca1 Reviewed-on: https://chromium-review.googlesource.com/580151 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#489065} [modify] https://crrev.com/54980622389248b75b598ce0890bcd0fa1de77cf/ash/BUILD.gn [modify] https://crrev.com/54980622389248b75b598ce0890bcd0fa1de77cf/ash/DEPS [modify] https://crrev.com/54980622389248b75b598ce0890bcd0fa1de77cf/ash/system/network/network_icon.cc [modify] https://crrev.com/54980622389248b75b598ce0890bcd0fa1de77cf/ash/system/network/network_icon_unittest.cc
,
Jul 24 2017
,
Jul 25 2017
Approving merge to M61.
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dab825493f2fbf40bee26a4688a40f11329a301c commit dab825493f2fbf40bee26a4688a40f11329a301c Author: Kyle Horimoto <khorimoto@google.com> Date: Tue Jul 25 22:05:01 2017 Restrict when Cellular messages are displayed if Tether is enabled. This changes when Cellular message rows are displayed: - If Cellular is not available on the device, never show messages. - If the list of Mobile (i.e., Cellular and Tether) networks is non-empty, do not show messages. TBR=hansberry@chromium.org (cherry picked from commit 54980622389248b75b598ce0890bcd0fa1de77cf) Bug: 746677 Change-Id: I8e93f3170db5d1effe566e2fb344d524b513dca1 Reviewed-on: https://chromium-review.googlesource.com/580151 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489065} Reviewed-on: https://chromium-review.googlesource.com/585566 Cr-Commit-Position: refs/branch-heads/3163@{#40} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/dab825493f2fbf40bee26a4688a40f11329a301c/ash/BUILD.gn [modify] https://crrev.com/dab825493f2fbf40bee26a4688a40f11329a301c/ash/DEPS [modify] https://crrev.com/dab825493f2fbf40bee26a4688a40f11329a301c/ash/system/network/network_icon.cc [modify] https://crrev.com/dab825493f2fbf40bee26a4688a40f11329a301c/ash/system/network/network_icon_unittest.cc
,
Jul 25 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by khorimoto@chromium.org
, Jul 19 2017