Port Headless Chromium shell to Fuchsia |
|||||||||||
Issue descriptionAs a porting milestone, Headless Chromium will require us to get fundamentals like IPC, networking & sandboxing implemented, while taking advantage of existing Headless stubs to minimize dependencies on porting of other sub-systems like graphics and input.
,
Jul 25 2017
,
Jul 31 2017
Done. See findings doc, which calls out the major followup work items: https://docs.google.com/document/d/18qh1MRMKs8O5bmHp2nCNg0WJi1YyDs8-cu_Pxq76174/edit#
,
Jul 31 2017
Re-opening for blocking bug tracking.
,
Aug 1 2017
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b90efc3352fcc6d9a6160fb39232ad26fad1659 commit 6b90efc3352fcc6d9a6160fb39232ad26fad1659 Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 09 21:28:07 2017 fuchsia: flip on ozone and aura by default Bug: 746674 , 750943 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie1a1bbc4f8e8094d164c55ea5ce05de3159a7cb2 Reviewed-on: https://chromium-review.googlesource.com/609086 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: John Bauman <jbauman@chromium.org> Cr-Commit-Position: refs/heads/master@{#493143} [modify] https://crrev.com/6b90efc3352fcc6d9a6160fb39232ad26fad1659/build/config/ui.gni [modify] https://crrev.com/6b90efc3352fcc6d9a6160fb39232ad26fad1659/third_party/khronos/EGL/eglplatform.h [modify] https://crrev.com/6b90efc3352fcc6d9a6160fb39232ad26fad1659/third_party/khronos/README.chromium [modify] https://crrev.com/6b90efc3352fcc6d9a6160fb39232ad26fad1659/ui/base/material_design/material_design_controller.cc [modify] https://crrev.com/6b90efc3352fcc6d9a6160fb39232ad26fad1659/ui/ozone/common/gl_ozone_osmesa.cc
,
Aug 10 2017
,
Aug 10 2017
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d4d498af0e035ba75d4d25914652ad695627f89 commit 5d4d498af0e035ba75d4d25914652ad695627f89 Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Aug 10 19:29:28 2017 Fuchsia: add NOTIMPLEMENTED() stubs for sensor data consumer buffers. Bug: 750934 , 746674 Change-Id: Iec302dbf4c4e2ede9144e619083b78f2a5914ceb Reviewed-on: https://chromium-review.googlesource.com/609041 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#493497} [modify] https://crrev.com/5d4d498af0e035ba75d4d25914652ad695627f89/device/sensors/BUILD.gn [add] https://crrev.com/5d4d498af0e035ba75d4d25914652ad695627f89/device/sensors/data_fetcher_shared_memory_fuchsia.cc
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/143e53fb43b6dfbee260273daaa4b033c3edf1ec commit 143e53fb43b6dfbee260273daaa4b033c3edf1ec Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Aug 10 20:33:25 2017 Fuchsia: modify scripts to run non-test executables Fuchsia: modify scripts to run non-test executables * Move most test runner functionality to "runner_common.py", with the exception of gtest-specific logic. * Move the test-specific "main()" portions into "test_runner.py". * Add "exe_runner.py", a very thin wrapper around the test_common functionality. * Use stripped executables for building the bootfs file, which results in a substantially smaller file size (10x difference!) It's necessary for running larger executables like "headless_shell", which are enormous when unstripped, resulting in long mkbootfs times and higher RAM requirements for in-memory tmpfs disks. The unstripped executable remains intact alongside the stripped executable, for backtrace symbolization. * Add a GN template "fuchsia_executable_runner", which generates executable runner scripts on non-test targets. Bug: 746674 , 752364 Change-Id: Ia39c3d7fdf9bb574049f0112df84951c2e048f41 Reviewed-on: https://chromium-review.googlesource.com/602410 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#493524} [modify] https://crrev.com/143e53fb43b6dfbee260273daaa4b033c3edf1ec/build/config/fuchsia/rules.gni [rename] https://crrev.com/143e53fb43b6dfbee260273daaa4b033c3edf1ec/build/fuchsia/create_runner_script.py [add] https://crrev.com/143e53fb43b6dfbee260273daaa4b033c3edf1ec/build/fuchsia/exe_runner.py [add] https://crrev.com/143e53fb43b6dfbee260273daaa4b033c3edf1ec/build/fuchsia/runner_common.py [modify] https://crrev.com/143e53fb43b6dfbee260273daaa4b033c3edf1ec/build/fuchsia/test_runner.py [modify] https://crrev.com/143e53fb43b6dfbee260273daaa4b033c3edf1ec/headless/BUILD.gn
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c53b12be9d8c9de33d6e59e2b0bbf51d336d96f commit 0c53b12be9d8c9de33d6e59e2b0bbf51d336d96f Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 11 17:33:23 2017 fuchsia: repair debug/component compilation after switching use_aura on This is fallout from switching Aura on for Fuchsia in https://chromium.googlesource.com/chromium/src.git/+/6b90efc3352fcc6d9a6160fb39232ad26fad1659. We can use the generic Aura implementations (at least for stubs) rather than having _fuchsia-specific stubs. Bug: 743296 , 746674 Change-Id: I6ff96cbacc4fef54a1a1390288d57bb5b1dfcc7d Reviewed-on: https://chromium-review.googlesource.com/611412 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#493785} [modify] https://crrev.com/0c53b12be9d8c9de33d6e59e2b0bbf51d336d96f/ui/base/BUILD.gn [delete] https://crrev.com/a1d6b4b016198475f3d8819ea673b48f5c3a4d8d/ui/base/clipboard/clipboard_fuchsia.cc [delete] https://crrev.com/a1d6b4b016198475f3d8819ea673b48f5c3a4d8d/ui/base/clipboard/clipboard_fuchsia.h [delete] https://crrev.com/a1d6b4b016198475f3d8819ea673b48f5c3a4d8d/ui/base/cursor/cursor_loader_fuchsia.cc [modify] https://crrev.com/0c53b12be9d8c9de33d6e59e2b0bbf51d336d96f/ui/base/ime/BUILD.gn [modify] https://crrev.com/0c53b12be9d8c9de33d6e59e2b0bbf51d336d96f/ui/display/BUILD.gn [delete] https://crrev.com/a1d6b4b016198475f3d8819ea673b48f5c3a4d8d/ui/display/screen_fuchsia.cc
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f24e3740ea0a4f4371cb631308e4d8e759ae4adb commit f24e3740ea0a4f4371cb631308e4d8e759ae4adb Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 11 17:50:22 2017 fuchsia: Add dependency on //headless to get headless_shell target This lets gn generate build files that contain headless_shell as a target, but there's still lots of porting to be done to get it to actually build. Dependencies on crash reporting are excluded, as it is expected that a shipping product would rely on the Fuchsia system crash reporter, so Chrome itself does not need a separate one. Bug: 746674 , 753619 Change-Id: Id63ebeb1ed8e3a927e6ac8b368f89c9c010d440f Reviewed-on: https://chromium-review.googlesource.com/608810 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#493794} [modify] https://crrev.com/f24e3740ea0a4f4371cb631308e4d8e759ae4adb/BUILD.gn [modify] https://crrev.com/f24e3740ea0a4f4371cb631308e4d8e759ae4adb/headless/BUILD.gn
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee31212756358752036e722b3a60e8e81d81f1cd commit ee31212756358752036e722b3a60e8e81d81f1cd Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 11 18:09:05 2017 fuchsia: fix merge conflict in headless/BUILD.gn https://chromium-review.googlesource.com/c/608810/ and https://chromium-review.googlesource.com/606562 conflicted. TBR=skyostil Bug: 746674 Change-Id: Ibe8b7f78c75529bf5b5e4ba6471c7d2b68fadfe9 Reviewed-on: https://chromium-review.googlesource.com/612484 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#493811} [modify] https://crrev.com/ee31212756358752036e722b3a60e8e81d81f1cd/headless/BUILD.gn
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a39c1a68f8021c8cfc018d59e94fb53cd6ddb50 commit 8a39c1a68f8021c8cfc018d59e94fb53cd6ddb50 Author: Kevin Marshall <kmarshall@chromium.org> Date: Mon Aug 14 20:07:27 2017 Move WebRTC deps into enable_webrtc conditional blocks. This change moves WebRTC deps and dependent files behind the "enable_webrtc" arg so that "content" can be built for Fuchsia, which doesn't support WebRTC yet. Also set enable_webrtc=false for Fuchsia. Bug: 746674 Change-Id: Ifec88ae2b43b13f9a685fe9944f4aa5d16eee97f Reviewed-on: https://chromium-review.googlesource.com/609341 Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#494154} [modify] https://crrev.com/8a39c1a68f8021c8cfc018d59e94fb53cd6ddb50/content/common/BUILD.gn [modify] https://crrev.com/8a39c1a68f8021c8cfc018d59e94fb53cd6ddb50/content/public/renderer/BUILD.gn [modify] https://crrev.com/8a39c1a68f8021c8cfc018d59e94fb53cd6ddb50/media/media_options.gni
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42c92f894d4fa7c0ee8633f42d5e9bafad93e885 commit 42c92f894d4fa7c0ee8633f42d5e9bafad93e885 Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 18 19:45:58 2017 fuchsia: Stub SelectFileDialog Needed for headless_shell in is_component_mode=true. Bug: 743296 , 746674 Change-Id: Idcec3a837dab82557876bc49d33e47a3b9405e8b Reviewed-on: https://chromium-review.googlesource.com/621396 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#495651} [modify] https://crrev.com/42c92f894d4fa7c0ee8633f42d5e9bafad93e885/ui/shell_dialogs/BUILD.gn [add] https://crrev.com/42c92f894d4fa7c0ee8633f42d5e9bafad93e885/ui/shell_dialogs/select_file_dialog_fuchsia.cc
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ec652a0aa0cd5e0bad5110a5491888478c00bc3 commit 5ec652a0aa0cd5e0bad5110a5491888478c00bc3 Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 18 20:08:14 2017 fuchsia: Add missing stub method on ChildProcessLauncherHelper Needed for headless_shell in is_component_mode=true. Bug: 743296 , 746674 Change-Id: Ie121968e2a23058a6da1fb1dabcd3bce21d163a2 Reviewed-on: https://chromium-review.googlesource.com/621397 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#495662} [modify] https://crrev.com/5ec652a0aa0cd5e0bad5110a5491888478c00bc3/content/browser/child_process_launcher_helper_fuchsia.cc
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5459cc3e30f0a2d79046d76ae60f309b6494061b commit 5459cc3e30f0a2d79046d76ae60f309b6494061b Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 18 20:16:30 2017 fuchsia: Add implementation of GetFontList_SlowBlocking() Needed for headless_shell in is_component_mode=true. Bug: 743296 , 746674 Change-Id: I8a7bf90a8b0456b0efddf5f1e4f37ee60db5d97b Reviewed-on: https://chromium-review.googlesource.com/621399 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#495663} [modify] https://crrev.com/5459cc3e30f0a2d79046d76ae60f309b6494061b/content/common/BUILD.gn [add] https://crrev.com/5459cc3e30f0a2d79046d76ae60f309b6494061b/content/common/font_list_fuchsia.cc
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61ea11ee9494e1863fbf88819dceef85397e5ac5 commit 61ea11ee9494e1863fbf88819dceef85397e5ac5 Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 18 20:22:15 2017 fuchsia: Stub process_metrics' GetSystemMemoryInfo Needed for headless_shell in is_component_mode=true. Bug: 706592, 743296 , 746674 Change-Id: Ic2fba5cad27a171542c36fb1ccae0168a93089e5 Reviewed-on: https://chromium-review.googlesource.com/621422 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#495665} [modify] https://crrev.com/61ea11ee9494e1863fbf88819dceef85397e5ac5/base/process/process_metrics.h [modify] https://crrev.com/61ea11ee9494e1863fbf88819dceef85397e5ac5/base/process/process_metrics_fuchsia.cc
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9c09d0ef9d990fe508d581364b9c5f1a22a0e3a commit f9c09d0ef9d990fe508d581364b9c5f1a22a0e3a Author: Scott Graham <scottmg@chromium.org> Date: Fri Aug 18 20:30:12 2017 fuchsia: Add no-op implementation of HasSeekPenalty Needed for headless_shell in is_component_mode=true. Bug: 743296 , 746674 Change-Id: I538cddef2db42b82527a0d3cb13fe77f48710e35 Reviewed-on: https://chromium-review.googlesource.com/621766 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#495669} [modify] https://crrev.com/f9c09d0ef9d990fe508d581364b9c5f1a22a0e3a/components/metrics/BUILD.gn [add] https://crrev.com/f9c09d0ef9d990fe508d581364b9c5f1a22a0e3a/components/metrics/drive_metrics_provider_fuchsia.cc
,
Aug 18 2017
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d16fb5da029cd5c18f648d07aafe31398d304b3 commit 5d16fb5da029cd5c18f648d07aafe31398d304b3 Author: Kevin Marshall <kmarshall@chromium.org> Date: Fri Aug 18 21:52:27 2017 Fuchsia: Add headless_shell to chromium.fyi Fuchsia bot targets. Bug: 746674 Change-Id: I2d50d4f4e959deac7c641e8b02b188cbcb5893e9 Reviewed-on: https://chromium-review.googlesource.com/619810 Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#495703} [modify] https://crrev.com/5d16fb5da029cd5c18f648d07aafe31398d304b3/testing/buildbot/chromium.fyi.json
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd62ab798044d0c88dff947c9e51798b6f99d9b6 commit bd62ab798044d0c88dff947c9e51798b6f99d9b6 Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 23 16:17:26 2017 fuchsia: Have fuchsia use more of _ozone for gpu and ui, using StubGL Bug: 746674 , 754861 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4f4485d11a3a4ac6f1ccf6afeb5485e7acb1b344 Reviewed-on: https://chromium-review.googlesource.com/627596 Reviewed-by: John Bauman <jbauman@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496701} [modify] https://crrev.com/bd62ab798044d0c88dff947c9e51798b6f99d9b6/gpu/config/gpu_control_list.cc [modify] https://crrev.com/bd62ab798044d0c88dff947c9e51798b6f99d9b6/gpu/config/gpu_control_list.h [modify] https://crrev.com/bd62ab798044d0c88dff947c9e51798b6f99d9b6/gpu/ipc/in_process_command_buffer.cc [modify] https://crrev.com/bd62ab798044d0c88dff947c9e51798b6f99d9b6/ui/gl/init/BUILD.gn [delete] https://crrev.com/1a113d423eecfcdf82a5354be090bdee22efb408/ui/gl/init/gl_factory_fuchsia.cc [delete] https://crrev.com/1a113d423eecfcdf82a5354be090bdee22efb408/ui/gl/init/gl_initializer_fuchsia.cc [modify] https://crrev.com/bd62ab798044d0c88dff947c9e51798b6f99d9b6/ui/gl/test/gl_surface_test_support.cc [modify] https://crrev.com/bd62ab798044d0c88dff947c9e51798b6f99d9b6/ui/ozone/platform/headless/headless_surface_factory.cc
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dab3f12cdb2a2116d1cad33f571182f013e36609 commit dab3f12cdb2a2116d1cad33f571182f013e36609 Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 23 18:06:23 2017 fuchsia: Add missing headless dependencies for is_component_mode Needed for headless_shell in is_component_mode=true. Bug: 743296 , 746674 Change-Id: I18f7e7338a1a08edfaa773a59f54a86ace4b6df1 Reviewed-on: https://chromium-review.googlesource.com/621768 Reviewed-by: Eric Seckler <eseckler@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496737} [modify] https://crrev.com/dab3f12cdb2a2116d1cad33f571182f013e36609/headless/BUILD.gn
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf0983132001f40c403ccfda04128d3a012bee20 commit cf0983132001f40c403ccfda04128d3a012bee20 Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 23 19:40:48 2017 fuchsia: update SelectFileDialog after unique_ptr change Signature changed at https://chromium-review.googlesource.com/c/chromium/src/+/619613, but there's only a fuchsia release, no fuchsia (dbg) on the CQ/waterfall yet, and it happens to link in release without this. Bug: 743296 , 746674 Change-Id: Ifeb7663a9338b9e424ebb39fac6408989ca0b43c Reviewed-on: https://chromium-review.googlesource.com/629199 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496769} [modify] https://crrev.com/cf0983132001f40c403ccfda04128d3a012bee20/ui/shell_dialogs/select_file_dialog_fuchsia.cc
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50d80e2dd76f3796f4ee6e553a6ed74cf011ec8e commit 50d80e2dd76f3796f4ee6e553a6ed74cf011ec8e Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 23 20:39:02 2017 fuchsia: Add headless_shell and content_unittests to Fuchsia Compile (to match fyi bot) Bug: 746674 , 754861 Change-Id: If4a314e1e8c4eddcfeee1ea2a7db442c03b6d2b3 Reviewed-on: https://chromium-review.googlesource.com/628643 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#496794} [modify] https://crrev.com/50d80e2dd76f3796f4ee6e553a6ed74cf011ec8e/testing/buildbot/chromium.linux.json
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a8d0ae9c4b3c7161e99a50ddd8d932273151cc1 commit 4a8d0ae9c4b3c7161e99a50ddd8d932273151cc1 Author: Scott Graham <scottmg@chromium.org> Date: Wed Aug 23 21:27:16 2017 Revert "fuchsia: Add headless_shell and content_unittests to Fuchsia Compile (to match fyi bot)" This reverts commit 50d80e2dd76f3796f4ee6e553a6ed74cf011ec8e. Reason for revert: Mojo build files are bad and should feel bad. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FFuchsia_Compile%2F364%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout I don't think this has anything to do with this CL (the tryrun was green), rather it just happens to be a relatively clean build so the fetch_api_request mojom failed. Original change's description: > fuchsia: Add headless_shell and content_unittests to Fuchsia Compile (to match fyi bot) > > Bug: 746674 , 754861 > Change-Id: If4a314e1e8c4eddcfeee1ea2a7db442c03b6d2b3 > Reviewed-on: https://chromium-review.googlesource.com/628643 > Commit-Queue: Scott Graham <scottmg@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#496794} TBR=scottmg@chromium.org,jbudorick@chromium.org Change-Id: I76f93bd5fef945584c23b9c759f5a3047c9da5b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 746674 , 754861 Reviewed-on: https://chromium-review.googlesource.com/629898 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496806} [modify] https://crrev.com/4a8d0ae9c4b3c7161e99a50ddd8d932273151cc1/testing/buildbot/chromium.linux.json
,
Aug 24 2017
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f81e2e317fc3873b79c46148e6d873e6c2e8963 commit 3f81e2e317fc3873b79c46148e6d873e6c2e8963 Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Aug 24 20:15:12 2017 Fuchsia: return a realistic value for SharedMemory::GetHandleLimit() The layer tree code uses GetHandleLimit() to compute a maximum number of resources. The existing code returns the max value for size_t, which is so large that it blows up sanity checks in LayerTreeHostImpl. This CL returns a more realistic constant, taken from the Fuchsia kernel code. Bug: 746674 Change-Id: I16d125675abaf87ab1ff62e09b01318970db6fc8 Reviewed-on: https://chromium-review.googlesource.com/634164 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#497172} [modify] https://crrev.com/3f81e2e317fc3873b79c46148e6d873e6c2e8963/base/memory/shared_memory_fuchsia.cc
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70bfb3970fbfc2dee544039f24f402f3185a444e commit 70bfb3970fbfc2dee544039f24f402f3185a444e Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Aug 24 22:55:37 2017 Fuchsia: Enforce launching with --no-sandbox, until sandbox is ready. Bug: 746674 Change-Id: I222573e6824a1ca9188ccb18508b5a017ca984b7 Reviewed-on: https://chromium-review.googlesource.com/633466 Reviewed-by: Wez <wez@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#497235} [modify] https://crrev.com/70bfb3970fbfc2dee544039f24f402f3185a444e/content/renderer/renderer_main_platform_delegate_fuchsia.cc
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fafbbc09f858baab12a1c82cfedc31fdd3830166 commit fafbbc09f858baab12a1c82cfedc31fdd3830166 Author: Kevin Marshall <kmarshall@chromium.org> Date: Fri Aug 25 18:21:06 2017 Fuchsia: Implement platform portions of ChildProcessLauncherHelper. Bug: 746674 Change-Id: Ia48bdbaf31b0eef2640b94aa7207bfe97a723bf7 Reviewed-on: https://chromium-review.googlesource.com/634284 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#497466} [modify] https://crrev.com/fafbbc09f858baab12a1c82cfedc31fdd3830166/content/browser/child_process_launcher_helper_fuchsia.cc
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32eca5128a93adada834c1db5de058f540f97d4a commit 32eca5128a93adada834c1db5de058f540f97d4a Author: Kevin Marshall <kmarshall@chromium.org> Date: Fri Aug 25 20:25:03 2017 Fuchsia: Introduce application-managed Magenta "default job" for launching child processes. This API allows a process which launches child processes to set its own enumerable job as the default, so that APIs like base::Process::Open() can then look up child processes by Id, with the right scoping. See the Magenta documentation at docs/objects/job.md for more information. Bug: 746674 Change-Id: I3918b13d28f08092609619386847ccba51c613c9 Reviewed-on: https://chromium-review.googlesource.com/634283 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#497519} [modify] https://crrev.com/32eca5128a93adada834c1db5de058f540f97d4a/base/BUILD.gn [add] https://crrev.com/32eca5128a93adada834c1db5de058f540f97d4a/base/fuchsia/default_job.cc [add] https://crrev.com/32eca5128a93adada834c1db5de058f540f97d4a/base/fuchsia/default_job.h
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe2f08ca01f71d646ae17fa81817bb8c5571a194 commit fe2f08ca01f71d646ae17fa81817bb8c5571a194 Author: Kevin Marshall <kmarshall@chromium.org> Date: Fri Aug 25 21:45:29 2017 Fuchsia: Actually return the executable path from PathProviderFuchsia. Bug: 746674 Change-Id: I4406148e5ba7c178f47b490ead9a8e76d9571457 Reviewed-on: https://chromium-review.googlesource.com/634045 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#497547} [modify] https://crrev.com/fe2f08ca01f71d646ae17fa81817bb8c5571a194/base/base_paths_fuchsia.cc [modify] https://crrev.com/fe2f08ca01f71d646ae17fa81817bb8c5571a194/base/path_service_unittest.cc [modify] https://crrev.com/fe2f08ca01f71d646ae17fa81817bb8c5571a194/testing/buildbot/filters/fuchsia.base_unittests.filter
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d65d47b4668adac4e6ad2f833c67311ba4c7d1e2 commit d65d47b4668adac4e6ad2f833c67311ba4c7d1e2 Author: Kevin Marshall <kmarshall@chromium.org> Date: Fri Aug 25 22:57:22 2017 Fuchsia: Create and register a new default job in BrowserMainLoop. This allows the Browser to create its own job so that it can "see" child processes for renderers, utility processes, etc, and it does so before any processes, or threads, are spawned. Bug: 746674 Change-Id: I005b8eb2c89daeb5e9a50f770ef702c66c87b6d1 Reviewed-on: https://chromium-review.googlesource.com/634285 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#497578} [modify] https://crrev.com/d65d47b4668adac4e6ad2f833c67311ba4c7d1e2/content/browser/browser_main_loop.cc
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6c7a41180e0de143cdf753410fafece1e97a9a3 commit a6c7a41180e0de143cdf753410fafece1e97a9a3 Author: Kevin Marshall <kmarshall@chromium.org> Date: Fri Aug 25 23:39:12 2017 Fuchsia: Integrate child job support into LaunchProcess. * Use GetDefaultJob() instead of mx_job_default(). * Add custom logic for setting child process' default job handle. * Explicitly handle invalid job handles in LaunchProcess. Bug: 746674 Change-Id: I6c32b39dbf73d0b085b746b6d8cc4098d680a5de Reviewed-on: https://chromium-review.googlesource.com/634287 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#497596} [modify] https://crrev.com/a6c7a41180e0de143cdf753410fafece1e97a9a3/base/process/launch_fuchsia.cc
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bbc81e078d9508bf5c4598ba70591a39d5ca78b commit 8bbc81e078d9508bf5c4598ba70591a39d5ca78b Author: Scott Graham <scottmg@chromium.org> Date: Sat Aug 26 02:25:47 2017 Revert "Revert "fuchsia: Add headless_shell and content_unittests to Fuchsia Compile (to match fyi bot)"" This reverts commit 4a8d0ae9c4b3c7161e99a50ddd8d932273151cc1. Reason for revert: https://chromium.googlesource.com/chromium/src/+/b660a88a3c3af5e75187b60a2667f3436053153c has landed, this part of the build shouldn't flake now. Original change's description: > Revert "fuchsia: Add headless_shell and content_unittests to Fuchsia Compile (to match fyi bot)" > > This reverts commit 50d80e2dd76f3796f4ee6e553a6ed74cf011ec8e. > > Reason for revert: Mojo build files are bad and should feel bad. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FFuchsia_Compile%2F364%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout > > I don't think this has anything to do with this CL (the tryrun was green), rather it just happens to be a relatively clean build so the fetch_api_request mojom failed. > > Original change's description: > > fuchsia: Add headless_shell and content_unittests to Fuchsia Compile (to match fyi bot) > > > > Bug: 746674 , 754861 > > Change-Id: If4a314e1e8c4eddcfeee1ea2a7db442c03b6d2b3 > > Reviewed-on: https://chromium-review.googlesource.com/628643 > > Commit-Queue: Scott Graham <scottmg@chromium.org> > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#496794} > > TBR=scottmg@chromium.org,jbudorick@chromium.org > > Change-Id: I76f93bd5fef945584c23b9c759f5a3047c9da5b1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 746674 , 754861 > Reviewed-on: https://chromium-review.googlesource.com/629898 > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#496806} TBR=scottmg@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 746674 , 754861 Change-Id: I788ac868fffa995ce65c9b0cf641ee6dfa24301e Reviewed-on: https://chromium-review.googlesource.com/636526 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#497638} [modify] https://crrev.com/8bbc81e078d9508bf5c4598ba70591a39d5ca78b/testing/buildbot/chromium.linux.json
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71a6a8e8bf0ffbf501d5726d04c8388736605d97 commit 71a6a8e8bf0ffbf501d5726d04c8388736605d97 Author: Wez <wez@chromium.org> Date: Mon Aug 28 19:38:05 2017 Fuchsia: Add platform implementation for Mojo WrapAttachmentImpl. * Fix buggy DLOG_IF() logging statement. Bug: 746674 Change-Id: I878dfaac8f574d9c6c6c97c0040077a7f59eec4d Reviewed-on: https://chromium-review.googlesource.com/636783 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#497843} [modify] https://crrev.com/71a6a8e8bf0ffbf501d5726d04c8388736605d97/ipc/handle_attachment_fuchsia.cc [modify] https://crrev.com/71a6a8e8bf0ffbf501d5726d04c8388736605d97/ipc/handle_attachment_fuchsia.h [modify] https://crrev.com/71a6a8e8bf0ffbf501d5726d04c8388736605d97/ipc/ipc_channel_mojo.cc [modify] https://crrev.com/71a6a8e8bf0ffbf501d5726d04c8388736605d97/mojo/edk/embedder/platform_handle.h
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69f798e6d8a230cc269b446fab2f5a8005960c18 commit 69f798e6d8a230cc269b446fab2f5a8005960c18 Author: Kevin Marshall <kmarshall@chromium.org> Date: Tue Aug 29 23:28:38 2017 Fuchsia: use Skia empty FontMgr, fix FontPlatformDataFuchsia impl. This CL replaces the Fuchsia-specific FontMgr stub with Skia's empty FontMgr implementation, which provides the barest implementation required to no-op without breaking Skia. Other changes: * Add typeface setter call to FontPlatformDataFuchsia. The previous implementation did not fully initialize the SkPaint* object. Bug: 746674 Change-Id: I6b6e8d8ae9e1cc83e87df0168ab9fb8f4bcfaf96 Reviewed-on: https://chromium-review.googlesource.com/639058 Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#498284} [modify] https://crrev.com/69f798e6d8a230cc269b446fab2f5a8005960c18/skia/BUILD.gn [delete] https://crrev.com/89200318ea992274cafe78423c2095299b461d08/skia/ext/fontmgr_default_fuchsia.cc [delete] https://crrev.com/89200318ea992274cafe78423c2095299b461d08/skia/ext/fontmgr_default_fuchsia.h [modify] https://crrev.com/69f798e6d8a230cc269b446fab2f5a8005960c18/third_party/WebKit/Source/platform/fonts/fuchsia/FontPlatformDataFuchsia.cpp
,
Dec 8 2017
,
Dec 8 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by w...@chromium.org
, Jul 19 2017