New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746666 link

Starred by 5 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 748918



Sign in to add a comment

MD Settings: Unwanted text selection when clicking toggle label.

Project Member Reported by dpa...@chromium.org, Jul 19 2017

Issue description

At  issue 691783  all text within MD Settings was made selectable, which has created some cases where text is accidentally selected, see screencast, where clicking on the label of a toggle button, not only toggles the button but also selects the text.
 
selectable_toggle_text.mp4
206 KB View Download

Comment 1 by dpa...@chromium.org, Jul 19 2017

Labels: OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 2 by dpa...@chromium.org, Jul 20 2017

Cc: kavvaru@chromium.org gajendr...@samsung.com brajkumar@chromium.org ajha@chromium.org
 Issue 746793  has been merged into this issue.

Comment 3 by dpa...@chromium.org, Jul 20 2017

Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
Summary: MD Settings: Unwanted text selection when clicking toggle label. (was: MD Settings: Selectable text within cilckable toggle label seems odd.)
Does this only happen when multi-clicking?
Does it not happen if the checkbox is clicked?
Even without the text selection, the checkbox is toggling with every click (i.e. regardless of text selection the user would be toggling the same checkbox back and forth rapidly), is that right?
In the end, the check-box state is unaffected by whether text is selected (i.e. the side effect is harmless)?

In inclined to say this works as expected/intended. Is there something more wrong with it that I may be missing?

Comment 5 by dpa...@chromium.org, Jul 21 2017

> Does this only happen when multi-clicking?
1st click -> toggles checkbox,
2nd click -> toggles checkbox again + selects the text.

If the 2nd click happens after a certain timeout text selection does not happen. So in a way this is "multi-clicking" only.

> Does it not happen if the checkbox is clicked?
It does not happen.

>Even without the text selection, the checkbox is toggling with every click
Yes, the checkbox state is working as expected.

>the side effect is harmless
"harmless" as in it does not prevent the user from getting things done. Not "harmless" from a UX perspective, since it looks odd.

> Is there something more wrong with it that I may be missing
Yes. As a user, I am not expecting Text to be selectable when clicking on a "hand" pointer target. It should only be selectable when the cursor is showing the "|" symbol.

Owner: bettes@chromium.org
Okay, that's rather conflicts with the decision in  Issue 691783 .
Let's find out which Alan prefers (i.e. where should the trade-off be made).

Alan, would you prefer that:
- text is selectable even with a hand-pointer (if so this but is WontFix)
- or text is not selectable with a hand-pointer (if so, please make me Owner again)
- or that use a different pointer* (if so, let us know what specifically)

Alan, I'm cool with talking about this with all of us on Monday, if ya like. 

*(some programs use combo-pointers, but I'm not saying that's a good idea, just trying to list all the options I've thought of)

Comment 7 by dpa...@chromium.org, Jul 21 2017

Proposal (discussed with @dschuyler on chat): An actionable thing should not have its text selected when the action is taking place.

In other words, the text should still be selectable, but it should not get selected "accidentally" while the action is taking place.

See trivial example at https://jsfiddle.net/bkzj4qez/. Clicking/multi-clicking the button does not select its text. Click and hold outside the button, then drag over the button selects the text.
Is there a way to prevent clicking from triggering selection, but still allow selection via drag?
Blocking: 748918
 Issue 748918  is blocked by this bug mostly for the Alan's decision on selections vs something else. So they're not a dupe, but they are related.
Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Assigned)
Discussed this over the UX meeting, and regarded it as a non-issue given this is a non-detrimental consequence of having the whole row item clickable – which was considered better for usability than restricting the click to the component itself.

If there's strong feelings or thoughts on how to improve this, feel free to take ownership.
Cc: steve...@chromium.org hcarmona@chromium.org
 Issue 826241  has been merged into this issue.
Cc: msrchandra@chromium.org ranjitkan@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org
 Issue 773195  has been merged into this issue.

Sign in to add a comment