New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746658 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Pipe up certificate verification errors for Cast channel

Project Member Reported by ryanchung@chromium.org, Jul 19 2017

Issue description

Also record metrics for more detailed types of errors to understand the issues out in the field.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fccb33ed98cdc4ccb8e4f2b012dc230e58e13ec5

commit fccb33ed98cdc4ccb8e4f2b012dc230e58e13ec5
Author: Ryan Ki Sing Chung <ryanchung@chromium.org>
Date: Fri Jul 21 01:12:44 2017

Pipe errors from Cast certificate verification and report metrics.

Make certificate verification errors available to the Cast sender through
the Cast channel interface.

Increase metric reporting details to get a better picture of any issues
out in the field.

Bug:  746658 
Test: Unittests
Change-Id: I568220d3949aa3878b71a1c62c5cc01c79d09dbb
Reviewed-on: https://chromium-review.googlesource.com/577114
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Ryan Chung <ryanchung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488534}
[modify] https://crrev.com/fccb33ed98cdc4ccb8e4f2b012dc230e58e13ec5/chrome/browser/extensions/api/networking_private/networking_private_crypto.cc
[modify] https://crrev.com/fccb33ed98cdc4ccb8e4f2b012dc230e58e13ec5/components/cast_certificate/cast_cert_validator.cc
[modify] https://crrev.com/fccb33ed98cdc4ccb8e4f2b012dc230e58e13ec5/components/cast_certificate/cast_cert_validator.h
[modify] https://crrev.com/fccb33ed98cdc4ccb8e4f2b012dc230e58e13ec5/components/cast_certificate/cast_cert_validator_unittest.cc
[modify] https://crrev.com/fccb33ed98cdc4ccb8e4f2b012dc230e58e13ec5/components/cast_certificate/cast_crl_unittest.cc
[modify] https://crrev.com/fccb33ed98cdc4ccb8e4f2b012dc230e58e13ec5/components/cast_channel/cast_auth_util.cc
[modify] https://crrev.com/fccb33ed98cdc4ccb8e4f2b012dc230e58e13ec5/components/cast_channel/cast_auth_util_unittest.cc
[modify] https://crrev.com/fccb33ed98cdc4ccb8e4f2b012dc230e58e13ec5/net/cert/internal/verify_certificate_chain.h
[modify] https://crrev.com/fccb33ed98cdc4ccb8e4f2b012dc230e58e13ec5/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment