New issue
Advanced search Search tips

Issue 746587 link

Starred by 1 user
Status: Fixed
Owner:
aleventhal@chromium.org
Closed: Jul 2017
Cc:
dmazz...@chromium.org
aboxhall@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Team-Accessibility

Blocking:
issue 746621



Sign in to add a comment

Support ARIA values of "undefined"/""

Project Member Reported by aleventhal@chromium.org, Jul 19 2017 
The following properties have boolean or token values, and a value of "undefined" should be treated the same as the attribute not being present:
aria-atomic
aria-autocomplete
aria-busy
aria-checked
aria-current
aria-disabled
aria-dropeffect
aria-expanded
aria-grabbed
aria-haspopup
aria-hidden
aria-invalid
aria-live
aria-modal
aria-multiline
aria-multiselectable
aria-orientation
aria-pressed
aria-readonly
aria-relevant
aria-required
aria-selected
aria-sort

Mozilla has implemented this -- here is the issue in their system:
https://bugzil.la/894573

Comment 1 by aleventhal@chromium.org, Jul 19 2017

Blocking: 746621

Comment 2 by aleventhal@chromium.org, Jul 20 2017

Summary: Support ARIA values of "undefined"/"" (was: Support ARIA values of "undefined")
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a619721826747a80ca59f2ffa17d2f9220a1f5e

commit 6a619721826747a80ca59f2ffa17d2f9220a1f5e
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Wed Jul 26 18:51:52 2017

Support literal string "undefined" and empty string in ARIA values

For boolean and token properties, a value of "undefined"/"" should be treated the
same as the attribute not being present.

Bug:  746587 
Change-Id: I2148c8b6c69d724aa289d9000e160a7d66cbe322
Reviewed-on: https://chromium-review.googlesource.com/578491
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489713}
[modify] https://crrev.com/6a619721826747a80ca59f2ffa17d2f9220a1f5e/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[add] https://crrev.com/6a619721826747a80ca59f2ffa17d2f9220a1f5e/content/test/data/accessibility/aria/aria-empty-string-expected-blink.txt
[add] https://crrev.com/6a619721826747a80ca59f2ffa17d2f9220a1f5e/content/test/data/accessibility/aria/aria-empty-string.html
[add] https://crrev.com/6a619721826747a80ca59f2ffa17d2f9220a1f5e/content/test/data/accessibility/aria/aria-undefined-expected-blink.txt
[add] https://crrev.com/6a619721826747a80ca59f2ffa17d2f9220a1f5e/content/test/data/accessibility/aria/aria-undefined-literal-expected-blink.txt
[add] https://crrev.com/6a619721826747a80ca59f2ffa17d2f9220a1f5e/content/test/data/accessibility/aria/aria-undefined-literal.html
[add] https://crrev.com/6a619721826747a80ca59f2ffa17d2f9220a1f5e/content/test/data/accessibility/aria/aria-undefined.html
[modify] https://crrev.com/6a619721826747a80ca59f2ffa17d2f9220a1f5e/third_party/WebKit/Source/core/dom/AccessibleNode.cpp
[modify] https://crrev.com/6a619721826747a80ca59f2ffa17d2f9220a1f5e/third_party/WebKit/Source/core/dom/AccessibleNode.h
[modify] https://crrev.com/6a619721826747a80ca59f2ffa17d2f9220a1f5e/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/6a619721826747a80ca59f2ffa17d2f9220a1f5e/third_party/WebKit/Source/modules/accessibility/AXObject.h

Comment 4 by aleventhal@chromium.org, Jul 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment