1. extract [is=paper-icon-button-light] styles from settings to the shared cr_elements/ directory 2. convert paper-icon-button in MD Extensions to paper-icon-button-light 3. reuse the newly created paper-icon-button-light style in MD Extensions
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2672be183a7c6760f0163892b7633db9880c8c65 commit 2672be183a7c6760f0163892b7633db9880c8c65 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Aug 02 01:48:22 2017 [MD extensions] paper-icon-button to paper-icon-button-light This CL changes the <paper-icon-button> elements to <button> with is="paper-icon-button-light". Bug: 746584 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I045badb04115139ac3f624f9b6a57d161dafc55c Reviewed-on: https://chromium-review.googlesource.com/588012 Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#491192} [modify] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/chrome/browser/resources/md_extensions/error_page.html [modify] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/chrome/browser/resources/md_extensions/shortcut_input.html [modify] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/chrome/browser/resources/settings/settings_icons_css.html [modify] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/chrome/test/data/webui/extensions/extension_error_page_test.js [modify] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/ui/webui/resources/cr_elements/cr_icons_css.html [modify] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html [modify] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/ui/webui/resources/cr_elements/icons.html [modify] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/ui/webui/resources/cr_elements_images.grdp [rename] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/ui/webui/resources/images/icon_arrow_back.svg [add] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/ui/webui/resources/images/icon_menu_white.svg [add] https://crrev.com/2672be183a7c6760f0163892b7633db9880c8c65/ui/webui/resources/images/icon_refresh.svg
Related CL to adjust ripple sizes on these buttons at https://chromium-review.googlesource.com/c/599070
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abf2baa0ea9f1c5cf21abcb274191894eedb8837 commit abf2baa0ea9f1c5cf21abcb274191894eedb8837 Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Aug 03 20:39:15 2017 [MD extensions] adjust paper-icon-button-light ripple sizes This CL removes some CSS overrides that were making paper-icon-button-light ripple sizes incorrect. So this fix is to remove the overrides. (relates to 746584) Bug: 746584 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I88e1bae2eed231e6dd5b6a6f0e78405e5e220a64 Reviewed-on: https://chromium-review.googlesource.com/599070 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#491832} [modify] https://crrev.com/abf2baa0ea9f1c5cf21abcb274191894eedb8837/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/abf2baa0ea9f1c5cf21abcb274191894eedb8837/chrome/browser/resources/md_extensions/shortcut_input.html
Comment 1 by dschuyler@chromium.org
, Jul 26 2017Status: Assigned (was: Available)