New issue
Advanced search Search tips

Issue 746582 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

paygen_au: update_engine_performance_monitor.py', '--stop-bg'

Project Member Reported by dhadd...@chromium.org, Jul 19 2017

Issue description

During the AU test, we run a performance monitoring script.

In the most recent runs sometimes stopping the script is failing and the test gives up.
Failing to capture performance metrics should not be a test failure. 

It looks like the process no longer exists

Traceback (most recent call last):
  File "/mnt/stateful_partition/unencrypted/preserve/update_engine_performance_monitor.py", line 268, in <module>
    os.kill(instance_pid, signal.SIGTERM)
OSError: [Errno 3] No such process


I will make this more robust too


 
Only seems to show up on delta payload runs so far 
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6349fe648d91edd26451f61138faaa1795deabd1

commit 6349fe648d91edd26451f61138faaa1795deabd1
Author: David Haddock <dhaddock@chromium.org>
Date: Fri Jul 21 02:25:55 2017

Log warning if we can't retrieve perf metrics for au test.

Simply changing the logging level.

BUG= chromium:746582 
TEST=None

Change-Id: I7fb8e7110f9d7d7724400a641c4b37afc7635e69
Reviewed-on: https://chromium-review.googlesource.com/579789
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/6349fe648d91edd26451f61138faaa1795deabd1/server/site_tests/autoupdate_EndToEndTest/autoupdate_EndToEndTest.py

Cc: dhadd...@chromium.org
 Issue 746586  has been merged into this issue.
 Issue 747209  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/01d78cc8c029b8196dd1a49ba6bc6b21a228bf0e

commit 01d78cc8c029b8196dd1a49ba6bc6b21a228bf0e
Author: David Haddock <dhaddock@chromium.org>
Date: Fri Jul 21 04:21:27 2017

Don't fail AU test if we fail to retrieve performance metrics.

Catching perf metrics in the test is nice but it shouldn't cause a
canary to go red if we cannot get them.

BUG= chromium:746582 
TEST=test passes

Change-Id: I4984eb08bc683b54d27fa845dc0c462553604a5c
Reviewed-on: https://chromium-review.googlesource.com/580067
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/01d78cc8c029b8196dd1a49ba6bc6b21a228bf0e/lib/auto_updater.py

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Labels: FixedByAURewrite

Sign in to add a comment