@mmenke - I did a bisect and found that your CL seems to have caused this issue. https://codereview.chromium.org/2978443002

I'm not too familiar with the net stack but based on some print-debugging it seems like DevToolsNetworkTransaction is no longer throttling (https://cs.chromium.org/chromium/src/chrome/browser/devtools/devtools_network_transaction.cc?type=cs&q=DevToolsNetworkTransaction&sq=package:chromium&l=48).
 Perhaps your refactoring somehow affected whether DevToolsNetworkTransaction gets used or not?

I noticed in your comment on the code review that you planned to land it after the branch point but I believe your CL made it before the branch point which is today (https://chromepmo.appspot.com/calendar). What do you think about reverting this patch for the release branch?

We do have a few tests for network throttling but it seems like none of them caught it, so I'll make a note to add one. Thank you.

You're right - I wasn't thinking when I landed it just before branch.  I'm reverting now.  I'll merge the revert if I reverted after branch.

I'll re-land next week.  We'll need to think about how we want this to work in post-OOP network stack world.

(Also, the change is sufficiently large that I think it makes more sense to add the feature back after re-landing, rather than squeezing it into a pretty big CL)

Forgot to link this bug, but the revert's now landed in https://bugs.chromium.org/p/chromium/issues/detail?id=734199

[+rdsmith]:  Just FYI.  I'll have to add a hideous interface to URLRequestContextBuilder for this.

Requesting to merge https://codereview.chromium.org/2986623002 (A clean revert) to M61.

Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b090f508c6735d85b0418075f6f0d5042b848bc0

commit b090f508c6735d85b0418075f6f0d5042b848bc0
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Jul 26 02:12:44 2017

Revert of Make ProfileIOData use URLRequestContextBuilder (patchset #12 id:330001 of https://codereview.chromium.org/2978443002/ )

Reason for revert:
Wasn't thinking when I landed this just before branch.

Original issue's description:
> Make ProfileIOData use URLRequestContextBuilder
>
> BUG= 734199 
>
> Review-Url: https://codereview.chromium.org/2978443002
> Cr-Commit-Position: refs/heads/master@{#487590}
> Committed: https://chromium.googlesource.com/chromium/src/+/189ddf60b2f4034a2ab6efb16e22ea389b2b779f

TBR=mmenke@chromium.org, rdsmith@chromium.org
BUG= 734199 , 746576 #c3

(cherry picked from commit 8636cbd6b9449dd374d6879b6fad0e8ed7bf61de)

Review-Url: https://codereview.chromium.org/2986623002
Cr-Original-Commit-Position: refs/heads/master@{#488562}
Change-Id: Iff1b60065f76c6fad9aea8e82c5fa7a3ff584ebc
Reviewed-on: https://chromium-review.googlesource.com/585894
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#47}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/io_thread.cc
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/io_thread.h
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/net/proxy_service_factory.cc
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/net/proxy_service_factory.h
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/profiles/off_the_record_profile_io_data.h
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/profiles/profile_impl_io_data.h
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/b090f508c6735d85b0418075f6f0d5042b848bc0/net/url_request/url_request_context_builder.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae6a4eaded5d143dc65beb5703efd6e7d4536a8f

commit ae6a4eaded5d143dc65beb5703efd6e7d4536a8f
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Jul 26 22:15:21 2017

Fix DevTools throttling.

This was broken in  https://codereview.chromium.org/2978443002, which
completely refactored network stack configuration, and no tests caught
the breakage.

Bug:  746576 , 734199 
Change-Id: Ib0fdd0fff3a988c91302b4ba6778a41b55b20d9a
Reviewed-on: https://chromium-review.googlesource.com/582935
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489774}
[modify] https://crrev.com/ae6a4eaded5d143dc65beb5703efd6e7d4536a8f/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/ae6a4eaded5d143dc65beb5703efd6e7d4536a8f/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/ae6a4eaded5d143dc65beb5703efd6e7d4536a8f/net/url_request/url_request_context_builder.h

Thanks for the report, michaelsanford0!

Thanks for the very speedy fix! =)

 Issue 753023  has been merged into this issue.

Although the issue seems fixed, I think there is still an issue with open websocket connections.

I am using a tool called Ionic Framework (https://ionicframework.com), which (I believe) uses a web socket to signal a reload of the page when the application code changes.

Repro steps:

1. Open the websocket (in my case, I start my ionic project)
2. Go offline
3. Send a message (in my case, I change a line of code in the project, signaling that the browser needs to be refreshed)
3. The message is received (in my case, the browser tries to refresh)

I can open a new ticket if this warrants one.

Thanks,
Carl

Our network throttling implementation does not affect websocket connections. Unfortunately this isn't simple to fix but we are aware of this use case as more sites rely on websockets.

That's too bad, but glad it's something you're aware of!

Thanks for the quick response!