New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746575 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Flaky test BidirectionalStreamQuicTest#testStreamFailBeforeWriteIsExecutedOnNetworkThread

Project Member Reported by mge...@chromium.org, Jul 19 2017

Issue description

When the test shuts down the QUIC test server it expects QUIC_PEER_GOING_AWAY but the flakes get QUIC_PACKET_READ_ERROR.  If QUIC_PACKET_READ_ERROR is an acceptable outcome for this situation, perhaps we can augment the test to also accept QUIC_PACKET_READ_ERROR.

Comment 2 by mge...@chromium.org, Jul 20 2017

Cc: lassey@chromium.org

Comment 3 by mmenke@chromium.org, Jul 20 2017

Should we disable the test in the meantime?  It seems like half the times I land a CL, I get an email about a Cronet test failure that I had nothing to do with (for a change).
Cc: -xunji...@chromium.org
Owner: xunji...@chromium.org
Status: Started (was: Untriaged)
Thanks Paul and Miriam. I am on it.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bdde14d64903c44d5e42df643d881e77f3e0336

commit 4bdde14d64903c44d5e42df643d881e77f3e0336
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Jul 20 22:17:58 2017

[cronet] Fix BidirectionalStreamQuicTest#testStreamFailBeforeWriteIsExecutedOnNetworkThread flake

The assertion on quic detail error code is flaky.
Sometimes we get QUIC_PACKET_READ_ERROR.
The test is meant to test that there is no crash.
The detail error information is not crucial. This test removes it.

Bug:  746575 
Change-Id: I53800ee57aced2cd5aa22d67d39de022f47ac9ce
Reviewed-on: https://chromium-review.googlesource.com/580533
Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488438}
[modify] https://crrev.com/4bdde14d64903c44d5e42df643d881e77f3e0336/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java

Status: Fixed (was: Started)
The flaky test assertion I removed appeared to be the only test coverage for the detailed quic error code for bidi stream. Follow-up is at  Issue 747136 .

Sign in to add a comment