Issue metadata
Sign in to add a comment
|
Issues with Chromevox on login screen |
||||||||||||||||||||||
Issue descriptionTurn on Chromevox on login screen. There're several notable issues, including: Regression because of UI revamp: 1) Search+Right from options menu button goes to "Disabled" button. Expected: the extra focus on the disabled button should be removed. Non-regression but urgent: 1) The password field is focused three times. There are two extra instances of hearing "Password" when hitting search+right, but the first time is the only time it is editable. Expected: it should only focus once. 2) The screen reader only says 'Image' without any description when the profile avatar is focused. Expected: the screen reader should skip the image until more descriptive texts for images are available. 3) When the entire user pod is focused, screen readers say a long list of sub-items including image and name. Expected: (please suggest) Screen reader should only say the user name when the entire pod is focused, and the specific name elements inside the pod is skipped to avoid repetition.
,
Jul 19 2017
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/351f88e379d5ec6177580b70980ffd9b70d27262 commit 351f88e379d5ec6177580b70980ffd9b70d27262 Author: Wenzhao Zang <wzang@chromium.org> Date: Thu Jul 20 19:49:21 2017 Fix several accessibility issues on login screen (1) Remove extra focus on the disabled dropdown menu button. (2) Make password field focused only once instead of three times. (3) Assign the user name as ARIA label for the entire pod. (4) Skip image until more descriptive texts are available. Bug: 746568 Change-Id: I4ed9918947a3a7f03fe84ebbf64ab94be7e88475 Reviewed-on: https://chromium-review.googlesource.com/578459 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488363} [modify] https://crrev.com/351f88e379d5ec6177580b70980ffd9b70d27262/ui/login/account_picker/md_user_pod_row.js [modify] https://crrev.com/351f88e379d5ec6177580b70980ffd9b70d27262/ui/login/account_picker/md_user_pod_template.html
,
Jul 20 2017
,
Aug 8 2017
,
Aug 8 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9 2017
Pls apply appropriate OSs. Thank you.
,
Aug 9 2017
,
Aug 9 2017
Approving merge to M61 Chrome OS.
,
Aug 14 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 14 2017
,
Aug 16 2017
Sorry, I'm confused -- the fix applied totally breaks ChromeVox. Now, on the login screen, the text field is entirely invisible. Please revert.
,
Aug 16 2017
FYI lpalmaro@. Adjusting milestone; the above change should not be merged.
,
Aug 16 2017
As a further note, the reason why you're hearing the password three times is because the page is setting tabindex=0 on a containing div. This is the way a page indicates a DOM element is focusable, so ChromeVox will navigate to it. The div then contains a label for the password as well as finally, the password input itself.
,
Aug 16 2017
Actually, it looks like that change landed in m61 which is why I guess the change was never merged... adjusting milestone back.
,
Aug 16 2017
dtseng@ why is this dev blocking if the fix is already merged to M61?
,
Aug 16 2017
The "fix" is a further regression. It's what is causing 753463
,
Aug 16 2017
Removing dev block in favor of tracking things in 753463 to reduce confusion.
,
Aug 16 2017
To be clear, reverting the CL will make the images and dots heard again, but we are still investigating crbug.com/753463 .
,
Aug 29 2017
To sum up the current status of the four issues in the bug description: 1) Search+Right from options menu button goes to "Disabled" button. The fix was reverted by dtseng@, I'm preparing another CL to address this. 2) The password field is focused three times. Fixed. 3) The screen reader only says 'Image' without any description when the profile avatar is focused. The fix was reverted by dtseng@, and I'll leave it as is. 4) When the entire user pod is focused, screen readers say a long list of sub-items including image and name. Fixed.
,
Aug 29 2017
Add dtseng@ for suggestions: currently when you navigate to the drop down menu of the user pod, it says: 'Options menu for [account name]', but after pressing 'Search+Forward' again it says 'Disabled Button', instead of going to other parts of the UI. I believe the fix is to hide the paper-icon-button here: https://cs.chromium.org/chromium/src/ui/login/account_picker/md_user_pod_template.html?l=105 Do you have a better idea? Or you don't mind having the 'Disabled Button'? Please suggest. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by wzang@chromium.org
, Jul 19 2017