New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746563 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

NoN touch devices: UI glitch on new app launcher while searching the apps

Project Member Reported by songsuk@chromium.org, Jul 19 2017

Issue description

Chrome Version       : 61.0.3159.8
Platform             : 9756.1.0  - Candy


What steps will reproduce the problem?
(1)  open the App Launchers
(2)  try to search the apps from the Search field
(3)  check the search suggestions list on the app launcher

What is the expected result?  What happens instead?
Unable to read the strings since the strings are too bold. Please see the attached images. I'm seeing the issue inconsistently. 

Please provide any additional information below. Attach a screenshot if
possible.
  
 
applauncher1.png
451 KB View Download
applauncher2.png
330 KB View Download
Cc: vadimt@chromium.org
Summary: UI glitch on new app launcher while searching the apps (was: UI glitch on App Launcher while searching the apps )
Seems the issue happens when searching the apps/extensions which are stored in Chrome web store. 

Step: 
1. try to enter the "sudoku" on the Search field. Then, "Add to chrome" button appears on the suggestions list on the app launcher.  I'm seeing the issue after  showing the ""Add to chrome" button. 
addtochrome.png
855 KB View Download
Cc: songsuk@chromium.org
 Issue 746639  has been merged into this issue.
Components: Platform>Apps>AppLauncher
Labels: ReleaseBlock-Dev
Seen on Reks device as well - 9756.1.0/61.0.3159.8

Marking this as a Dev blocker, as the text is totally unreadable to select an app to use it further. 
Please feel free to change it if needed.
Cc: sdantul...@chromium.org mkarkada@chromium.org abod...@chromium.org
Summary: Touchable launcher: UI glitch on new app launcher while searching the apps (was: UI glitch on new app launcher while searching the apps )
Reproduced on all NON Touch devices but not on touch devices.
Summary: NoN touch devices: UI glitch on new app launcher while searching the apps (was: Touchable launcher: UI glitch on new app launcher while searching the apps )
Cc: dsunk...@chromium.org
Owner: abodenha@chromium.org
abodenha@ can you please take a look? This looks pretty bad. Would you block dev for this?
Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Spoke to  abodeti@.. making it a beta blocker.
Owner: vadimt@chromium.org
Owner: newcomer@chromium.org
Status: Started (was: Untriaged)
Found a fix for this.
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3972d81fa9ae294e5cceb75d3cd8e1f4fdec464

commit a3972d81fa9ae294e5cceb75d3cd8e1f4fdec464
Author: Alex Newcomer <newcomer@chromium.org>
Date: Wed Jul 26 21:14:28 2017

cros: Fix breaking searchbox text in new launcher

Breaks text on samus.
Fixed by drawing the rect instead of skipping it for the
new launcher.

Bug:  746563 
Change-Id: I93b208d4781861c18303cba50a8268f578c51c2a
Reviewed-on: https://chromium-review.googlesource.com/585781
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489758}
[modify] https://crrev.com/a3972d81fa9ae294e5cceb75d3cd8e1f4fdec464/ui/app_list/views/search_result_view.cc

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
Labels: Merge-Request-61
Project Member

Comment 19 by sheriffbot@chromium.org, Jul 27 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by sheriffbot@chromium.org, Jul 31 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7826863a78dee4de857939277f565463d0ac1996

commit 7826863a78dee4de857939277f565463d0ac1996
Author: Maajid <maajid@chromium.org>
Date: Mon Jul 31 21:15:52 2017

cros: Fix breaking searchbox text in new launcher

Breaks text on samus.
Fixed by drawing the rect instead of skipping it for the
new launcher.

TBR=newcomer@chromium.org

(cherry picked from commit a3972d81fa9ae294e5cceb75d3cd8e1f4fdec464)

Bug:  746563 
Change-Id: I93b208d4781861c18303cba50a8268f578c51c2a
Reviewed-on: https://chromium-review.googlesource.com/585781
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489758}
Reviewed-on: https://chromium-review.googlesource.com/594936
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#182}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/7826863a78dee4de857939277f565463d0ac1996/ui/app_list/views/search_result_view.cc

 Issue 750859  has been merged into this issue.
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9985985766911f64a17053fff4575733568447ed

commit 9985985766911f64a17053fff4575733568447ed
Author: Weidong Guo <weidongg@chromium.org>
Date: Mon Aug 14 22:57:26 2017

Fix broken text in fullscreen app list

Known issue:
All text in SearchResultPageView is broken randomly when typing query in
the search box. One work-around fix is setting a solid color background.
But setting SearchResultView's background color will cause issue in
 crbug.com/752685  and overwrite the border corner radius of
SearchResultPageView during animation.

Changes:
1. Set all the text's background to be kCardBackgroundColorFullscreen to
prevent broken text while not breaking the animation.
2. Adjust price and rating's bounds to avoid one's solid background
blocking the other's.

BUG= 746563 , 752685 

Change-Id: I0ed538776957623e07a3a4a3aab08ee3ed5d46a3
Reviewed-on: https://chromium-review.googlesource.com/612723
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494224}
[modify] https://crrev.com/9985985766911f64a17053fff4575733568447ed/ui/app_list/views/search_result_tile_item_view.cc
[modify] https://crrev.com/9985985766911f64a17053fff4575733568447ed/ui/app_list/views/search_result_view.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9520038a27b395e7bb78e2789139fb16906c905e

commit 9520038a27b395e7bb78e2789139fb16906c905e
Author: Vadim Tryshev <vadimt@google.com>
Date: Mon Aug 21 21:24:03 2017

Fix broken text in fullscreen app list

Known issue:
All text in SearchResultPageView is broken randomly when typing query in
the search box. One work-around fix is setting a solid color background.
But setting SearchResultView's background color will cause issue in
 crbug.com/752685  and overwrite the border corner radius of
SearchResultPageView during animation.

Changes:
1. Set all the text's background to be kCardBackgroundColorFullscreen to
prevent broken text while not breaking the animation.
2. Adjust price and rating's bounds to avoid one's solid background
blocking the other's.

BUG= 746563 , 752685 
TBR=weidongg@chromium.org

(cherry picked from commit 9985985766911f64a17053fff4575733568447ed)

Change-Id: I0ed538776957623e07a3a4a3aab08ee3ed5d46a3
Reviewed-on: https://chromium-review.googlesource.com/612723
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494224}
Reviewed-on: https://chromium-review.googlesource.com/624796
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#718}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/9520038a27b395e7bb78e2789139fb16906c905e/ui/app_list/views/search_result_tile_item_view.cc
[modify] https://crrev.com/9520038a27b395e7bb78e2789139fb16906c905e/ui/app_list/views/search_result_view.cc

Project Member

Comment 25 by sheriffbot@chromium.org, Oct 3 2017

Labels: -Merge-TBD
Status: Verified (was: Fixed)
9901.66.0, 62.0.3202.82 stable

Sign in to add a comment