New issue
Advanced search Search tips

Issue 746561 link

Starred by 1 user
Status: Fixed
Owner:
finnur@chromium.org
Closed: Aug 2017
Cc:
twelling...@chromium.org
peter@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Clank Media Picker: 'Done' button should be Roboto Medium 14sp

Project Member Reported by owe...@chromium.org, Jul 19 2017 
Feedback from UI review: Can we also make sure that DONE is Roboto Medium 14sp? Looks like it might be Regular or less than 400

Note from Owen: it's not clear if it's actually not already Roboto Medium 14sp, or if the screenshots we were looking at just came from a large device.

AI is to confirm it is correct and fix if not.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d501a2115838879233d7744d7370b49a25bc1ea8

commit d501a2115838879233d7744d7370b49a25bc1ea8
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Mon Aug 14 11:27:32 2017

Photo Picker dialog: Set Done button font face and size.

Bug:  746561 
Change-Id: I4db6e4ba8136f94f8c318a134fd03488fad6b4dd
Reviewed-on: https://chromium-review.googlesource.com/612342
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494032}
[modify] https://crrev.com/d501a2115838879233d7744d7370b49a25bc1ea8/chrome/android/java/res/layout/photo_picker_toolbar.xml

Comment 2 by finnur@chromium.org, Aug 14 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment